Commit d06d5fc8 authored by Carlos Garnacho's avatar Carlos Garnacho Committed by Robert Mader

wayland: Ensure pointer constraint region consistency

Changes in games between fullscreen and windowed modes may trigger
chaotic situations where the buffer and the frame size temporarily
disagree, producing rectangles with negative width/height. This is
usually followed by other updates that bring the pointer constraint
up to date.

This makes cairo panic and return an "error" empty region, which breaks
deeper down when using the region rectangles to apply the pointer
constraint.

If we hit this situation, ignore the frame rectangle, and just go with
the buffer rectangle.

Part-of: <!1655>

(cherry picked from commit 98ef6d0d)
parent 93f3ce3c
Pipeline #246171 passed with stages
in 6 minutes and 15 seconds
......@@ -625,12 +625,15 @@ meta_wayland_pointer_constraint_calculate_effective_region (MetaWaylandPointerCo
frame->right_width);
actual_height = window->buffer_rect.height - (frame->child_y +
frame->bottom_height);
cairo_region_intersect_rectangle (region, &(cairo_rectangle_int_t) {
.x = frame->child_x,
.y = frame->child_y,
.width = actual_width,
.height = actual_height
});
if (actual_width > 0 && actual_height > 0)
{
cairo_region_intersect_rectangle (region, &(cairo_rectangle_int_t) {
.x = frame->child_x,
.y = frame->child_y,
.width = actual_width,
.height = actual_height
});
}
}
return region;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment