GitLab

Client theoretically can unset / remove icon. We need to reset
origin to make sure we try to load icon from other sources.

Test application that can be used to set/unset icons:
libwnck!42

XResGetClientPid already checks for XRES_CLIENT_ID_PID_MASK and
does that correctly. We were doing direct comparition that would
fail if mask would include something else.

According to Debian Code Search only MPlayer sets this property
(together with _NET_WM_ICON).

This reverts commit f2e22abc.

Hugo Carvalho authored Oct 08, 2021 and Alberts Muktupāvels committed Oct 22, 2021

(cherry picked from commit 1e58c8e5)

#25

#23

With split build and source directories AND --disable-dependency-tracking
(like the way Yocto builds are done) there's a reproducible make
failure on my Fedora 33 build host:

| Making all in src
| make[2]: Entering directory '.../metacity/1_3.40.0-r0/build/src'
| .../metacity/1_3.40.0-r0/recipe-sysroot-native/usr/bin/glib-mkenums --template ../../metacity-3.40.0/src/core/meta-enum-types.c.in ../../metacity-3.40.0/src/core/window-private.h ../../metacity-3.40.0/src/include/meta-compositor.h  > \
| 	meta-enum-types.c.tmp && mv meta-enum-types.c.tmp core/meta-enum-types.c
| .../metacity/1_3.40.0-r0/recipe-sysroot-native/usr/bin/glib-mkenums --template ../../metacity-3.40.0/src/core/meta-enum-types.h.in ../../metacity-3.40.0/src/core/window-private.h ../../metacity-3.40.0/src/include/meta-compositor.h  > \
| 	meta-enum-types.h.tmp && mv meta-enum-types.h.tmp core/meta-enum-types.h
| mv: cannot move 'meta-enum-types.c.tmp' to 'core/meta-enum-types.c'mv: cannot move 'meta-enum-types.h.tmp' to 'core/meta-enum-types.h': No such file or directory
| : No such file or directory
| make[2]: *** [Makefile:2240: core/meta-enum-types.c] Error 1

!24

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>

#21

With this metacity will exit cleanly when hitting Ctrl + C.

To preserve existing behaviour with XSMP do not change restart
style hint to IfRunning.

#21

After commits 0b3f45bb and db37deb5 SmcInteractDone and
SmcSaveYourselfDone is only called if zenity dialog exits with 0
code.

Finish interaction also when dialog is closed by pressing Cancel
indicating that shutdown should be canceled.

#20

Before commit c656c658 override-redirect windows was not
registered with meta_display_register_x_window. This means
that Metacity was treating WM_TRANSIENT_FOR hint as invalid
if it was pointing to override-redirect window.

EWMH specification [1] says that WM_TRANSIENT_FOR property is
defined for managed windows and extends its usage for
override-redirect windows. Client should set WM_TRANSIENT_FOR
on override-redirect window if it is child/popup for another
window.

As specification does not say anyting about using
override-redirect windows as parent for managed windows and
because it causes crashes in Metacity ignore WM_TRANSIENT_FOR
if it is pointing to override-redirect window.

[1] https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm46291029654544

#18

Commit 1021494e removed too much.

#19