Commit d26d56bb authored by Kai Willadsen's avatar Kai Willadsen

filediff, meldbuffer: Clarify some existing comments

parent 64ffcc27
......@@ -767,7 +767,9 @@ class FileDiff(melddoc.MeldDoc, gnomeglade.Component):
if not self.linediffer.syncpoints:
self.linediffer.change_sequence(pane, startline, sizechange,
self.buffer_filtered)
# FIXME: diff-changed signal for the current buffer would be cleaner
# TODO: We should have a diff-changed signal for the
# current buffer instead of passing everything through
# cursor change logic.
focused_pane = self._get_focused_pane()
if focused_pane != -1:
self.on_cursor_position_changed(self.textbuffer[focused_pane],
......
......@@ -192,9 +192,10 @@ class MeldBufferData(GObject.GObject):
self._sourcefile.bind_property(
'encoding', self, 'encoding', GObject.BindingFlags.DEFAULT)
# This is aiming to maintain existing behaviour for filename. The
# behaviour is however wrong and should be fixed.
# FIXME: maintaining previous comment above; this is now wrong in different awful ways
# TODO: Figure out how we use filename, and decide on how this
# should actually work. This was previously wrong, but since
# then we've moved to Python 3 with a different filename
# encoding model, and also changed stuff to use Gio.File.
self.filename = value.get_path() if value else None
self.update_mtime()
self.connect_monitor()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment