Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
meld
meld
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 172
    • Issues 172
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 5
    • Merge Requests 5
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • meldmeld
  • Merge Requests
  • !69

Merged
Opened Jan 13, 2021 by Jack Vanier@jackrvanContributor

Add cache to findbar to remember previous search

  • Overview 4
  • Commits 3
  • Pipelines 3
  • Changes 1

This merge request is to implement issue #491 (closed). Unfortunately I could not find a way to implement this without the use of the global variable _cache. I looked into making it an instance variable but of course a new FindBar object gets created for each new FileDiff object and obviously a new FileDiff object gets instantiated each time we click a new file in the directory diff page so we would have to go even deeper before we could actually save the value and wed have to pass it all the way back up. This seems very inefficient and the way I implemented it seems to be simple and concise in my opinion.

Edited Jan 16, 2021 by Jack Vanier
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/meld!69
Source branch: issue-491

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.