1. 09 Apr, 2022 1 commit
  2. 06 Apr, 2022 1 commit
  3. 22 Mar, 2022 1 commit
  4. 12 Mar, 2022 2 commits
  5. 11 Mar, 2022 2 commits
    • Kai Willadsen's avatar
      dirdiff: Add an emblem indicator for the current marked path · 036c7ac0
      Kai Willadsen authored
      This is deliberately choosing to override the "newest" marker for two
      reasons:
       - if you're manually marking something for comparison like this, you
         probably don't actually care about whether this one or the other side
         is newest, since you're basically indicating that the file you're
         comparing to on the other side isn't the correct one; and
       - adding a new tree store column (or a third emblem location) just to
         store mark information seems like massive overkill.
      036c7ac0
    • Kai Willadsen's avatar
      dirdiff: Maintain pane order in marked comparisons · 8f371414
      Kai Willadsen authored
      If the user marks file X in the left pane and compares file Y in the
      right, the launched comparison should be the same as if they mark file
      Y in the right and compare with file X in the left; in both cases, the
      comparison should be X -> Y.
      8f371414
  6. 28 Feb, 2022 1 commit
  7. 27 Feb, 2022 2 commits
  8. 16 Feb, 2022 1 commit
  9. 12 Feb, 2022 1 commit
  10. 11 Feb, 2022 1 commit
  11. 30 Jan, 2022 2 commits
    • Kai Willadsen's avatar
      dirdiff: Re-jig comparison option usage · fb3b03b0
      Kai Willadsen authored
      The main change here is making comparison options not be an attribute,
      but rather just recreate it when doing our scan. The reason here is that
      it's nicer to not have duplicate state on the class, and it's somewhat
      better to have the action state be explicit.
      
      This change also fixes a linting error that was breaking CI.
      fb3b03b0
    • Kai Willadsen's avatar
      dirdiff: Fix lint errors and update CanonicalListing typing · ef859d8e
      Kai Willadsen authored
      This adds in some additional typing for the update CanonicalListing
      class, and also fixes some minor linting problems.
      ef859d8e
  12. 09 Jan, 2022 1 commit
    • Kai Willadsen's avatar
      dirdiff: Make new/deleted file comparison open in two-pane mode (#492) · ab0de11d
      Kai Willadsen authored
      The issue being addressed here is that once the comparison has been
      opened, there's no clear indication of whether it was the left or the
      right pane that was missing from the folder comparison.
      
      The down-side to making us always open in two-pane mode is that we lose
      the screen real estate of the single-pane view, but the benefits in
      consistency feel like they outweigh that consideration. If a user really
      wants a full-size view of an added/removed file without the screen
      split, the Open Externally action is already available.
      ab0de11d
  13. 08 Jan, 2022 5 commits
  14. 07 Jan, 2022 2 commits
  15. 02 Jan, 2022 3 commits
  16. 23 Sep, 2021 1 commit
    • Kai Willadsen's avatar
      Make filter headerbar buttons only visible in their related views · 4ac4143b
      Kai Willadsen authored
      This is a very debatable change. I'm weighing up a desire for the
      header bar to not be too wide (because it gives us a minimum size that
      we can't easily work around) with the desire to have the UI be stable.
      In this case, I've gone with having the available buttons change per
      view, on the basis that there are three text buttons here and they take
      up really quite a lot of horizontal allocation.
      
      Ideally, I think this would be responsive and we'd try to always show
      all three buttons, collapsing down to just the relevant one(s) if
      necessary... but that's really quite a lot more work.
      4ac4143b
  17. 05 Mar, 2021 2 commits
  18. 18 Feb, 2021 3 commits
  19. 16 Jan, 2021 2 commits
    • Kai Willadsen's avatar
      dirdiff: Move pane action bar to use MeldFileButton and PathLabel · 593b62c9
      Kai Willadsen authored
      The goal here is to make the folder comparisons action bar UI the same
      as the UI for file comparisons. We're also looking to fix the same kinds
      of problems that the file UI change fixes, namely: access to the full
      path, better overall display, and avoiding the deprecated
      GtkFileChooserButton.
      
      This change also moves to having a GObject property for the folders
      being compared. Currently we don't really make great use of this, but
      it gives us a starting point for migrating to a more property-driven
      model here.
      593b62c9
    • Kai Willadsen's avatar
      eac1f607
  20. 10 Jan, 2021 1 commit
  21. 06 Jan, 2021 1 commit
  22. 31 Dec, 2020 1 commit
  23. 23 Dec, 2020 2 commits
  24. 15 Oct, 2020 1 commit
    • Kai Willadsen's avatar
      dirdiff: Fix sensitivity when cancelling existing folder scans (#499) · 569691f3
      Kai Willadsen authored
      In situations where we cancel existing folder scan tasks before they're
      finished, we incorrectly didn't clear the _scan_in_progress sentinel
      variable. This could happen when e.g., toggling a file filter button
      before the current scan had completed, and disabled most of our menu
      items (because they're correctly disabled while a scan is running).
      569691f3