1. 20 Apr, 2018 3 commits
  2. 12 Apr, 2018 2 commits
  3. 07 Apr, 2018 5 commits
  4. 22 Mar, 2018 1 commit
  5. 17 Feb, 2018 2 commits
    • Kai Willadsen's avatar
      filediff: Don't reset saving state from while-closing saves · c645afe6
      Kai Willadsen authored
      The bug here looks something like:
      
       * Compare files a, b and c
       * Modify b and c
       * Close the tab; when prompted to save, save both b and c
       * Both files will be saved, but the tab won't close
      
      The problem here was that we were resetting the state to Normal when
      a save succeeded. This doesn't cause an issue if you're only saving
      one file, but if you're saving multiple then the second save to run
      *won't* be in a Closing state in its saved callback, and so won't
      try to close the tab.
      c645afe6
    • Kai Willadsen's avatar
      Make our state saving an enum, for both sanity and better debugging · c2b29ade
      Kai Willadsen authored
      This way at least we get meaningful names when debugging these state
      transitions. Also, it's better in every way.
      
      I've used an IntEnum here just so that I keep the state-changed signal
      signature, though there's no reason that needs to remain the same,
      really.
      c2b29ade
  6. 10 Feb, 2018 1 commit
    • Kai Willadsen's avatar
      undo: Take and keep track of the buffers an UndoSequence references · eb614e7f
      Kai Willadsen authored
      We're using weakrefs here because I'm paranoid about the lifecycle
      issues with GTK+ + Python refcounting fun.
      
      Starting a group now means dereferencing and re-referencing these
      buffers, which isn't great, but is probably the least-bad option. The
      other choice here would be to give groups a reference to their parent
      UndoSequence, and have the buffers lookup follow that, which seems...
      more complicated and confusing.
      eb614e7f
  7. 08 Feb, 2018 3 commits
  8. 28 Jan, 2018 1 commit
  9. 18 Jan, 2018 2 commits
  10. 02 Jan, 2018 1 commit
  11. 30 Dec, 2017 7 commits
  12. 09 Dec, 2017 4 commits
  13. 08 Dec, 2017 1 commit
  14. 25 Nov, 2017 1 commit
  15. 24 Nov, 2017 4 commits
  16. 23 Nov, 2017 1 commit
  17. 20 Nov, 2017 1 commit