1. 30 Mar, 2019 3 commits
  2. 18 Mar, 2019 1 commit
  3. 08 Mar, 2019 1 commit
  4. 28 Jan, 2019 1 commit
  5. 22 Jan, 2019 2 commits
  6. 19 Jan, 2019 2 commits
  7. 14 Jan, 2019 1 commit
  8. 10 Jan, 2019 1 commit
  9. 08 Jan, 2019 1 commit
  10. 07 Jan, 2019 2 commits
  11. 06 Jan, 2019 2 commits
  12. 05 Jan, 2019 1 commit
  13. 01 Jan, 2019 2 commits
    • Kai Willadsen's avatar
      filediff: Fix check-save workflow when given a list of buffers · 4f947506
      Kai Willadsen authored
      This isn't currently used, but it was when we were using
      check_save_modified() for drag-n-drop and file selector save checks.
      The problem was that when actually trying to save we prompted using the
      passed buffer list, but didn't refer to that list when trying to save.
      4f947506
    • Kai Willadsen's avatar
      filediff: Move users of check-save workflow to confirm-discard instead · 1c0c2985
      Kai Willadsen authored
      The benefit here is that while state in check-save is async (because we
      use the async saving of GtkSource.FileSaver), confirm-discard has no
      state and is a straight up modal confirm with no complications.
      
      The places we're now doing this is when the user changes the file
      selector, and when they drag-n-drop a new file on to the pane. In both
      cases, I think these aren't situations where the user is likely to
      actually have accidentally forgotten to save (since they're extremely
      deliberate manipulations of the current comparison), so the simple
      confirm seems like a reasonable complexity trade-off.
      1c0c2985
  14. 31 Dec, 2018 4 commits
    • Kai Willadsen's avatar
      dirdiff: Add Enter/Return as an accelerator for Compare (#262) · d47a5870
      Kai Willadsen authored
      The intention here was for this to essentially be a documentation
      change, i.e., so that users can see that the shortcut exists. In
      reality, this is a behaviour change when hitting enter on a folder row.
      
      Previously, this would expand/collapse the row because it was a treeview
      row activation signal and that seemed like a reasonable thing to do.
      This is still what will happen on actual row activation (i.e., double-
      clicking a folder row), but now hitting enter will activate the Compare
      action and will create a new folder comparison when activating a folder
      row.
      
      I don't think either of these options are obviously better than the
      other, so I'm going to go with this new behaviour for now.
      d47a5870
    • Kai Willadsen's avatar
      dirdiff: Fix menu focus issues by removing a *lot* of code · 4e46baee
      Kai Willadsen authored
      The actual reason I went to change this was that if you tried to use the
      menu bar items, the main actions (i.e., compare, copy, delete) were all
      insensitive. This happens because we unset their sensitivity on treeview
      focus loss. I suspect that the intention here was to keep consistent
      action state, but in reality we can just invoke the action based on the
      last focus pane, which is what the user expects.
      
      When doing this, I found that the focus handler block/unblock around
      popup handling was doing nothing useful, and then that the popup menu
      handling was actually slightly confused with the custom filter menu
      code, so... now it's mostly deleted.
      4e46baee
    • Kai Willadsen's avatar
    • Kai Willadsen's avatar
      filediff: Simplify save dialog creation · 34fbe8e6
      Kai Willadsen authored
      34fbe8e6
  15. 28 Nov, 2018 1 commit
  16. 22 Nov, 2018 1 commit
  17. 21 Nov, 2018 3 commits
  18. 20 Nov, 2018 2 commits
  19. 18 Nov, 2018 1 commit
  20. 15 Nov, 2018 2 commits
  21. 14 Nov, 2018 1 commit
  22. 13 Nov, 2018 1 commit
    • Kai Willadsen's avatar
      filediff: Replace broken pre-save encoding check (#239) · c91654d0
      Kai Willadsen authored
      See c7bbe78d for the removal reasoning.
      
      Here we're just giving the user a somewhat better error message. Ideally
      we'd replicate the previous offer of "hey why don't you save as UTF-8
      instead?", but the save lifecycle makes this difficult here. If this was
      an often-hit check then we'd do it, but... this code hasn't worked in
      over three years and people have only ever complained about bugs in the
      encoding check, not the save-as-UTF-8 bit.
      c91654d0
  23. 05 Nov, 2018 1 commit
  24. 02 Nov, 2018 2 commits
  25. 27 Oct, 2018 1 commit
    • Kai Willadsen's avatar
      dirdiff: Fix display of encoding errors when scanning folders (#235) · 924ac31d
      Kai Willadsen authored
      The existing handling was Python 2 era. In the current code, we'll
      always have a `str`-type root for our `os.listdir()` call, so the
      entries will always be `str`s. This patch handles the Python 3 path
      handling situation of getting surrogate escaped paths (in the case of a
      bad file name vs. filesystem encoding) by just checking for a valid
      re-encode and treating any failure as an encoding error.
      924ac31d