From d4f351bf5b66e1df776fd76460d6455897832b91 Mon Sep 17 00:00:00 2001 From: Sophie Herold Date: Thu, 27 Apr 2023 15:56:43 +0200 Subject: [PATCH 1/2] propertiesView: Activatable rows not selectable Inputs get to mixed up if the subtitle in rows that are activatable are also selectable. Part-of: --- data/gtk/properties_view.ui | 2 -- 1 file changed, 2 deletions(-) diff --git a/data/gtk/properties_view.ui b/data/gtk/properties_view.ui index f9d83ac6..e18f6b1a 100644 --- a/data/gtk/properties_view.ui +++ b/data/gtk/properties_view.ui @@ -27,7 +27,6 @@ Folder - True folder_button @@ -142,7 +141,6 @@ Location - True location_button -- GitLab From bea6ad018be849643c75435762061ec0a94a1348 Mon Sep 17 00:00:00 2001 From: Sophie Herold Date: Thu, 27 Apr 2023 16:00:35 +0200 Subject: [PATCH 2/2] propertiesView: Disable open folder for non-native The GTK API only support native files for opening the parent directory. Part-of: --- src/widgets/properties_view.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/widgets/properties_view.rs b/src/widgets/properties_view.rs index 1b98abfe..2e0d03b5 100644 --- a/src/widgets/properties_view.rs +++ b/src/widgets/properties_view.rs @@ -150,7 +150,10 @@ impl LpPropertiesView { fn set_file(&self, file: Option<&gio::File>) { let imp = self.imp(); - self.action_set_enabled("properties.open-folder", file.is_some()); + self.action_set_enabled( + "properties.open-folder", + file.map_or(false, |x| x.is_native()), + ); if let Some(file) = file { if let Some(current_file) = self.file() { -- GitLab