Skip to content

fix: pthread weak references in globals.c

Mike Dalessio requested to merge flavorjones/libxml2:flavorjones-globals-weakref into master

Linking executables will fail on systems with glibc < 2.34 without declaring these symbols as weak references.

$ ./configure --enable-static --disable-shared
...

$ make xmllint
...
/usr/bin/ld: ./.libs/libxml2.a(libxml2_la-globals.o): undefined reference to symbol 'pthread_key_delete@@GLIBC_2.2.5'
/usr/bin/ld: /lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

In commit c19771c1 these references were moved to globals.c from threads.c, but the #pragma weak declarations were lost in the process.

Edited by Mike Dalessio

Merge request reports