Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • L libsecret
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • libsecret
  • Merge requests
  • !94

Create default collection after DBus.Error.UnknownObject

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Slava requested to merge ptrNine/libsecret:fork into master Aug 17, 2021
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

Some Secret Service API backend implementations (like keepassxc) throws UnknownObject (instead of UnknownMethod as gnome-keyring do) after creating an item in the non-existent /org/freedesktop/secrets/aliases/default.

This patch add handling of UnknownObject to create default collection after failed creation of an item.

Example of DBus errors with SearchItems (in this case it throws the same errors as CreateItem):

gnome-keyring:

gdbus call --session --dest org.freedesktop.secrets --object-path /org/freedesktop/secrets/aliases/default --method org.freedesktop.Secret.Collection.SearchItems '{}'
Error: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.Secret.Collection” on object at path /org/freedesktop/secrets/collection/keyring

keepassxc:

gdbus call --session --dest org.freedesktop.secrets --object-path /org/freedesktop/secrets/aliases/default --method org.freedesktop.Secret.Collection.SearchItems '{}'
Error: GDBus.Error:org.freedesktop.DBus.Error.UnknownObject: No such object path '/org/freedesktop/secrets/aliases/default'
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fork