Dereferencing a NULL pointer
Submitted by mah..@..ng.com
Assigned to libsecret maintainer(s)
Link to original bug (#757584)
Description
Created attachment 314810 patch file
NULL check is missing on pointer before dereferencing it. In file secret-collection.c, Variable 'search->paths' is dereferenced at line no 1374, without NULL check. Value is being assigned to 'search->paths' at line no 1368 using secret_collection_search_for_dbus_paths_finish(). As per definition of secret_collection_search_for_dbus_paths_finish(), it may return NULL pointer. So NULL check must apply on value return by function secret_collection_search_for_dbus_paths_finish(), before dereferencing it.
Code Before modification: search->paths = secret_collection_search_for_dbus_paths_finish (self, result, &error); if (error == NULL) { want = 1; if (search->flags & SECRET_SEARCH_ALL) want = G_MAXINT; for (i = 0; i < want && search->paths[i] != NULL; i++) {
Code After modification: search->paths = secret_collection_search_for_dbus_paths_finish (self, result, &error); if (error == NULL) { want = 1; if (search->flags & SECRET_SEARCH_ALL) want = G_MAXINT; for (i = 0; i < want && search->paths != NULL && search->paths[i] != NULL; i++) {
Patch 314810, "patch file":
secret-collection-001.patch
Version: 0.18.x