Audit filters for operations that can overflow
For example, convolve_matrix.rs
has this:
// order: Cell<(u32, u32)>
let number_of_elements = self.order.get().0 as usize * self.order.get().1 as usize;
This works fine on 64-bit, since the u32
are converted to usize
for the operation. But on 32-bit, it will overflow. We need to do those as checked_mul()
.