Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
L
librsvg
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 157
    • Issues 157
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • librsvg
  • Issues
  • #250

Closed
Open
Opened Apr 27, 2018 by Federico Mena Quintero@federico
  • Report abuse
  • New issue
Report abuse New issue

Compute "sub" positions/dimensions correctly

In my branch https://gitlab.gnome.org/federico/librsvg/tree/wilber-dimensions I did this:

  • Enabled the /dimensions/sub/rect with transform test again.
  • Disabled the code in draw.rs that reduces Cairo's tolerance. This makes that test pass again (... for the first time in 8 years).
  • Added @Jehan's test for fetching the dimensions of a Wilber icon.

This last test fails; we are not computing the icon's position/dimensions correctly. I think this is because the icon is a <g> with a transform, but I'm not 100% sure yet.

I'd like to make this a meta-bug for #128 (closed) and #134 (closed) as well.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
No due date
5
Labels
1. Bug 2. Failing test 2. Needs Diagnosis 3. Expected Behavior needs API
Assign labels
  • View project labels
Reference: GNOME/librsvg#250