Skip to content

Port lighting filters, feTile; fix filter transformations and kernelUnitLength handling; fix feTurbulence performance; remove filter FFI code

Ivan Molodetskikh requested to merge YaLTeR/librsvg:filters-to-rust-9 into master
  • Ported lighting filters and feTile, thus getting rid of the last filters in C! 🎉 🎉 🎉
  • Removed a ton of filter FFI boilerplate, including resolving #195 (closed).
  • Also removed RsvgCNodeImpl and related stuff since it's no longer used by anything.
  • Fixed some incorrect filter transformations.
  • Fixed SharedImageSurface::scale() and kernelUnitLength handling.
  • Fixed feTurbulence performance (I was sure Rust is smart enough to change by-value Copy arguments to by-reference where appropriate, but that's not the case).
  • Fixed BackgroundImage.

This also means we now have all but one filter-related tests from the test suite (the one left over being offset-02 which is affected by #1), thus resolving #251 (closed).

Edited by Ivan Molodetskikh

Merge request reports