Skip to content

tests: Log and save a diff if max_diff exceeds x86_64 tolerance

Simon McVittie requested to merge smcv/librsvg:save-all-diffs into master

This gives us a way to assess whether the diff is a real problem, without breaking builds.

Signed-off-by: Simon McVittie smcv@debian.org

This version conflicts with !140 (merged), but either is easy to rebase on the other if both are accepted. The version I'm going to use in Debian requires !140 (merged).

This use of g_test_incomplete() will fail tests on the affected architectures when built with GLib 2.57.3 or later, because it relies on glib#1474 (closed) having been fixed (glib!221 (closed)). If this is unacceptable, I could add a wrapper that uses g_test_incomplete() on newer GLib versions and g_test_skip() on older versions, or use g_test_skip() unconditionally.

Merge request reports