GitLab

Add several missing annotations

See merge request !3

Most of them are taken from the Vala overrides: https://gitlab.gnome.org/GNOME/vala/-/blob/master/vapi/metadata/Rest-0.7.metadata

Calling rest_xml_parser_parse_from_data() with an empty string ("")
currently causes a crash as xmlReaderForMemory() returns NULL in that
case, and we then try to dereference this pointer without checking it's
non-NULL.

https://bugzilla.gnome.org/show_bug.cgi?id=789053

This is already done in finish_call and the g_strdup to
priv->status_message was leaking the previously set one.

So they end up being available in the generated html documentation.

Before this, it was impossible to get the server payload from a proxy
call invoked via rest_proxy_call_upload.

This reverts commit 2d1dbfe7

https://bugzilla.gnome.org/show_bug.cgi?id=788960

The order in which GHashTable returns its key-value pairs is undefined.
Therefore the output of rest_xml_node_print can change based on the
GHashTable implementation. While not strictly necessary, it would be
nice to avoid that. Having a stable order, even if it is not
documented and depends on the current RestXmlNode code, is handy for
testing.

This was the main reason behind the tests/xml.c breakage.

https://bugzilla.gnome.org/show_bug.cgi?id=788960

The rest_xml_node_add_child API explicitly documents NULL parents as
the way to create top-level nodes. This had broken the second half of
tests/xml.c.

Fallout from b11a1664

https://bugzilla.gnome.org/show_bug.cgi?id=788960

This had broken tests/xml.c.

Fallout from 61a7b231

https://bugzilla.gnome.org/show_bug.cgi?id=788960

https://bugzilla.gnome.org/show_bug.cgi?id=785818

https://bugzilla.gnome.org/show_bug.cgi?id=785818

https://bugzilla.gnome.org/show_bug.cgi?id=785811

https://bugzilla.gnome.org/show_bug.cgi?id=785811

https://bugzilla.gnome.org/show_bug.cgi?id=785811

https://bugzilla.gnome.org/show_bug.cgi?id=785811

https://bugzilla.gnome.org/show_bug.cgi?id=785811

Bump minimum GLib version to 2.44.0.

https://bugzilla.gnome.org/show_bug.cgi?id=785811

Use assert macros instead of error counting and drop deprecated libsoup
API

Currently rest_proxy_call_sync (and everything else using
prepare_message) might return FALSE without setting @error at all. Add
two new error codes to indicate the possible problems and reliably
set the error if something went wrong.

It has been deprecated for a long while, and we were only using it for
proxy support. However, now that we switched to using SoupSession rather
than SoupSession{Sync,Async}, a default proxy resolver will be used, so
we don't need to set it explicitly.

We switched to using SoupSession directly, but it's only possible since
libsoup 2.42

This fixes:

==16342== 93 (64 direct, 29 indirect) bytes in 1 blocks are definitely lost in loss record 211 of 278
==16342==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342==    by 0x5F5CE58: g_malloc (gmem.c:94)
==16342==    by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342==    by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342==    by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342==    by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342==    by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342==    by 0x4009E6: test_url_fragment_no_access_token (oauth2.c:36)
==16342==    by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342==    by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342==    by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342==    by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342==    by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342==    by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 133 (64 direct, 69 indirect) bytes in 1 blocks are definitely lost in loss record 262 of 278
==16342==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342==    by 0x5F5CE58: g_malloc (gmem.c:94)
==16342==    by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342==    by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342==    by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342==    by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342==    by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342==    by 0x400A25: test_access_token_simple (oauth2.c:44)
==16342==    by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342==    by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342==    by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342==    by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342==    by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342==    by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 137 (64 direct, 73 indirect) bytes in 1 blocks are definitely lost in loss record 263 of 278
==16342==    at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342==    by 0x5F5CE58: g_malloc (gmem.c:94)
==16342==    by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342==    by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342==    by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342==    by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342==    by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342==    by 0x400A97: test_url_encoding_access_token (oauth2.c:51)
==16342==    by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342==    by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342==    by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342==    by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342==    by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342==    by 0x400B64: main (oauth2.c:65)