notify-send cuts off icon path from first comma
The icon path which can be specified via the -i command line flag for notify send is actively cut off from the first ','-character (comma) and is discarded.
This is done actively by notify-send in tools/notify-send:214 and following https://git.gnome.org/browse/libnotify/tree/tools/notify-send.c?id=f9355ca35#n214
I see no reason why this should be done so I propose dropping the cropping code via the attached patch. You can apply the patch via git-am.
From 5aabadc651c4b3225241c44bd6150c1f51737e83 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thorsten=20Wi=C3=9Fmann?= <edu@thorsten-wissmann.de>
Date: Fri, 17 Jan 2014 15:21:57 +0100
Subject: [PATCH] Do not cut off icon path from first comma
notify-send did cut off everything from the first comma in a icon path
supplied via the -i command line flag. There is no reason to do that, so
do not cut off anymore.
---
tools/notify-send.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tools/notify-send.c b/tools/notify-send.c
index c0b9eeb..9dccf95 100644
--- a/tools/notify-send.c
+++ b/tools/notify-send.c
@@ -211,12 +211,6 @@ main (int argc, char *argv[])
}
if (icons != NULL) {
- char *c;
-
- /* XXX */
- if ((c = strchr (icons, ',')) != NULL)
- *c = '\0';
-
icon_str = icons;
}
--
1.8.5.2
I have migrated this issue from the old bugzilla where I have reported this on 2014-01-17. Nearly seven years later, I still see no reason for cutting of everything after ,
(the help message says something about specifying several icons, but apparently, it is still not used at all)