GitLab

Update NEWS.

Closes #25

See merge request !26

Starting with d0778595, we access the Notification object after the
NotifyActionCallback; some clients (eg, Electron) have historically
unref'd the object at the end of the NotifyActionCallback. They probably
should not have been doing so, but this hotfix adds an additional ref
before and after the callback so that we don't break existing code.

Fixes #25

Per:
- Discussions on #release-team
- No response to email to mccann in over 10 days
- Email response from chammond confirming he should no longer be listed
  as maintainer

See also: afef1e98
Closes: #14

As discussed on #release-team:

  21:12:18 <ebassi> Trevinho: You could already add yourself to the DOAP file

Delete unused notifynotification.xml

See merge request !25

It's used by various daemons including GNOME Shell to figure out the
parent application.

In case a transient notification is requested but persistence is not
supported, it's not an error but it is useful to show a debug message
to clarify that.

Update NEWS.

Boolean hints are used for some common parameters such as "transient".

Original bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636343

It's not supported by GLib 2.26.0, the minimum version we required

Update NEWS.

Notification actions can now be activated with an activation token
containing platform data. So update the notification-spec to include
latest version of the specification, and expose the activation token
during an action activation.

Not to change the API, by modifying the type of NotifyActionCallback
it's just better to provide a function to fetch the activation token
during activation only, so that this can be retro-compatible.

Reference: https://gitlab.freedesktop.org/xdg/xdg-specs/-/commit/b9a4700

We're using error variable multiple times, and this may lead to problems
when trying to set it again. So let's just clear once it's used.

Ben Blain authored Mar 11, 2021 and Marco Trevisan committed Apr 25, 2022

The activated action name is written to stdout and the notification is closed
when a valid action has been selected.

Ben Blain authored Mar 02, 2021 and Marco Trevisan committed Apr 25, 2022

If an expiration timeout is set, the notification is not waited longer
than such time.

Paul Collins authored May 22, 2012 and Marco Trevisan committed Apr 25, 2022

Support printing and overriding notification ID, so that it's possible
to replace a notification that is currently showing with an updated
content.

Based on patch as provided by Paul Collins in the following bug
report:
  https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/257135/comments/8

Co-authored-by: Marco Trevisan (Treviño) <mail@3v1n0.net>

Fixes #19

Snaps use desktop IDs based on the snap name and the application name
inside the snap, so if we're in a such container, we need to compute the
desktop-entry using those values. We can figure them out from the snap
cgroup they're in.

In such case, don't even try to use the GApplication ID as that is
likely wrong in a snapped environment.

We may need to use them in various places, so there's no point to repeat
the same in multiple places, this way we can also use some shortcuts for
non-snap setups.

We used to just add it again, to eventually figure out that the file
did not exists, but may not work properly in some scenarios.

Also always fill the path_filename when using a file-name only, as that
may be refer to something under the SNAP path, and in such case we want
to try check if that exists before giving up.

It's not really an issue here, as we use a properly typed len, but
better not to use a deprecated and potentially dangerous API.

In future meson will check the run_command result by default, while it's
fine for us, it would cause our nicer error message not to work.