1. 08 Nov, 2019 1 commit
  2. 04 Nov, 2019 3 commits
  3. 21 Oct, 2019 1 commit
  4. 19 Oct, 2019 1 commit
  5. 18 Oct, 2019 5 commits
  6. 17 Oct, 2019 2 commits
  7. 10 Oct, 2019 3 commits
  8. 09 Oct, 2019 9 commits
  9. 04 Oct, 2019 3 commits
  10. 03 Oct, 2019 3 commits
    • Beniamino Galvani's avatar
      900796e4
    • Beniamino Galvani's avatar
      libnma: focus first empty field in the VPN dialog · f70c827e
      Beniamino Galvani authored
      Previously the secondary field would be focused even if the first was
      empty.
      f70c827e
    • Beniamino Galvani's avatar
      applet/vpn-request: fix external UI mode · dee77447
      Beniamino Galvani authored
      When a connection is opened for editing in nm-c-e, secrets are asked
      to NM. NM in turn asks them to registered agents, including the applet
      if available; the applet now supports an external-ui-mode in which it
      spawns a VPN-specific authentication dialog binary that doesn't have a
      graphical component and contains the knowledge about which secrets are
      missing, how to retrieve them from keyrings and how to ask them to
      users; the binary then returns through stdout a keyfile that describes
      the known secrets, their values returned from keyrings and the labels
      to present to users. The applet uses this information to show a GTK
      dialog (only when necessary) and returns the secrets to NM.
      
      Currently when using the external-ui-mode and the auth-dialog binary
      returns secrets with the ShouldAsk key set to false, the applet
      doesn't show a GTK dialog and returns an empty response. This breaks
      when the auth-dialog returns secrets from keyrings as they are
      dropped.
      
      This commit changes the handling of secrets in external-ui-mode: now
      we first build a list of known secrets and, if necessary, populate the
      dialog with the ones that must be asked. After the dialog quits we
      update the secret values in the list from the dialog and return all
      secrets, including ones not asked.
      
      #59
      https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/193
      
      Fixes: bce8d0a7 ("applet/vpn-request: add external UI mode")
      dee77447
  11. 27 Sep, 2019 5 commits
  12. 23 Sep, 2019 1 commit
  13. 20 Sep, 2019 3 commits