Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
L
libgtop
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 37
    • Issues 37
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • libgtop
  • Merge Requests
  • !1

Open
Opened Mar 20, 2018 by Karuna Grewal@antares 1
  • Report abuse
Report abuse

WIP: Add Network Stats in Libgtop

This branch adds the network stats feature as requested in #34

I've considered changing the code according to the previous discussions .

The previous discussions can be checked here.

In case there is any previous comment which I haven't addressed or sth else needs to be changed pls let me know

Edited Mar 20, 2018 by Karuna Grewal
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.gnome.org/antares/libgtop.git wip/antares/jhbuild_modif
git checkout -b antares/libgtop-wip/antares/jhbuild_modif FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff antares/libgtop-wip/antares/jhbuild_modif

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 76
  • Commits 92
  • Changes 34
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Karuna Grewal @antares

    added 8 commits

    • 5625f6f2...cab8791f - 7 commits from branch GNOME:master
    • b2e590a4 - Fix merge conflict in jhbuild_modif branch

    Compare with previous version

    Mar 20, 2018

    added 8 commits

    • 5625f6f2...cab8791f - 7 commits from branch GNOME:master
    • b2e590a4 - Fix merge conflict in jhbuild_modif branch

    Compare with previous version

    added 8 commits <ul><li>5625f6f2...cab8791f - 7 commits from branch <code>GNOME:master</code></li><li>b2e590a4 - Fix merge conflict in jhbuild_modif branch</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4412&start_sha=5625f6f207323128a55fe34649153edd2b4b5804)
    Toggle commit list
  • Karuna Grewal @antares

    changed the description

    Mar 20, 2018

    changed the description

    changed the description
    Toggle commit list
  • Karuna Grewal @antares

    mentioned in merge request gnome-usage!34

    Mar 20, 2018

    mentioned in merge request gnome-usage!34

    mentioned in merge request gnome-usage!34
    Toggle commit list
  • Karuna Grewal @antares

    added 78 commits

    • 8bd537f6 - Add directory traversal of /proc
    • a9cad964 - Add file parsing for /proc/net/tcp
    • 193190f9 - Add parsing of network connections from /proc/net/ files
    • 27add439 - Add test for netsocket.c
    • 0482134a - Add hashTable to store inode and pid
    • 53394f32 - Add test for proc_inode_parse.c
    • d6963d4f - Add glib version of dir traversal
    • 295119c3 - dev_handles : Open pcap handles for network interfaces
    • 72f85edc - Test for checking the opened pcap handles for network devices
    • f8a584ec - Change the dir name approach to GFile
    • 053936c4 - GFile changes in the args
    • 0c311572 - Add GError for error handling
    • 016c3746 - Switched to GINT_TO_POINTER
    • 670736c1 - Replace malloc with g_slice_new
    • fffd2464 - Minor changes in test file
    • aba855b2 - Fix warning
    • 5be88740 - coding style fixes
    • 1e57f5ba - Add Interface's local address
    • 99959fa3 - Add local address to interfaces
    • ba33364f - Add functions for manipulating packets
    • 6a85c65f - Add connections details to keep track of relevant packets
    • 4a5b9bc2 - Add process details to track corresponding connections
    • 0b5560fc - Add callback for tcp
    • ea04658b - Add more packet functions
    • 5b95d02b - Add hash table for socket details and inode
    • 9aa44716 - Add packet processing functions
    • 515b4a59 - Modifications in packet function prototypes
    • a2a6f67c - Fix struct member name issues
    • 24c67dd9 - Add structs for network stats output
    • 5b1cfa22 - Add main testing file
    • c3e87809 - Redefinition issues fixed
    • d90c5516 - Add packet hash to packet struct
    • bda2f65b - dev_handles.c : Modify packet processing functions
    • f739c742 - dev_handles.h: Add definition of packet headers
    • 215e0874 - connection: Modify the connection matching functions
    • 55478d8a - This commit has to be broken down into patches
    • bfecdbbe - Separate the headers and tests
    • 99937f69 - add missing files to Makefile
    • 5d66652a - Add Gio dependency
    • 97188a52 - Add Symbols to MakeFile
    • d47b8dfa - Add LIBGTOP prefix to header guards
    • 632e5de0 - Change Process_list to GSList
    • 399bc42e - Change Conn_list to GSList
    • a0d8a145 - Replace u_int data types by their GLib alternatives
    • 56932f95 - Change Packet_list to GSList
    • 01b8aa02 - Add new headers to the list of introspectables
    • 8b234c41 - Change the network_stats_entry struct
    • 015a0850 - Add network stats cmd to the daemon
    • 01a9a738 - Change flags to enable Daemon for Linux
    • 9eb6cf9b - Define the libgtop_sysdeps_suid library for Linux
    • 7d763cd1 - Add glibtop_init_p in Linux
    • 196a1482 - Change the local_addr field in struct glibtop_socket
    • 33338076 - Add glibtop_open_p function
    • f9378661 - Remove the error logs
    • c34bf34c - Add DBus Interface to get the stats
    • be0bc1c6 - Change the output GVariant
    • 47c2da9d - Add capture status function
    • d169d3df - Add capture initializer function to DBus
    • 0b892b00 - Change Daemon settings for Linux
    • 518fd81b - Move the DBus example to examples dir
    • 4d72a46c - Add packet capture init function to stats
    • fcbfca91 - Add GPtrArray for the dbus_stats
    • 7e017fb2 - Add parameter in the get_stats_instance invocation
    • c401e91e - Change the condition for keeping the capture active
    • f7a9f290 - Rename the toggle_capture_status function
    • 91b27483 - WIP: Add the dictionary for DBus Messages
    • 05e01a13 - Remove proc_name from various structs
    • bdcf3abc - Fix the issue in dictionary in GVariants
    • 07bb0648 - Add g_timeout_add in the dbus interface
    • 2cdddea6 - Fix timeout issue in DBus interface
    • 738086d0 - Add check to stop the packet capture
    • 38cee26a - Fix segfault in GetStats
    • 502a95a0 - Add config files for DBus
    • d6d5e201 - Add set and reset functions to dbus-interface
    • f1f229c8 - Discard values ~0.00 in the network stats
    • e9bdd8ac - Activate the packet capture in the network test example
    • bc3a0250 - Use g_error wherever required
    • 050ba450 - Fix warnings during compilation

    Compare with previous version

    Mar 20, 2018

    added 78 commits

    • 8bd537f6 - Add directory traversal of /proc
    • a9cad964 - Add file parsing for /proc/net/tcp
    • 193190f9 - Add parsing of network connections from /proc/net/ files
    • 27add439 - Add test for netsocket.c
    • 0482134a - Add hashTable to store inode and pid
    • 53394f32 - Add test for proc_inode_parse.c
    • d6963d4f - Add glib version of dir traversal
    • 295119c3 - dev_handles : Open pcap handles for network interfaces
    • 72f85edc - Test for checking the opened pcap handles for network devices
    • f8a584ec - Change the dir name approach to GFile
    • 053936c4 - GFile changes in the args
    • 0c311572 - Add GError for error handling
    • 016c3746 - Switched to GINT_TO_POINTER
    • 670736c1 - Replace malloc with g_slice_new
    • fffd2464 - Minor changes in test file
    • aba855b2 - Fix warning
    • 5be88740 - coding style fixes
    • 1e57f5ba - Add Interface's local address
    • 99959fa3 - Add local address to interfaces
    • ba33364f - Add functions for manipulating packets
    • 6a85c65f - Add connections details to keep track of relevant packets
    • 4a5b9bc2 - Add process details to track corresponding connections
    • 0b5560fc - Add callback for tcp
    • ea04658b - Add more packet functions
    • 5b95d02b - Add hash table for socket details and inode
    • 9aa44716 - Add packet processing functions
    • 515b4a59 - Modifications in packet function prototypes
    • a2a6f67c - Fix struct member name issues
    • 24c67dd9 - Add structs for network stats output
    • 5b1cfa22 - Add main testing file
    • c3e87809 - Redefinition issues fixed
    • d90c5516 - Add packet hash to packet struct
    • bda2f65b - dev_handles.c : Modify packet processing functions
    • f739c742 - dev_handles.h: Add definition of packet headers
    • 215e0874 - connection: Modify the connection matching functions
    • 55478d8a - This commit has to be broken down into patches
    • bfecdbbe - Separate the headers and tests
    • 99937f69 - add missing files to Makefile
    • 5d66652a - Add Gio dependency
    • 97188a52 - Add Symbols to MakeFile
    • d47b8dfa - Add LIBGTOP prefix to header guards
    • 632e5de0 - Change Process_list to GSList
    • 399bc42e - Change Conn_list to GSList
    • a0d8a145 - Replace u_int data types by their GLib alternatives
    • 56932f95 - Change Packet_list to GSList
    • 01b8aa02 - Add new headers to the list of introspectables
    • 8b234c41 - Change the network_stats_entry struct
    • 015a0850 - Add network stats cmd to the daemon
    • 01a9a738 - Change flags to enable Daemon for Linux
    • 9eb6cf9b - Define the libgtop_sysdeps_suid library for Linux
    • 7d763cd1 - Add glibtop_init_p in Linux
    • 196a1482 - Change the local_addr field in struct glibtop_socket
    • 33338076 - Add glibtop_open_p function
    • f9378661 - Remove the error logs
    • c34bf34c - Add DBus Interface to get the stats
    • be0bc1c6 - Change the output GVariant
    • 47c2da9d - Add capture status function
    • d169d3df - Add capture initializer function to DBus
    • 0b892b00 - Change Daemon settings for Linux
    • 518fd81b - Move the DBus example to examples dir
    • 4d72a46c - Add packet capture init function to stats
    • fcbfca91 - Add GPtrArray for the dbus_stats
    • 7e017fb2 - Add parameter in the get_stats_instance invocation
    • c401e91e - Change the condition for keeping the capture active
    • f7a9f290 - Rename the toggle_capture_status function
    • 91b27483 - WIP: Add the dictionary for DBus Messages
    • 05e01a13 - Remove proc_name from various structs
    • bdcf3abc - Fix the issue in dictionary in GVariants
    • 07bb0648 - Add g_timeout_add in the dbus interface
    • 2cdddea6 - Fix timeout issue in DBus interface
    • 738086d0 - Add check to stop the packet capture
    • 38cee26a - Fix segfault in GetStats
    • 502a95a0 - Add config files for DBus
    • d6d5e201 - Add set and reset functions to dbus-interface
    • f1f229c8 - Discard values ~0.00 in the network stats
    • e9bdd8ac - Activate the packet capture in the network test example
    • bc3a0250 - Use g_error wherever required
    • 050ba450 - Fix warnings during compilation

    Compare with previous version

    added 78 commits <ul><li>8bd537f6 - Add directory traversal of /proc</li><li>a9cad964 - Add file parsing for /proc/net/tcp</li><li>193190f9 - Add parsing of network connections from /proc/net/ files</li><li>27add439 - Add test for netsocket.c</li><li>0482134a - Add hashTable to store inode and pid</li><li>53394f32 - Add test for proc_inode_parse.c</li><li>d6963d4f - Add glib version of dir traversal</li><li>295119c3 - dev_handles : Open pcap handles for network interfaces</li><li>72f85edc - Test for checking the opened pcap handles for network devices</li><li>f8a584ec - Change the dir name approach to GFile</li><li>053936c4 - GFile changes in the args</li><li>0c311572 - Add GError for error handling</li><li>016c3746 - Switched to GINT_TO_POINTER</li><li>670736c1 - Replace malloc with g_slice_new</li><li>fffd2464 - Minor changes in test file</li><li>aba855b2 - Fix warning</li><li>5be88740 - coding style fixes</li><li>1e57f5ba - Add Interface&#39;s local address</li><li>99959fa3 - Add local address to interfaces</li><li>ba33364f - Add functions for manipulating packets</li><li>6a85c65f - Add connections details to keep track of relevant packets</li><li>4a5b9bc2 - Add process details to track corresponding connections</li><li>0b5560fc - Add callback for tcp</li><li>ea04658b - Add more packet functions</li><li>5b95d02b - Add hash table for socket details and inode</li><li>9aa44716 - Add packet processing functions</li><li>515b4a59 - Modifications in packet function prototypes</li><li>a2a6f67c - Fix struct member name issues</li><li>24c67dd9 - Add structs for network stats output</li><li>5b1cfa22 - Add main testing file</li><li>c3e87809 - Redefinition issues fixed</li><li>d90c5516 - Add packet hash to packet struct</li><li>bda2f65b - dev_handles.c : Modify packet processing functions</li><li>f739c742 - dev_handles.h: Add definition of packet headers</li><li>215e0874 - connection: Modify the connection matching functions</li><li>55478d8a - This commit has to be broken down into patches</li><li>bfecdbbe - Separate the headers and tests</li><li>99937f69 - add missing files to Makefile</li><li>5d66652a - Add Gio dependency</li><li>97188a52 - Add Symbols to MakeFile</li><li>d47b8dfa - Add LIBGTOP prefix to header guards</li><li>632e5de0 - Change Process_list to GSList</li><li>399bc42e - Change Conn_list to GSList</li><li>a0d8a145 - Replace u_int data types by their GLib alternatives</li><li>56932f95 - Change Packet_list to GSList</li><li>01b8aa02 - Add new headers to the list of introspectables</li><li>8b234c41 - Change the network_stats_entry struct</li><li>015a0850 - Add network stats cmd to the daemon</li><li>01a9a738 - Change flags to enable Daemon for Linux</li><li>9eb6cf9b - Define the libgtop_sysdeps_suid library for Linux</li><li>7d763cd1 - Add glibtop_init_p in Linux</li><li>196a1482 - Change the local_addr field in struct glibtop_socket</li><li>33338076 - Add glibtop_open_p function</li><li>f9378661 - Remove the error logs</li><li>c34bf34c - Add DBus Interface to get the stats</li><li>be0bc1c6 - Change the output GVariant</li><li>47c2da9d - Add capture status function</li><li>d169d3df - Add capture initializer function to DBus</li><li>0b892b00 - Change Daemon settings for Linux</li><li>518fd81b - Move the DBus example to examples dir</li><li>4d72a46c - Add packet capture init function to stats</li><li>fcbfca91 - Add GPtrArray for the dbus_stats</li><li>7e017fb2 - Add parameter in the get_stats_instance invocation</li><li>c401e91e - Change the condition for keeping the capture active</li><li>f7a9f290 - Rename the toggle_capture_status function</li><li>91b27483 - WIP: Add the dictionary for DBus Messages</li><li>05e01a13 - Remove proc_name from various structs</li><li>bdcf3abc - Fix the issue in dictionary in GVariants</li><li>07bb0648 - Add g_timeout_add in the dbus interface</li><li>2cdddea6 - Fix timeout issue in DBus interface</li><li>738086d0 - Add check to stop the packet capture</li><li>38cee26a - Fix segfault in GetStats</li><li>502a95a0 - Add config files for DBus</li><li>d6d5e201 - Add set and reset functions to dbus-interface</li><li>f1f229c8 - Discard values ~0.00 in the network stats</li><li>e9bdd8ac - Activate the packet capture in the network test example</li><li>bc3a0250 - Use g_error wherever required</li><li>050ba450 - Fix warnings during compilation</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4415&start_sha=b2e590a4039814120f251f79a795723aac03fcfb)
    Toggle commit list
  • Robert Roth
    @robertroth started a discussion on the diff Mar 20, 2018
    Resolved by Robert Roth Mar 21, 2018
    configure.ac
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      I feel that pcap is missing here from the list of modules to check for, the PCAP_REQUIRED variable is not used.

      I feel that pcap is missing here from the list of modules to check for, the PCAP_REQUIRED variable is not used.
    • Karuna Grewal @antares commented Mar 20, 2018
      1

      I added this in the recent commit ,is this fine ?

      also for pcap we need to use pcap-config as opposed to pkg-config

      I added [this](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs#87db583be5c13c1f7b3c958b10e03d67b6a2ca06_98_100) in the recent commit ,is this fine ? also for pcap we need to use `pcap-config` as opposed to pkg-config
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Ok, I missed the PCAP_CONFIG part. It's fine this way, marking as resolved.

      Ok, I missed the PCAP_CONFIG part. It's fine this way, marking as resolved.
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 20, 2018
    lib/sysdeps.c
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      I'm sure these conflict markers do not belong here.

      I'm sure these conflict markers do not belong here.
    • Karuna Grewal @antares

      changed this line in version 4 of the diff

      Mar 20, 2018

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4418&start_sha=050ba4506355bbb15fa196ad8acd4e46e3f425c5#aefd0d8319271594f1b58b58b8f8a3395b879665_130_130)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 20, 2018
    lib/sysdeps.c
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      I'm sure these conflict markers do not belong here.

      I'm sure these conflict markers do not belong here.
    • Karuna Grewal @antares

      changed this line in version 4 of the diff

      Mar 20, 2018

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4418&start_sha=050ba4506355bbb15fa196ad8acd4e46e3f425c5#aefd0d8319271594f1b58b58b8f8a3395b879665_133_132)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 20, 2018
    lib/sysdeps.c
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      I'm sure these conflict markers do not belong here.

      I'm sure these conflict markers do not belong here.
    • Karuna Grewal @antares

      changed this line in version 4 of the diff

      Mar 20, 2018

      changed this line in version 4 of the diff

      changed this line in [version 4 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4418&start_sha=050ba4506355bbb15fa196ad8acd4e46e3f425c5#aefd0d8319271594f1b58b58b8f8a3395b879665_136_134)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on the diff Mar 20, 2018
    dbus_config/org.gnome.GTop.NetStats.service 0 → 100644
    1 [D-BUS Service]
    2 Name=org.gnome.GTop.NetStats
    3 Exec=~/.cache/jhbuild/build/libgtop/examples/dbus_interface
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      This harcoded path is surely not correct, but no idea yet what to use here, we'll probably need to generate this dbus service file using autotools to include the real path based on the prefix autotools was configured with.

      This harcoded path is surely not correct, but no idea yet what to use here, we'll probably need to generate this dbus service file using autotools to include the real path based on the prefix autotools was configured with.
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on the diff Mar 20, 2018
    examples/Makefile.am
    11 11
    12 12 noinst_PROGRAMS = first second pprint procargs df netlist \
    13 13 mountlist procmap netload sysdeps timings \
    14 openfiles smp proclist free wd affinity diskio
    14 openfiles smp proclist free wd affinity diskio devtest dbus_interface
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      We will surely need the dbus_interface installed, so let's move it to somewhere else. Probably not inside examples but rather inside the daemon directory.

      We will surely need the dbus_interface installed, so let's move it to somewhere else. Probably not inside examples but rather inside the daemon directory.
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Robert Roth Mar 30, 2018
    include/glibtop/net_process.h 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      We shouldn't have such conversion functions in libgtop, there is g_format_size in glib.

      We shouldn't have such conversion functions in libgtop, there is g_format_size in glib.
    • Karuna Grewal @antares

      changed this line in version 6 of the diff

      Mar 20, 2018

      changed this line in version 6 of the diff

      changed this line in [version 6 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4433&start_sha=d5af9f3a5e354eb68f8cf2b8446bdd5c60051483#01e98257f2ddc914ddb018a337559c0004d987c8_34_34)
      Toggle commit list
    • Ben @bdejean commented Mar 20, 2018
      Master

      to_kb is defined as static in the net_process.c file. So it shouldn't be in the h file at all.

      to_kb is defined as static in the net_process.c file. So it shouldn't be in the h file at all.
    • Karuna Grewal @antares commented Mar 21, 2018
      1

      I did remove this just sometime back before you commented :)

      I did remove this just sometime back before you commented :)
    • Karuna Grewal @antares commented Mar 21, 2018
      1

      @robertroth I've changed the API to just return number of bytes over dbus.

      @robertroth I've changed the API to just return number of bytes over dbus.
    Please register or sign in to reply
  • Karuna Grewal @antares

    added 78 commits

    • 6d36f952 - Add directory traversal of /proc
    • a99fcf92 - Add file parsing for /proc/net/tcp
    • ed1bdf8f - Add parsing of network connections from /proc/net/ files
    • 8946ce74 - Add test for netsocket.c
    • 291d555d - Add hashTable to store inode and pid
    • 517f750e - Add test for proc_inode_parse.c
    • 74e56b58 - Add glib version of dir traversal
    • 4f4127fd - dev_handles : Open pcap handles for network interfaces
    • 0df6c8df - Test for checking the opened pcap handles for network devices
    • b4be0c8b - Change the dir name approach to GFile
    • 7fd26234 - GFile changes in the args
    • b58fdef5 - Add GError for error handling
    • 11cacfe4 - Switched to GINT_TO_POINTER
    • ca8515dd - Replace malloc with g_slice_new
    • 1c1a8515 - Minor changes in test file
    • 6519029f - Fix warning
    • ef8e091e - coding style fixes
    • 830a9430 - Add Interface's local address
    • 297d7ad4 - Add local address to interfaces
    • a6ae2722 - Add functions for manipulating packets
    • 001ea6c5 - Add connections details to keep track of relevant packets
    • 5c883514 - Add process details to track corresponding connections
    • 64ade368 - Add callback for tcp
    • 0173a0cf - Add more packet functions
    • d2460b74 - Add hash table for socket details and inode
    • 1a0608ad - Add packet processing functions
    • 5fd47603 - Modifications in packet function prototypes
    • c6ba6983 - Fix struct member name issues
    • 1faede8c - Add structs for network stats output
    • 447e579e - Add main testing file
    • 2df84811 - Redefinition issues fixed
    • 818d2e6a - Add packet hash to packet struct
    • b4cde82d - dev_handles.c : Modify packet processing functions
    • c9475686 - dev_handles.h: Add definition of packet headers
    • 56aebb48 - connection: Modify the connection matching functions
    • d91445da - This commit has to be broken down into patches
    • 9c0f7b74 - Separate the headers and tests
    • 87ee8482 - add missing files to Makefile
    • 1c32220e - Add Gio dependency
    • 63e285a3 - Add Symbols to MakeFile
    • b94e173b - Add LIBGTOP prefix to header guards
    • 59ae3667 - Change Process_list to GSList
    • cc7d0ed9 - Change Conn_list to GSList
    • d5e5a101 - Replace u_int data types by their GLib alternatives
    • 4d4dad26 - Change Packet_list to GSList
    • a09b0a54 - Add new headers to the list of introspectables
    • 7f9f3d1e - Change the network_stats_entry struct
    • 99e3efa0 - Add network stats cmd to the daemon
    • 669d40be - Change flags to enable Daemon for Linux
    • 03fdf8d6 - Define the libgtop_sysdeps_suid library for Linux
    • fb595da7 - Add glibtop_init_p in Linux
    • e980c6bd - Change the local_addr field in struct glibtop_socket
    • 735333be - Add glibtop_open_p function
    • 845517cf - Remove the error logs
    • 343e582b - Add DBus Interface to get the stats
    • 990aadee - Change the output GVariant
    • c046d6a3 - Add capture status function
    • 5053b599 - Add capture initializer function to DBus
    • 21e6383f - Change Daemon settings for Linux
    • 23d50dd4 - Move the DBus example to examples dir
    • d8e85a37 - Add packet capture init function to stats
    • ddbfb8fc - Add GPtrArray for the dbus_stats
    • a6272a85 - Add parameter in the get_stats_instance invocation
    • 33907c68 - Change the condition for keeping the capture active
    • a502cfea - Rename the toggle_capture_status function
    • f7ec73dc - WIP: Add the dictionary for DBus Messages
    • 18fdd98a - Remove proc_name from various structs
    • 7a01cd6a - Fix the issue in dictionary in GVariants
    • d46b5aa0 - Add g_timeout_add in the dbus interface
    • bcfde989 - Fix timeout issue in DBus interface
    • 216086de - Add check to stop the packet capture
    • 68d622ba - Fix segfault in GetStats
    • 5fd8826b - Add config files for DBus
    • a73cb0e0 - Add set and reset functions to dbus-interface
    • cb31e29c - Discard values ~0.00 in the network stats
    • 8865f9c7 - Activate the packet capture in the network test example
    • aa2f29c0 - Use g_error wherever required
    • cad22c04 - Fix warnings during compilation

    Compare with previous version

    Mar 20, 2018

    added 78 commits

    • 6d36f952 - Add directory traversal of /proc
    • a99fcf92 - Add file parsing for /proc/net/tcp
    • ed1bdf8f - Add parsing of network connections from /proc/net/ files
    • 8946ce74 - Add test for netsocket.c
    • 291d555d - Add hashTable to store inode and pid
    • 517f750e - Add test for proc_inode_parse.c
    • 74e56b58 - Add glib version of dir traversal
    • 4f4127fd - dev_handles : Open pcap handles for network interfaces
    • 0df6c8df - Test for checking the opened pcap handles for network devices
    • b4be0c8b - Change the dir name approach to GFile
    • 7fd26234 - GFile changes in the args
    • b58fdef5 - Add GError for error handling
    • 11cacfe4 - Switched to GINT_TO_POINTER
    • ca8515dd - Replace malloc with g_slice_new
    • 1c1a8515 - Minor changes in test file
    • 6519029f - Fix warning
    • ef8e091e - coding style fixes
    • 830a9430 - Add Interface's local address
    • 297d7ad4 - Add local address to interfaces
    • a6ae2722 - Add functions for manipulating packets
    • 001ea6c5 - Add connections details to keep track of relevant packets
    • 5c883514 - Add process details to track corresponding connections
    • 64ade368 - Add callback for tcp
    • 0173a0cf - Add more packet functions
    • d2460b74 - Add hash table for socket details and inode
    • 1a0608ad - Add packet processing functions
    • 5fd47603 - Modifications in packet function prototypes
    • c6ba6983 - Fix struct member name issues
    • 1faede8c - Add structs for network stats output
    • 447e579e - Add main testing file
    • 2df84811 - Redefinition issues fixed
    • 818d2e6a - Add packet hash to packet struct
    • b4cde82d - dev_handles.c : Modify packet processing functions
    • c9475686 - dev_handles.h: Add definition of packet headers
    • 56aebb48 - connection: Modify the connection matching functions
    • d91445da - This commit has to be broken down into patches
    • 9c0f7b74 - Separate the headers and tests
    • 87ee8482 - add missing files to Makefile
    • 1c32220e - Add Gio dependency
    • 63e285a3 - Add Symbols to MakeFile
    • b94e173b - Add LIBGTOP prefix to header guards
    • 59ae3667 - Change Process_list to GSList
    • cc7d0ed9 - Change Conn_list to GSList
    • d5e5a101 - Replace u_int data types by their GLib alternatives
    • 4d4dad26 - Change Packet_list to GSList
    • a09b0a54 - Add new headers to the list of introspectables
    • 7f9f3d1e - Change the network_stats_entry struct
    • 99e3efa0 - Add network stats cmd to the daemon
    • 669d40be - Change flags to enable Daemon for Linux
    • 03fdf8d6 - Define the libgtop_sysdeps_suid library for Linux
    • fb595da7 - Add glibtop_init_p in Linux
    • e980c6bd - Change the local_addr field in struct glibtop_socket
    • 735333be - Add glibtop_open_p function
    • 845517cf - Remove the error logs
    • 343e582b - Add DBus Interface to get the stats
    • 990aadee - Change the output GVariant
    • c046d6a3 - Add capture status function
    • 5053b599 - Add capture initializer function to DBus
    • 21e6383f - Change Daemon settings for Linux
    • 23d50dd4 - Move the DBus example to examples dir
    • d8e85a37 - Add packet capture init function to stats
    • ddbfb8fc - Add GPtrArray for the dbus_stats
    • a6272a85 - Add parameter in the get_stats_instance invocation
    • 33907c68 - Change the condition for keeping the capture active
    • a502cfea - Rename the toggle_capture_status function
    • f7ec73dc - WIP: Add the dictionary for DBus Messages
    • 18fdd98a - Remove proc_name from various structs
    • 7a01cd6a - Fix the issue in dictionary in GVariants
    • d46b5aa0 - Add g_timeout_add in the dbus interface
    • bcfde989 - Fix timeout issue in DBus interface
    • 216086de - Add check to stop the packet capture
    • 68d622ba - Fix segfault in GetStats
    • 5fd8826b - Add config files for DBus
    • a73cb0e0 - Add set and reset functions to dbus-interface
    • cb31e29c - Discard values ~0.00 in the network stats
    • 8865f9c7 - Activate the packet capture in the network test example
    • aa2f29c0 - Use g_error wherever required
    • cad22c04 - Fix warnings during compilation

    Compare with previous version

    added 78 commits <ul><li>6d36f952 - Add directory traversal of /proc</li><li>a99fcf92 - Add file parsing for /proc/net/tcp</li><li>ed1bdf8f - Add parsing of network connections from /proc/net/ files</li><li>8946ce74 - Add test for netsocket.c</li><li>291d555d - Add hashTable to store inode and pid</li><li>517f750e - Add test for proc_inode_parse.c</li><li>74e56b58 - Add glib version of dir traversal</li><li>4f4127fd - dev_handles : Open pcap handles for network interfaces</li><li>0df6c8df - Test for checking the opened pcap handles for network devices</li><li>b4be0c8b - Change the dir name approach to GFile</li><li>7fd26234 - GFile changes in the args</li><li>b58fdef5 - Add GError for error handling</li><li>11cacfe4 - Switched to GINT_TO_POINTER</li><li>ca8515dd - Replace malloc with g_slice_new</li><li>1c1a8515 - Minor changes in test file</li><li>6519029f - Fix warning</li><li>ef8e091e - coding style fixes</li><li>830a9430 - Add Interface&#39;s local address</li><li>297d7ad4 - Add local address to interfaces</li><li>a6ae2722 - Add functions for manipulating packets</li><li>001ea6c5 - Add connections details to keep track of relevant packets</li><li>5c883514 - Add process details to track corresponding connections</li><li>64ade368 - Add callback for tcp</li><li>0173a0cf - Add more packet functions</li><li>d2460b74 - Add hash table for socket details and inode</li><li>1a0608ad - Add packet processing functions</li><li>5fd47603 - Modifications in packet function prototypes</li><li>c6ba6983 - Fix struct member name issues</li><li>1faede8c - Add structs for network stats output</li><li>447e579e - Add main testing file</li><li>2df84811 - Redefinition issues fixed</li><li>818d2e6a - Add packet hash to packet struct</li><li>b4cde82d - dev_handles.c : Modify packet processing functions</li><li>c9475686 - dev_handles.h: Add definition of packet headers</li><li>56aebb48 - connection: Modify the connection matching functions</li><li>d91445da - This commit has to be broken down into patches</li><li>9c0f7b74 - Separate the headers and tests</li><li>87ee8482 - add missing files to Makefile</li><li>1c32220e - Add Gio dependency</li><li>63e285a3 - Add Symbols to MakeFile</li><li>b94e173b - Add LIBGTOP prefix to header guards</li><li>59ae3667 - Change Process_list to GSList</li><li>cc7d0ed9 - Change Conn_list to GSList</li><li>d5e5a101 - Replace u_int data types by their GLib alternatives</li><li>4d4dad26 - Change Packet_list to GSList</li><li>a09b0a54 - Add new headers to the list of introspectables</li><li>7f9f3d1e - Change the network_stats_entry struct</li><li>99e3efa0 - Add network stats cmd to the daemon</li><li>669d40be - Change flags to enable Daemon for Linux</li><li>03fdf8d6 - Define the libgtop_sysdeps_suid library for Linux</li><li>fb595da7 - Add glibtop_init_p in Linux</li><li>e980c6bd - Change the local_addr field in struct glibtop_socket</li><li>735333be - Add glibtop_open_p function</li><li>845517cf - Remove the error logs</li><li>343e582b - Add DBus Interface to get the stats</li><li>990aadee - Change the output GVariant</li><li>c046d6a3 - Add capture status function</li><li>5053b599 - Add capture initializer function to DBus</li><li>21e6383f - Change Daemon settings for Linux</li><li>23d50dd4 - Move the DBus example to examples dir</li><li>d8e85a37 - Add packet capture init function to stats</li><li>ddbfb8fc - Add GPtrArray for the dbus_stats</li><li>a6272a85 - Add parameter in the get_stats_instance invocation</li><li>33907c68 - Change the condition for keeping the capture active</li><li>a502cfea - Rename the toggle_capture_status function</li><li>f7ec73dc - WIP: Add the dictionary for DBus Messages</li><li>18fdd98a - Remove proc_name from various structs</li><li>7a01cd6a - Fix the issue in dictionary in GVariants</li><li>d46b5aa0 - Add g_timeout_add in the dbus interface</li><li>bcfde989 - Fix timeout issue in DBus interface</li><li>216086de - Add check to stop the packet capture</li><li>68d622ba - Fix segfault in GetStats</li><li>5fd8826b - Add config files for DBus</li><li>a73cb0e0 - Add set and reset functions to dbus-interface</li><li>cb31e29c - Discard values ~0.00 in the network stats</li><li>8865f9c7 - Activate the packet capture in the network test example</li><li>aa2f29c0 - Use g_error wherever required</li><li>cad22c04 - Fix warnings during compilation</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4418&start_sha=050ba4506355bbb15fa196ad8acd4e46e3f425c5)
    Toggle commit list
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Robert Roth Mar 30, 2018
    include/glibtop/net_process.h 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      Let's leave this convertsion to the GUIs.

      Edited Mar 20, 2018
      Let's leave this convertsion to the GUIs.
    • Karuna Grewal @antares commented Mar 20, 2018
      1

      Now I've changed the stats to be returned as kb rather than kbps , does that suffice our purpose ?

      Edited Mar 20, 2018
      Now I've changed the stats to be returned as kb rather than kbps , does that suffice our purpose ?
    • Karuna Grewal @antares

      changed this line in version 6 of the diff

      Mar 20, 2018

      changed this line in version 6 of the diff

      changed this line in [version 6 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4433&start_sha=d5af9f3a5e354eb68f8cf2b8446bdd5c60051483#01e98257f2ddc914ddb018a337559c0004d987c8_35_34)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Robert Roth Apr 03, 2018
    sysdeps/linux/connection.c 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      we should not use printf, rather use glib logging functions, glib_debug, glib_log, etc.

      we should not use printf, rather use glib logging functions, glib_debug, glib_log, etc.
    • Karuna Grewal @antares commented Mar 20, 2018
      1

      Do I use g_debug for the printf or simply remove them because they were initially meant for debugging purpose ?

      Do I use `g_debug` for the `printf` or simply remove them because they were initially meant for debugging purpose ?
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Either remove this, or move this to the netstats example, as this output is useful in an example, we have relevant data printed in examples.

      Either remove this, or move this to the netstats example, as this output is useful in an example, we have relevant data printed in examples.
    • Karuna Grewal @antares

      changed this line in version 9 of the diff

      Mar 21, 2018

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4523&start_sha=775bbd1e5971ade3453632a2268e10fa699c0ae5#1e03355b42fdc822e38c202d5b3c4382ceead8c3_126_121)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 20, 2018
    include/glibtop/dev_handles.h 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 20, 2018
      Master

      We don't want to have print_* functions in public headers.

      Edited Mar 20, 2018
      We don't want to have print_* functions in public headers.
    • Karuna Grewal @antares

      changed this line in version 5 of the diff

      Mar 20, 2018

      changed this line in version 5 of the diff

      changed this line in [version 5 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4431&start_sha=cad22c04a1808800bebdb91b68c61e5317fa0fce#320ef978417619244bbe4e5158f5850e50144daa_108_108)
      Toggle commit list
    Please register or sign in to reply
  • Karuna Grewal @antares

    added 1 commit

    • d5af9f3a - Return network stats as kb

    Compare with previous version

    Mar 20, 2018

    added 1 commit

    • d5af9f3a - Return network stats as kb

    Compare with previous version

    added 1 commit <ul><li>d5af9f3a - Return network stats as kb</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4431&start_sha=cad22c04a1808800bebdb91b68c61e5317fa0fce)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • dad596c6 - Remove functions for bytes to kb conversion

    Compare with previous version

    Mar 20, 2018

    added 1 commit

    • dad596c6 - Remove functions for bytes to kb conversion

    Compare with previous version

    added 1 commit <ul><li>dad596c6 - Remove functions for bytes to kb conversion</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4433&start_sha=d5af9f3a5e354eb68f8cf2b8446bdd5c60051483)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • a43fbd28 - Add PCAP_LIBS variable to configure.ac

    Compare with previous version

    Mar 20, 2018

    added 1 commit

    • a43fbd28 - Add PCAP_LIBS variable to configure.ac

    Compare with previous version

    added 1 commit <ul><li>a43fbd28 - Add PCAP_LIBS variable to configure.ac</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4435&start_sha=dad596c6d3112ba67ca2b4ead9acb8238505b63a)
    Toggle commit list
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 22, 2018
    include/glibtop/net_process.h 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      Would it be possible to either use a GArrayPtr or a GSList instead ?

      Edited Mar 22, 2018
      Would it be possible to either use a GArrayPtr or a GSList instead ?
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      @bdejean Sorry but this is not currently used , It's been a while since I changed this to GSList in another comment's follow-up.I've removed this from the header.

      Edited Mar 22, 2018
      @bdejean Sorry but this is not currently used , It's been a while since I changed this to GSList in another comment's follow-up.I've removed this from the header.
    • Karuna Grewal @antares

      changed this line in version 10 of the diff

      Mar 22, 2018

      changed this line in version 10 of the diff

      changed this line in [version 10 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4569&start_sha=bde5f8d0ff32e914f016a3d66cc31fddd6a34de4#01e98257f2ddc914ddb018a337559c0004d987c8_25_24)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Last updated by Ben Apr 17, 2018
    include/glibtop/interface_local_addr.h 0 → 100644
    1 #ifndef __GLIBTOP_INTERFACE_LOCAL_ADDR_H__
    2 #define __GLIBTOP_INTERFACE_LOCAL_ADDR_H__
    3
    4 #include <sys/types.h>
    5 #include <ifaddrs.h>
    6 #include <glib.h>
    7 #include <sys/socket.h>
    8 #include <netinet/in.h>
    9
    10 typedef struct _local_addr local_addr;
    11 struct _local_addr
    12 {
    13 in_addr_t addr; //ip in network Byte order
    14 struct in6_addr addr6;
    15 short int sa_family;
    16 char *ip_text; //to store ip in text form
    • Ben @bdejean commented Mar 20, 2018
      Master

      How is it allocated/deallocated ?

      How is it allocated/deallocated ?
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      I'm using g_slice_new() here

      Is it fine?

      Edited Mar 22, 2018
      I'm using g_slice_new() [here](https://gitlab.gnome.org/antares/libgtop/blob/wip/antares/jhbuild_modif/sysdeps/linux/interface_local_addr.c#L75) Is it fine?
    • Ben @bdejean commented Mar 26, 2018
      Master

      I'm talking about the ip_text field ? Maybe you could even make it an array instead of pointer.

      I'm talking about the `ip_text` field ? Maybe you could even make it an array instead of pointer.
    • Karuna Grewal @antares commented Mar 29, 2018
      1

      I kept it as ptr just to not bring in sized allocations

      But as we already know the ip size I can surely make the changes if you want :)

      Edited Mar 30, 2018
      I kept it as ptr just to not bring in sized allocations But as we already know the ip size I can surely make the changes if you want :)
    • Karuna Grewal @antares

      changed this line in version 14 of the diff

      Mar 29, 2018

      changed this line in version 14 of the diff

      changed this line in [version 14 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4948&start_sha=a2f1c6976a87a1516ef34460293a6b9cb51ce1aa#f3bc20d4d03d5ce74c1382c8749004066b5fa431_16_16)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 30, 2018
      1

      I've made the req. changes

      I've made the req. changes
    • Ben @bdejean commented Apr 17, 2018
      Master

      I think that you need at least 40+1 bytes to store an IPv6 address, for example "fe80:0000:0000:0000:020f:bbff:feb8:f89e". So 30 is not enough.

      I think that you need at least 40+1 bytes to store an IPv6 address, for example "fe80:0000:0000:0000:020f:bbff:feb8:f89e". So 30 is not enough.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 22, 2018
    include/glibtop/sysdeps.h
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      You need to rename the field reserved0 in order to avoid breaking the ABI.

      Edited Mar 22, 2018
      You need to rename the field reserved0 in order to avoid breaking the ABI.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Last updated by Ben Apr 17, 2018
    lib/libgtop.sym
    77 77 glibtop_map_entry_get_type
    78 78 glibtop_proc_map_get_type
    79 79 glibtop_get_type
    80 get_global_hashes_instance
    • Ben @bdejean commented Mar 20, 2018
      Master

      Could you please prefix all public symbols with glibtop_ ? Would it also be possible to prefix accordingly all public types ?

      Could you please prefix all public symbols with glibtop_ ? Would it also be possible to prefix accordingly all public types ?
    • Ben @bdejean commented Mar 20, 2018
      Master

      @antares could you please tell what functions are to be called by users and what is internal to libgtop ? The whole point of this file is to control what functions are publicly exported/visibled to libgtop users.

      @antares could you please tell what functions are to be called by users and what is internal to libgtop ? The whole point of this file is to control what functions are publicly exported/visibled to libgtop users.
    • Karuna Grewal @antares

      changed this line in version 10 of the diff

      Mar 22, 2018

      changed this line in version 10 of the diff

      changed this line in [version 10 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4569&start_sha=bde5f8d0ff32e914f016a3d66cc31fddd6a34de4#7f15f08b8c48ab23cbfc43e0f122879a3b394082_80_80)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      @bdejean you may now have a look at the current diff , it just has the public API exposed

      Pls let me know your views!

      Edited Mar 22, 2018 by Karuna Grewal
      @bdejean you may now have a look at the current diff , it just has the public API exposed Pls let me know your views!
    • Ben @bdejean commented Apr 17, 2018
      Master

      OK, I'm not sure about the names, but the exposed interface is definitely smaller.

      OK, I'm not sure about the names, but the exposed interface is definitely smaller.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Robert Roth Apr 03, 2018
    libgtop-sysdeps.m4
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      @robertroth if you open a 3.30 branch, I could already merge by server code, that would help not mixing topics.

      @robertroth if you open a 3.30 branch, I could already merge by server code, that would help not mixing topics.
    • Robert Roth @robertroth commented Mar 30, 2018
      Master

      @antares the changes are on master for the gtop server, and are also causing merge conflicts, it would be great if you could rebase to master.

      @antares the changes are on master for the gtop server, and are also causing merge conflicts, it would be great if you could rebase to master.
    • Karuna Grewal @antares

      changed this line in version 15 of the diff

      Apr 01, 2018

      changed this line in version 15 of the diff

      changed this line in version 15 of the diff
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 22, 2018
    sysdeps/linux/net_process.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      Please use double

      Edited Mar 22, 2018
      Please use double
    • Karuna Grewal @antares

      changed this line in version 8 of the diff

      Mar 21, 2018

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4511&start_sha=a43fbd28cac21c0072698247b7b1691806ca8196#07e75159a690366c7a38de90af79376f4e818607_50_50)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/stats.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      Please use foreach or set a free_func https://developer.gnome.org/glib/unstable/glib-Pointer-Arrays.html#g-ptr-array-new-with-free-func

      Please use foreach or set a free_func https://developer.gnome.org/glib/unstable/glib-Pointer-Arrays.html#g-ptr-array-new-with-free-func
    • Karuna Grewal @antares

      changed this line in version 12 of the diff

      Mar 23, 2018

      changed this line in version 12 of the diff

      changed this line in [version 12 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4585&start_sha=78ddc0027640807befbf32903b496b2fc699b7ad#30edc971876d0b07ae994cf8ca659e16bdab5f68_28_27)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 23, 2018
      1

      Pls have a look at the latest commit,it's been updated there

      Pls have a look at the latest commit,it's been updated there
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/stats.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      double please :-)

      Edited Mar 22, 2018
      double please :-)
    • Karuna Grewal @antares

      changed this line in version 8 of the diff

      Mar 21, 2018

      changed this line in version 8 of the diff

      changed this line in [version 8 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4511&start_sha=a43fbd28cac21c0072698247b7b1691806ca8196#30edc971876d0b07ae994cf8ca659e16bdab5f68_146_145)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    include/glibtop/dev_handles.h 0 → 100644
    48 struct in6_addr ip6_src;
    49 struct in6_addr ip6_dst;
    50 };
    51 /*Defining the headers as those available in netinet_*.h are having issues when parsing for ports*/
    52 #define SNAP_LEN 1518
    53 #define SIZE_ETHERNET 14
    54 #define ETHER_ADDR_LEN 6
    55 /* Ethernet header */
    56 struct hdr_ethernet {
    57 u_char ether_dhost[ETHER_ADDR_LEN];
    58 u_char ether_shost[ETHER_ADDR_LEN];
    59 u_short ether_type;
    60 };
    61
    62 /* IP header */
    63 struct hdr_ip {
    • Ben @bdejean commented Mar 20, 2018
      Master

      For all these kind of structs that implement a RFC, I think we either need a packed attribute or simply a G_STATIC_ASSERT to validate the size, don't we ?

      For all these kind of structs that implement a RFC, I think we either need a packed attribute or simply a G_STATIC_ASSERT to validate the size, don't we ?
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    include/glibtop/connection.h 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      That's a time_t I think.

      That's a time_t I think.
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      @bdejean can you pls clear a doubt of mine here,

      I have actually assigned the tv_sec field present in the time_t struct to the last_packet_time that's why I've used int , but if you say that I should use time_t I shall change to that.

      @bdejean can you pls clear a doubt of mine here, I have actually assigned the `tv_sec` field present in the `time_t` struct to the `last_packet_time` that's why I've used `int` , but if you say that I should use `time_t` I shall change to that.
    • Ben @bdejean commented Mar 26, 2018
      Master

      @antares I'm not really sure where it comes from, but if it's a struct timespec (=> man 2 nanosleep) then it's definitely a time_t.

      @antares I'm not really sure where it comes from, but if it's a `struct timespec` (=> `man 2 nanosleep`) then it's definitely a `time_t`.
    • Karuna Grewal @antares

      changed this line in version 13 of the diff

      Mar 29, 2018

      changed this line in version 13 of the diff

      changed this line in [version 13 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4935&start_sha=2b5d8076f2cc2d03e2943eecdb6c8ccb5b81607e#1492163e7efd562839ca2f7494a62fbc458723b9_22_22)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 29, 2018
      1

      Made the changes, pls have a look at the diff.

      Made the changes, pls have a look at the diff.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    Last updated by Ben Apr 17, 2018
    sysdeps/linux/Makefile.am
    11 11 procsegment.c procargs.c procmap.c siglist.c \
    12 12 sysinfo.c netload.c ppp.c glibtop_private.c \
    13 13 mountlist.c procaffinity.c procio.c \
    14 fsusage.c netlist.c procopenfiles.c procwd.c
    14 fsusage.c netlist.c procopenfiles.c procwd.c \
    15 proc_inode_parser.c netsockets.c \
    • Ben @bdejean commented Mar 20, 2018
      Master

      General question: is this code really specific ? Shouldn't it go to common instead ?

      General question: is this code really specific ? Shouldn't it go to common instead ?
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      We can't move the following files to common because they are specific to the Linux fs:

      • procopenfiles.c
      • proc_inode_parser
      • netsockets

      But the packet parsing files can be moved to common , again because after parsing they make use of function calls defined in the above files , so indirectly it means that even those are getting more specific

      In case we want to move the packet processing part to common/ , pls let me know , few slight changes will be good enough to separate the generic part of the code to common/

      We can't move the following files to common because they are specific to the Linux fs: * procopenfiles.c * proc_inode_parser * netsockets But the packet parsing files can be moved to common , again because after parsing they make use of function calls defined in the above files , so indirectly it means that even those are getting more specific In case we want to move the packet processing part to `common/` , pls let me know , few slight changes will be good enough to separate the generic part of the code to `common/`
    • Ben @bdejean commented Apr 17, 2018
      Master

      If the packet processing is generic enough, yes, it's definitely a start to move it common/

      If the packet processing is generic enough, yes, it's definitely a start to move it common/
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/packet.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      *pkt = *old_packet ?

      Edited Mar 22, 2018
      *pkt = *old_packet ?
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#8e2f30ab126a41e78f304a8cdd33f8aa51f73981_45_44)
      Toggle commit list
    • Ben @bdejean commented Apr 17, 2018
      Master

      ok for the g_slice.

      ok for the g_slice.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/packet.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      About style: may be a simple if () would be more readable than all that code in that switch/case.

      Edited Mar 22, 2018
      About style: may be a simple if () would be more readable than all that code in that switch/case.
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#8e2f30ab126a41e78f304a8cdd33f8aa51f73981_67_57)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/stats.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      only used once, just drop it, that pointer stuff make it harder to read.

      only used once, just drop it, that pointer stuff make it harder to read.
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#30edc971876d0b07ae994cf8ca659e16bdab5f68_78_77)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/stats.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      n is never used, is it ?

      Edited Mar 22, 2018
      n is never used, is it ?
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#30edc971876d0b07ae994cf8ca659e16bdab5f68_154_165)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/stats.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      style: you shouldn't need to cast to gpointer because in C everything is freely convertible from and to void*

      Edited Mar 22, 2018
      style: you shouldn't need to cast to gpointer because in C everything is freely convertible from and to void*
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#30edc971876d0b07ae994cf8ca659e16bdab5f68_150_160)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    sysdeps/linux/packet.c 0 → 100644
    1 #include <glibtop/packet.h>
    2 #include <glib.h>
    3 #include <glibtop/interface_local_addr.h>
    4 #include <glibtop/dev_handles.h>
    5 #include <arpa/inet.h>
    6 #include <stdlib.h>
    7
    8 void
    9 Packet_init_in_addr(Packet *pkt, struct in_addr pkt_sip, unsigned short pkt_sport, struct in_addr pkt_dip,
    10 unsigned short pkt_dport, guint32 pkt_len, struct timeval pkt_ts ,direction pkt_dir)
    11 {
    12 pkt->sa_family = AF_INET;
    • Ben @bdejean commented Mar 20, 2018
      Master

      Maybe you want to memset(pkt, 0, sizeof pkt) the whole Packet first ?

      Edited Mar 22, 2018
      Maybe you want to memset(pkt, 0, sizeof pkt) the whole Packet first ?
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/netsockets.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      Are these 2 casts safe ? Better use strtoull ?

      Are these 2 casts safe ? Better use strtoull ?
    • Karuna Grewal @antares

      changed this line in version 12 of the diff

      Mar 23, 2018

      changed this line in version 12 of the diff

      changed this line in [version 12 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4585&start_sha=78ddc0027640807befbf32903b496b2fc699b7ad#4653e564dd8e12fbadceab4f0d0187a126eee749_89_89)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/netsockets.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      &* ?

      Edited Mar 22, 2018
      &* ?
    • Karuna Grewal @antares

      changed this line in version 12 of the diff

      Mar 23, 2018

      changed this line in version 12 of the diff

      changed this line in [version 12 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4585&start_sha=78ddc0027640807befbf32903b496b2fc699b7ad#4653e564dd8e12fbadceab4f0d0187a126eee749_94_94)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/netsockets.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      feof is only set only when you've reached EOF and you've attempted to read again. feof is only there to tell you what was the error you've encountered, not to detect the EOF itself. That's really important and applies to both C and C++. The canonical way would be:

      while (fgets(...) != NULL) {
      
      }
      
      if (!feof()) {
        // fgets said that an error was found and yet it's not feof, so it's definitely an IO error that should be reported
      }
      Edited Mar 22, 2018
      feof is only set only when you've reached EOF and you've attempted to read again. feof is only there to tell you what was the error you've encountered, not to detect the EOF itself. That's really important and applies to both C and C++. The canonical way would be: ``` while (fgets(...) != NULL) { } if (!feof()) { // fgets said that an error was found and yet it's not feof, so it's definitely an IO error that should be reported } ```
    • Karuna Grewal @antares

      changed this line in version 12 of the diff

      Mar 23, 2018

      changed this line in version 12 of the diff

      changed this line in [version 12 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4585&start_sha=78ddc0027640807befbf32903b496b2fc699b7ad#4653e564dd8e12fbadceab4f0d0187a126eee749_125_125)
      Toggle commit list
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/proc_inode_parser.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      This only matches '1' to '8'. Is that what you really want ? Please use g_ascii_isdigit(currentFile[0]) instead.

      Edited Mar 22, 2018
      This only matches '1' to '8'. Is that what you really want ? Please use g_ascii_isdigit(currentFile[0]) instead.
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#1089c99529e8782640eddeea03102c065c1abab0_32_32)
      Toggle commit list
    • Ben @bdejean commented Apr 17, 2018
      Master

      Fine

      Fine
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    sysdeps/linux/proc_inode_parser.c 0 → 100644
    40 if (g_strcmp0(currentFile,"fd") == 0)
    41 {
    42 enter_fd = TRUE;
    43 traverse_file(g_file_get_child(curdir, g_file_info_get_name(info_buf)), depth+1, pid, inode_table);
    44 }
    45 break;
    46 }
    47 }
    48 else if (g_file_info_get_is_symlink(info_buf))
    49 {
    50 gchar *symlink_name = g_build_filename(g_file_get_path(curdir), currentFile, NULL);
    51 gchar *slnk_buf = g_file_read_link(symlink_name, NULL);
    52 if (slnk_buf != NULL)
    53 {
    54 int inode;
    55 int match = sscanf(slnk_buf, "socket:[%d]\n", &inode);
    • Ben @bdejean commented Mar 20, 2018
      Master

      I think you should use at least an unsigned long instead with %lu format. Or even a guint64 and "socket:[" G_GUINT64_FORMAT "]\n".

      I think you should use at least an `unsigned long` instead with `%lu` format. Or even a `guint64` and `"socket:[" G_GUINT64_FORMAT "]\n"`.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    sysdeps/linux/proc_inode_parser.c 0 → 100644
    44 }
    45 break;
    46 }
    47 }
    48 else if (g_file_info_get_is_symlink(info_buf))
    49 {
    50 gchar *symlink_name = g_build_filename(g_file_get_path(curdir), currentFile, NULL);
    51 gchar *slnk_buf = g_file_read_link(symlink_name, NULL);
    52 if (slnk_buf != NULL)
    53 {
    54 int inode;
    55 int match = sscanf(slnk_buf, "socket:[%d]\n", &inode);
    56 if (match == 1)
    57 {
    58 int pid_int = g_ascii_strtoll(pid, NULL, 0);
    59 g_hash_table_insert(inode_table, GINT_TO_POINTER(inode), GINT_TO_POINTER(pid_int));
    • Ben @bdejean commented Mar 20, 2018
      Master

      Then you'll probably need to allocate something instead of packing ints into pointers.

      Then you'll probably need to allocate something instead of packing ints into pointers.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on the diff Mar 20, 2018
    Resolved by Karuna Grewal Mar 22, 2018
    sysdeps/linux/proc_inode_parser.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      symlink_name and slnk_buf need to be g_free.

      Edited Mar 22, 2018
      `symlink_name` and `slnk_buf` need to be `g_free`.
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/connection.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      You could even directly use g_slice_copy https://developer.gnome.org/glib/unstable/glib-Memory-Slices.html#g-slice-copy

      Or simply change Packet_init to something like:

      Packet* Packet_init(Packet* old)
      {
        return g_slice_copy(sizeof *old, old);
      }
      Edited Mar 22, 2018
      You could even directly use `g_slice_copy` https://developer.gnome.org/glib/unstable/glib-Memory-Slices.html#g-slice-copy Or simply change `Packet_init` to something like: ``` Packet* Packet_init(Packet* old) { return g_slice_copy(sizeof *old, old); } ```
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      As pointed out in this discussion thread I just removed this function and replace with what you had suggested above.

      Which one would you prefer?

      As pointed out in this [discussion thread](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1#note_83364) I just removed this function and replace with what you had suggested above. Which one would you prefer?
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#1e03355b42fdc822e38c202d5b3c4382ceead8c3_16_16)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      Anyways I find this approach much better , so I have changed to this one , pls confirm if this is fine .

      Anyways I find this approach much better , so I have changed to this one , pls confirm if this is fine .
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Last updated by Karuna Grewal Mar 22, 2018
    sysdeps/linux/stats.c 0 → 100644
    24
    25 static void
    26 network_stats_print_entry(network_stats_entry *st)
    27 {
    28 printf("pid :%d \t sent_value:%f \trecv value:%f \t \n", st->pid, st->sent_value, st->recv_value);
    29 }
    30
    31
    32 void
    33 network_stats_print_stat(GArray *stats,int nproc)
    34 {
    35 for(guint index = 0; index < (guint)nproc; index++)
    36 {
    37 network_stats_entry temp = g_array_index (stats, network_stats_entry, index);
    38 network_stats_print_entry(&temp);
    39 if(stats->len>index )
    • Ben @bdejean commented Mar 20, 2018
      Master

      I don't understand that if.

      Edited Mar 22, 2018
      I don't understand that if.
    • Karuna Grewal @antares

      changed this line in version 9 of the diff

      Mar 21, 2018

      changed this line in version 9 of the diff

      changed this line in [version 9 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4523&start_sha=775bbd1e5971ade3453632a2268e10fa699c0ae5#30edc971876d0b07ae994cf8ca659e16bdab5f68_38_25)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      In case the number of processes have reduced in the next refresh cycle then to keep only the latest updated number of entries in the GArray , I'm deleting those entries which are beyond the range of the latest number of entries

      But I've deleted this function because as per the discussions in other threads print_* functions shouldn't be exposed

      In case the number of processes have reduced in the next refresh cycle then to keep only the latest updated number of entries in the GArray , I'm deleting those entries which are beyond the range of the latest number of entries But I've deleted this function because as per the discussions in other threads `print_*` functions shouldn't be exposed
    Please register or sign in to reply
  • Ben
    @bdejean started a discussion on an old version of the diff Mar 20, 2018
    Resolved by Ben Apr 17, 2018
    sysdeps/linux/stats.c 0 → 100644
    Unable to load the diff.
    • Ben @bdejean commented Mar 20, 2018
      Master

      Drop fname and simply give "/proc/..." as an argument.

      Edited Mar 22, 2018
      Drop fname and simply give "/proc/..." as an argument.
    • Karuna Grewal @antares

      changed this line in version 11 of the diff

      Mar 22, 2018

      changed this line in version 11 of the diff

      changed this line in [version 11 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d#30edc971876d0b07ae994cf8ca659e16bdab5f68_111_123)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 21, 2018
    Resolved by Ben Apr 17, 2018
    config.rpath 0 → 100755
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Drop this file from the merge request. You have to do a make clean, make distclean, drop this file, and configure the project again in order to not have issues with autotools, but this is a generated file, and should not be in the git repo, it should be gitignored.

      Drop this file from the merge request. You have to do a make clean, make distclean, drop this file, and configure the project again in order to not have issues with autotools, but this is a generated file, and should not be in the git repo, it should be gitignored.
    • Karuna Grewal @antares

      changed this line in version 16 of the diff

      Apr 08, 2018

      changed this line in version 16 of the diff

      changed this line in [version 16 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=5432&start_sha=896595d71a8eb676697903015e7734db8813c349#ae7573437ea389cc00680d29cbdf51b7c22f0969_1_0)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 21, 2018
    Resolved by Robert Roth Mar 29, 2018
    examples/devtest.c 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Indentation is wrong here.

      Edited Mar 22, 2018
      Indentation is wrong here.
    • Karuna Grewal @antares

      changed this line in version 10 of the diff

      Mar 22, 2018

      changed this line in version 10 of the diff

      changed this line in [version 10 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4569&start_sha=bde5f8d0ff32e914f016a3d66cc31fddd6a34de4#b244865f0427424f540a5c497508fafe8f18c478_14_20)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on an old version of the diff Mar 21, 2018
    Resolved by Robert Roth Mar 29, 2018
    examples/devtest.c 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Indentation is wrong here.

      Edited Mar 22, 2018
      Indentation is wrong here.
    • Karuna Grewal @antares

      changed this line in version 10 of the diff

      Mar 22, 2018

      changed this line in version 10 of the diff

      changed this line in [version 10 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4569&start_sha=bde5f8d0ff32e914f016a3d66cc31fddd6a34de4#b244865f0427424f540a5c497508fafe8f18c478_21_24)
      Toggle commit list
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on the diff Mar 21, 2018
    Resolved by Robert Roth Apr 03, 2018
    sysdeps/linux/net_process.c 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Commented-out code is not useful. Either uncomment or delete.

      Edited Mar 22, 2018
      Commented-out code is not useful. Either uncomment or delete.
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on the diff Mar 21, 2018
    Resolved by Robert Roth Apr 03, 2018
    sysdeps/linux/netstats.c 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      Commented out code is not something we need in the codebase. If do_refresh_s remains empty after removing the commented code, remove the method too.

      Commented out code is not something we need in the codebase. If do_refresh_s remains empty after removing the commented code, remove the method too.
    • Karuna Grewal @antares commented Mar 22, 2018
      1

      I need to discuss about this file , because it is sth we used for the libgtop daemon on Linux but now that we aren't (for the time being) , can you pls tell me whether I drop the file or not.

      If not , then this function will be using the functions defined in stats.c

      I need to discuss about this file , because it is sth we used for the libgtop daemon on Linux but now that we aren't (for the time being) , can you pls tell me whether I drop the file or not. If not , then this function will be using the functions defined in stats.c
    • Robert Roth @robertroth commented Mar 30, 2018
      Master

      We have the gtop Linux daemon code on master.

      We have the gtop Linux daemon code on master.
    Please register or sign in to reply
  • Robert Roth
    @robertroth started a discussion on the diff Mar 21, 2018
    Resolved by Robert Roth Apr 03, 2018
    sysdeps/linux/netstats.c 0 → 100644
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 21, 2018
      Master

      The same as with other commented-out code parts.

      The same as with other commented-out code parts.
    Please register or sign in to reply
  • Karuna Grewal @antares

    added 1 commit

    • 775bbd1e - API should return bytes transferred

    Compare with previous version

    Mar 21, 2018

    added 1 commit

    • 775bbd1e - API should return bytes transferred

    Compare with previous version

    added 1 commit <ul><li>775bbd1e - API should return bytes transferred</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4511&start_sha=a43fbd28cac21c0072698247b7b1691806ca8196)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • bde5f8d0 - Remove printf statements

    Compare with previous version

    Mar 21, 2018

    added 1 commit

    • bde5f8d0 - Remove printf statements

    Compare with previous version

    added 1 commit <ul><li>bde5f8d0 - Remove printf statements</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4523&start_sha=775bbd1e5971ade3453632a2268e10fa699c0ae5)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • 4b56ccac - Prefix glibtop to public API

    Compare with previous version

    Mar 22, 2018

    added 1 commit

    • 4b56ccac - Prefix glibtop to public API

    Compare with previous version

    added 1 commit <ul><li>4b56ccac - Prefix glibtop to public API</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4569&start_sha=bde5f8d0ff32e914f016a3d66cc31fddd6a34de4)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • 78ddc002 - Minor changes in some func defintions

    Compare with previous version

    Mar 22, 2018

    added 1 commit

    • 78ddc002 - Minor changes in some func defintions

    Compare with previous version

    added 1 commit <ul><li>78ddc002 - Minor changes in some func defintions</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4581&start_sha=4b56ccac3eaa5f7a8a368bd481834a9d6895552d)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • 2b5d8076 - Use free function to free the DBus stats

    Compare with previous version

    Mar 23, 2018

    added 1 commit

    • 2b5d8076 - Use free function to free the DBus stats

    Compare with previous version

    added 1 commit <ul><li>2b5d8076 - Use free function to free the DBus stats</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4585&start_sha=78ddc0027640807befbf32903b496b2fc699b7ad)
    Toggle commit list
  • Robert Roth
    @robertroth started a discussion on an outdated change in commit 4b56ccac Mar 25, 2018
    Resolved by Robert Roth Apr 03, 2018
    sysdeps/linux/stats.c
    Unable to load the diff.
    • Robert Roth @robertroth commented Mar 25, 2018
      Master

      Any objections against calling this glibtop_init_netstats? glibtop_init_setup doesn't help me finding out what it initializes.

      Any objections against calling this glibtop_init_netstats? glibtop_init_setup doesn't help me finding out what it initializes.
    • Karuna Grewal @antares

      changed this line in version 13 of the diff

      Mar 29, 2018

      changed this line in version 13 of the diff

      changed this line in [version 13 of the diff](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4935&start_sha=2b5d8076f2cc2d03e2943eecdb6c8ccb5b81607e#30edc971876d0b07ae994cf8ca659e16bdab5f68_193_193)
      Toggle commit list
    • Karuna Grewal @antares commented Mar 29, 2018
      1

      I've changed this

      I've changed this
    Please register or sign in to reply
  • Karuna Grewal @antares

    added 2 commits

    • 2842be7e - Rename glibtop_init_stats to glibgtop_init_netstats
    • a2f1c697 - Use time_t wherever required

    Compare with previous version

    Mar 29, 2018

    added 2 commits

    • 2842be7e - Rename glibtop_init_stats to glibgtop_init_netstats
    • a2f1c697 - Use time_t wherever required

    Compare with previous version

    added 2 commits <ul><li>2842be7e - Rename glibtop_init_stats to glibgtop_init_netstats</li><li>a2f1c697 - Use time_t wherever required</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4935&start_sha=2b5d8076f2cc2d03e2943eecdb6c8ccb5b81607e)
    Toggle commit list
  • Karuna Grewal @antares

    added 1 commit

    • 0d6a8a3e - Replace ptr by array

    Compare with previous version

    Mar 29, 2018

    added 1 commit

    • 0d6a8a3e - Replace ptr by array

    Compare with previous version

    added 1 commit <ul><li>0d6a8a3e - Replace ptr by array</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=4948&start_sha=a2f1c6976a87a1516ef34460293a6b9cb51ce1aa)
    Toggle commit list
  • Karuna Grewal @antares

    added 94 commits

    • 0d6a8a3e...35a0ba8e - 4 commits from branch GNOME:master
    • 9f99a620 - Add directory traversal of /proc
    • 7da5e029 - Add file parsing for /proc/net/tcp
    • 7ef01db5 - Add parsing of network connections from /proc/net/ files
    • 294204a4 - Add test for netsocket.c
    • cbe605bf - Add hashTable to store inode and pid
    • 6e672dd7 - Add test for proc_inode_parse.c
    • c312da68 - Add glib version of dir traversal
    • 6a1e9337 - dev_handles : Open pcap handles for network interfaces
    • 04da947f - Test for checking the opened pcap handles for network devices
    • d6351f17 - Change the dir name approach to GFile
    • 62f0013c - GFile changes in the args
    • 9d236bb3 - Add GError for error handling
    • dfe21cb2 - Switched to GINT_TO_POINTER
    • 1bb526d4 - Replace malloc with g_slice_new
    • 5dd7deb2 - Minor changes in test file
    • c4cb26d5 - Fix warning
    • 707cb7ad - coding style fixes
    • 1153f96d - Add Interface's local address
    • 77e1876f - Add local address to interfaces
    • 5a3431d6 - Add functions for manipulating packets
    • 0967cbf5 - Add connections details to keep track of relevant packets
    • 5e6947d7 - Add process details to track corresponding connections
    • b47de8ef - Add callback for tcp
    • 30a40f27 - Add more packet functions
    • a82d6754 - Add hash table for socket details and inode
    • 360a0ee4 - Add packet processing functions
    • 3ff43963 - Modifications in packet function prototypes
    • 99eb516b - Fix struct member name issues
    • 5fb75c27 - Add structs for network stats output
    • 744c3afe - Add main testing file
    • ca2a700a - Redefinition issues fixed
    • 7c0e3de4 - Add packet hash to packet struct
    • b7b4406a - dev_handles.c : Modify packet processing functions
    • de344641 - dev_handles.h: Add definition of packet headers
    • 4f246f4b - connection: Modify the connection matching functions
    • a7b8c23b - This commit has to be broken down into patches
    • 54fe9773 - Separate the headers and tests
    • b93f6157 - add missing files to Makefile
    • 6bdb6b18 - Add Gio dependency
    • 618052ac - Add Symbols to MakeFile
    • 3afb310a - Add LIBGTOP prefix to header guards
    • 210e3dc0 - Change Process_list to GSList
    • cca275c7 - Change Conn_list to GSList
    • 871a0a8e - Replace u_int data types by their GLib alternatives
    • 9fc66c3a - Change Packet_list to GSList
    • 6a2badf2 - Add new headers to the list of introspectables
    • 07349930 - Change the network_stats_entry struct
    • bc62a98a - Add network stats cmd to the daemon
    • 9043f84d - Change flags to enable Daemon for Linux
    • e7b29d7e - Define the libgtop_sysdeps_suid library for Linux
    • 2ade4b58 - Add glibtop_init_p in Linux
    • f75be015 - Change the local_addr field in struct glibtop_socket
    • ee43fcd9 - Add glibtop_open_p function
    • cd6555d8 - Remove the error logs
    • 157ccc06 - Add DBus Interface to get the stats
    • 2779c87a - Change the output GVariant
    • 12200d78 - Add capture status function
    • 2f33f6f9 - Add capture initializer function to DBus
    • 0f55aaa9 - Change Daemon settings for Linux
    • fa32655d - Move the DBus example to examples dir
    • c5ff9227 - Add packet capture init function to stats
    • 15ba350a - Add GPtrArray for the dbus_stats
    • 79e2eec1 - Add parameter in the get_stats_instance invocation
    • a28097ef - Change the condition for keeping the capture active
    • 8901b39f - Rename the toggle_capture_status function
    • 50e7f227 - WIP: Add the dictionary for DBus Messages
    • 6b8b216d - Remove proc_name from various structs
    • e399c2c0 - Fix the issue in dictionary in GVariants
    • 638ba82e - Add g_timeout_add in the dbus interface
    • a2a56534 - Fix timeout issue in DBus interface
    • a9501139 - Add check to stop the packet capture
    • 72bffccf - Fix segfault in GetStats
    • 20df42f6 - Add config files for DBus
    • 55559e8f - Add set and reset functions to dbus-interface
    • 90fb9e3e - Discard values ~0.00 in the network stats
    • adaad6be - Activate the packet capture in the network test example
    • eeba585a - Use g_error wherever required
    • 5a6817a1 - Fix warnings during compilation
    • 3de94ded - Return network stats as kb
    • 11334ceb - Remove functions for bytes to kb conversion
    • d1c8b999 - Add PCAP_LIBS variable to configure.ac
    • cfc41c86 - API should return bytes transferred
    • 38a74f76 - Remove printf statements
    • 464f62af - Prefix glibtop to public API
    • ba1d787d - Minor changes in some func defintions
    • 3bf1e71d - Use free function to free the DBus stats
    • 764105e2 - Rename glibtop_init_stats to glibgtop_init_netstats
    • 5acc0c5c - Use time_t wherever required
    • c64a8159 - Replace ptr by array
    • 896595d7 - Keep double in DBus Interface

    Compare with previous version

    Apr 01, 2018

    added 94 commits

    • 0d6a8a3e...35a0ba8e - 4 commits from branch GNOME:master
    • 9f99a620 - Add directory traversal of /proc
    • 7da5e029 - Add file parsing for /proc/net/tcp
    • 7ef01db5 - Add parsing of network connections from /proc/net/ files
    • 294204a4 - Add test for netsocket.c
    • cbe605bf - Add hashTable to store inode and pid
    • 6e672dd7 - Add test for proc_inode_parse.c
    • c312da68 - Add glib version of dir traversal
    • 6a1e9337 - dev_handles : Open pcap handles for network interfaces
    • 04da947f - Test for checking the opened pcap handles for network devices
    • d6351f17 - Change the dir name approach to GFile
    • 62f0013c - GFile changes in the args
    • 9d236bb3 - Add GError for error handling
    • dfe21cb2 - Switched to GINT_TO_POINTER
    • 1bb526d4 - Replace malloc with g_slice_new
    • 5dd7deb2 - Minor changes in test file
    • c4cb26d5 - Fix warning
    • 707cb7ad - coding style fixes
    • 1153f96d - Add Interface's local address
    • 77e1876f - Add local address to interfaces
    • 5a3431d6 - Add functions for manipulating packets
    • 0967cbf5 - Add connections details to keep track of relevant packets
    • 5e6947d7 - Add process details to track corresponding connections
    • b47de8ef - Add callback for tcp
    • 30a40f27 - Add more packet functions
    • a82d6754 - Add hash table for socket details and inode
    • 360a0ee4 - Add packet processing functions
    • 3ff43963 - Modifications in packet function prototypes
    • 99eb516b - Fix struct member name issues
    • 5fb75c27 - Add structs for network stats output
    • 744c3afe - Add main testing file
    • ca2a700a - Redefinition issues fixed
    • 7c0e3de4 - Add packet hash to packet struct
    • b7b4406a - dev_handles.c : Modify packet processing functions
    • de344641 - dev_handles.h: Add definition of packet headers
    • 4f246f4b - connection: Modify the connection matching functions
    • a7b8c23b - This commit has to be broken down into patches
    • 54fe9773 - Separate the headers and tests
    • b93f6157 - add missing files to Makefile
    • 6bdb6b18 - Add Gio dependency
    • 618052ac - Add Symbols to MakeFile
    • 3afb310a - Add LIBGTOP prefix to header guards
    • 210e3dc0 - Change Process_list to GSList
    • cca275c7 - Change Conn_list to GSList
    • 871a0a8e - Replace u_int data types by their GLib alternatives
    • 9fc66c3a - Change Packet_list to GSList
    • 6a2badf2 - Add new headers to the list of introspectables
    • 07349930 - Change the network_stats_entry struct
    • bc62a98a - Add network stats cmd to the daemon
    • 9043f84d - Change flags to enable Daemon for Linux
    • e7b29d7e - Define the libgtop_sysdeps_suid library for Linux
    • 2ade4b58 - Add glibtop_init_p in Linux
    • f75be015 - Change the local_addr field in struct glibtop_socket
    • ee43fcd9 - Add glibtop_open_p function
    • cd6555d8 - Remove the error logs
    • 157ccc06 - Add DBus Interface to get the stats
    • 2779c87a - Change the output GVariant
    • 12200d78 - Add capture status function
    • 2f33f6f9 - Add capture initializer function to DBus
    • 0f55aaa9 - Change Daemon settings for Linux
    • fa32655d - Move the DBus example to examples dir
    • c5ff9227 - Add packet capture init function to stats
    • 15ba350a - Add GPtrArray for the dbus_stats
    • 79e2eec1 - Add parameter in the get_stats_instance invocation
    • a28097ef - Change the condition for keeping the capture active
    • 8901b39f - Rename the toggle_capture_status function
    • 50e7f227 - WIP: Add the dictionary for DBus Messages
    • 6b8b216d - Remove proc_name from various structs
    • e399c2c0 - Fix the issue in dictionary in GVariants
    • 638ba82e - Add g_timeout_add in the dbus interface
    • a2a56534 - Fix timeout issue in DBus interface
    • a9501139 - Add check to stop the packet capture
    • 72bffccf - Fix segfault in GetStats
    • 20df42f6 - Add config files for DBus
    • 55559e8f - Add set and reset functions to dbus-interface
    • 90fb9e3e - Discard values ~0.00 in the network stats
    • adaad6be - Activate the packet capture in the network test example
    • eeba585a - Use g_error wherever required
    • 5a6817a1 - Fix warnings during compilation
    • 3de94ded - Return network stats as kb
    • 11334ceb - Remove functions for bytes to kb conversion
    • d1c8b999 - Add PCAP_LIBS variable to configure.ac
    • cfc41c86 - API should return bytes transferred
    • 38a74f76 - Remove printf statements
    • 464f62af - Prefix glibtop to public API
    • ba1d787d - Minor changes in some func defintions
    • 3bf1e71d - Use free function to free the DBus stats
    • 764105e2 - Rename glibtop_init_stats to glibgtop_init_netstats
    • 5acc0c5c - Use time_t wherever required
    • c64a8159 - Replace ptr by array
    • 896595d7 - Keep double in DBus Interface

    Compare with previous version

    added 94 commits <ul><li>0d6a8a3e...35a0ba8e - 4 commits from branch <code>GNOME:master</code></li><li>9f99a620 - Add directory traversal of /proc</li><li>7da5e029 - Add file parsing for /proc/net/tcp</li><li>7ef01db5 - Add parsing of network connections from /proc/net/ files</li><li>294204a4 - Add test for netsocket.c</li><li>cbe605bf - Add hashTable to store inode and pid</li><li>6e672dd7 - Add test for proc_inode_parse.c</li><li>c312da68 - Add glib version of dir traversal</li><li>6a1e9337 - dev_handles : Open pcap handles for network interfaces</li><li>04da947f - Test for checking the opened pcap handles for network devices</li><li>d6351f17 - Change the dir name approach to GFile</li><li>62f0013c - GFile changes in the args</li><li>9d236bb3 - Add GError for error handling</li><li>dfe21cb2 - Switched to GINT_TO_POINTER</li><li>1bb526d4 - Replace malloc with g_slice_new</li><li>5dd7deb2 - Minor changes in test file</li><li>c4cb26d5 - Fix warning</li><li>707cb7ad - coding style fixes</li><li>1153f96d - Add Interface&#39;s local address</li><li>77e1876f - Add local address to interfaces</li><li>5a3431d6 - Add functions for manipulating packets</li><li>0967cbf5 - Add connections details to keep track of relevant packets</li><li>5e6947d7 - Add process details to track corresponding connections</li><li>b47de8ef - Add callback for tcp</li><li>30a40f27 - Add more packet functions</li><li>a82d6754 - Add hash table for socket details and inode</li><li>360a0ee4 - Add packet processing functions</li><li>3ff43963 - Modifications in packet function prototypes</li><li>99eb516b - Fix struct member name issues</li><li>5fb75c27 - Add structs for network stats output</li><li>744c3afe - Add main testing file</li><li>ca2a700a - Redefinition issues fixed</li><li>7c0e3de4 - Add packet hash to packet struct</li><li>b7b4406a - dev_handles.c : Modify packet processing functions</li><li>de344641 - dev_handles.h: Add definition of packet headers</li><li>4f246f4b - connection: Modify the connection matching functions</li><li>a7b8c23b - This commit has to be broken down into patches</li><li>54fe9773 - Separate the headers and tests</li><li>b93f6157 - add missing files to Makefile</li><li>6bdb6b18 - Add Gio dependency</li><li>618052ac - Add Symbols to MakeFile</li><li>3afb310a - Add LIBGTOP prefix to header guards</li><li>210e3dc0 - Change Process_list to GSList</li><li>cca275c7 - Change Conn_list to GSList</li><li>871a0a8e - Replace u_int data types by their GLib alternatives</li><li>9fc66c3a - Change Packet_list to GSList</li><li>6a2badf2 - Add new headers to the list of introspectables</li><li>07349930 - Change the network_stats_entry struct</li><li>bc62a98a - Add network stats cmd to the daemon</li><li>9043f84d - Change flags to enable Daemon for Linux</li><li>e7b29d7e - Define the libgtop_sysdeps_suid library for Linux</li><li>2ade4b58 - Add glibtop_init_p in Linux</li><li>f75be015 - Change the local_addr field in struct glibtop_socket</li><li>ee43fcd9 - Add glibtop_open_p function</li><li>cd6555d8 - Remove the error logs</li><li>157ccc06 - Add DBus Interface to get the stats</li><li>2779c87a - Change the output GVariant</li><li>12200d78 - Add capture status function</li><li>2f33f6f9 - Add capture initializer function to DBus</li><li>0f55aaa9 - Change Daemon settings for Linux</li><li>fa32655d - Move the DBus example to examples dir</li><li>c5ff9227 - Add packet capture init function to stats</li><li>15ba350a - Add GPtrArray for the dbus_stats</li><li>79e2eec1 - Add parameter in the get_stats_instance invocation</li><li>a28097ef - Change the condition for keeping the capture active</li><li>8901b39f - Rename the toggle_capture_status function</li><li>50e7f227 - WIP: Add the dictionary for DBus Messages</li><li>6b8b216d - Remove proc_name from various structs</li><li>e399c2c0 - Fix the issue in dictionary in GVariants</li><li>638ba82e - Add g_timeout_add in the dbus interface</li><li>a2a56534 - Fix timeout issue in DBus interface</li><li>a9501139 - Add check to stop the packet capture</li><li>72bffccf - Fix segfault in GetStats</li><li>20df42f6 - Add config files for DBus</li><li>55559e8f - Add set and reset functions to dbus-interface</li><li>90fb9e3e - Discard values ~0.00 in the network stats</li><li>adaad6be - Activate the packet capture in the network test example</li><li>eeba585a - Use g_error wherever required</li><li>5a6817a1 - Fix warnings during compilation</li><li>3de94ded - Return network stats as kb</li><li>11334ceb - Remove functions for bytes to kb conversion</li><li>d1c8b999 - Add PCAP_LIBS variable to configure.ac</li><li>cfc41c86 - API should return bytes transferred</li><li>38a74f76 - Remove printf statements</li><li>464f62af - Prefix glibtop to public API</li><li>ba1d787d - Minor changes in some func defintions</li><li>3bf1e71d - Use free function to free the DBus stats</li><li>764105e2 - Rename glibtop_init_stats to glibgtop_init_netstats</li><li>5acc0c5c - Use time_t wherever required</li><li>c64a8159 - Replace ptr by array</li><li>896595d7 - Keep double in DBus Interface</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=5110&start_sha=0d6a8a3ec52f277810371cbeb0de0f7c982ff6bc)
    Toggle commit list
  • Karuna Grewal @antares

    added 2 commits

    • 9e29402e - Delete config.rpath
    • 1b047597 - Delete the stale packets

    Compare with previous version

    Apr 08, 2018

    added 2 commits

    • 9e29402e - Delete config.rpath
    • 1b047597 - Delete the stale packets

    Compare with previous version

    added 2 commits <ul><li>9e29402e - Delete config.rpath</li><li>1b047597 - Delete the stale packets</li></ul> [Compare with previous version](https://gitlab.gnome.org/GNOME/libgtop/merge_requests/1/diffs?diff_id=5432&start_sha=896595d71a8eb676697903015e7734db8813c349)
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: GNOME/libgtop!1