1. 12 Jan, 2022 1 commit
    • pv's avatar
      mixer-control: fix gvc_mixer_card_set_profiles API usage · 8e7a5a4c
      pv authored
      In update_card, profile_list is incorrectly used also after its
      ownership is transferred to the GvcMixerCard.  In practice, this causes
      e.g. some profiles to go missing due to the list head being clobbered.
      
      Fix this by calling gvc_mixer_card_set_profiles only after profiles_list
      is no longer used for any other purpose.
      8e7a5a4c
  2. 15 Mar, 2021 1 commit
    • Jonas Ådahl's avatar
      mixer-control: Rely on stream-id on device for cardless devices · c5ab6037
      Jonas Ådahl authored
      Some devices don't have a card to match against, (e.g. network sinks),
      which would make 'match_stream_with_devices()' get confused and log
      warnings about missing card devices when trying to match streams with
      devices.
      
      Avoid this by marking a stream as 'in-possession' if there was already a
      device with the stream ID set to it.
      
      This fixes warning like
      
         (gnome-shell:3521215): Gvc-CRITICAL **: 10:57:07.155: gvc_mixer_card_get_index: assertion 'GVC_IS_MIXER_CARD (card)' failed
      c5ab6037
  3. 17 Sep, 2020 2 commits
    • Jaroslav Kysela's avatar
      mixer-control: do not use port name string to select the headset ports · 7a621180
      Jaroslav Kysela authored and Bastien Nocera's avatar Bastien Nocera committed
      It is a bad idea to use the variable port name to check the port
      type. Use only the new port type and availability group string
      for the decision.
      
      Also, select the ports by priority, if there multiple ports
      with the similar type.
      7a621180
    • Hui Wang's avatar
      mixer-control: consolidate port finding and setting with/without ucm · 960e01d9
      Hui Wang authored and Bastien Nocera's avatar Bastien Nocera committed
      Recently Intel added a new audio driver in the Linux kernel, it is
      called sof driver. This driver is needed on the laptops which
      connects the digital mic to the PCH instead of the codec. To make the
      sof driver work with pulseaudio, the ucm is mandatory.
      
      With the ucm, the multi-function audio jack has different port names
      in the pulseaudio from the one without ucm, these are the port names
      with the ucm:
      [In] Mic1: Digital Microphone
      [In] Mic2: Headphones Stereo Microphone
      [In] Headset: Headset Mono Microphone
      [Out] Headphones: Headphones
      [Out] Speaker: Speaker
      
      To make the audio device selection work on the machines using the ucm,
      the pulseaudio introduces a change to add 2 new members in the device
      port structure from the PA_PROTOCOL_VERSION=34, with these 2 members'
      help, we could consolidate the port finding and setting for both with
      ucm and without ucm.
      
      And this patch maintains the backward compatibility with the
      PA_PROTOCOL_VERSION < 34.
      960e01d9
  4. 09 Apr, 2020 6 commits
  5. 23 Nov, 2019 2 commits
  6. 22 Nov, 2019 2 commits
  7. 14 Jun, 2019 1 commit
  8. 17 Mar, 2019 2 commits
  9. 27 Feb, 2019 1 commit
    • Bastien Nocera's avatar
      ci: Add CI · 0e1b4bda
      Bastien Nocera authored
      This just builds the "what-did-you-plugin" test application, but it's
      good enough to catch the worst failures.
      0e1b4bda
  10. 16 Dec, 2018 1 commit
  11. 07 Dec, 2018 1 commit
  12. 10 Sep, 2018 2 commits
    • Bastien Nocera's avatar
      Merge branch 'wip/muktupavels/warnings' into 'master' · 7de39e76
      Bastien Nocera authored
      Fix build warnings
      
      See merge request GNOME/libgnome-volume-control!2
      7de39e76
    • Alberts Muktupāvels's avatar
      fix cast-function-type warnings · 4e9205d6
      Alberts Muktupāvels authored
      gvc-mixer-card.c: In function ‘gvc_mixer_card_finalize’:
      gvc-mixer-card.c:571:53: warning: cast between incompatible function types from ‘void (*)(GvcMixerCardProfile *)’ {aka ‘void (*)(struct <anonymous> *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
               g_list_foreach (mixer_card->priv->profiles, (GFunc) free_profile, NULL);
      
      gvc-mixer-stream.c: In function ‘gvc_mixer_stream_finalize’:
      gvc-mixer-stream.c:1044:52: warning: cast between incompatible function types from ‘void (*)(GvcMixerStreamPort *)’ {aka ‘void (*)(struct <anonymous> *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
               g_list_foreach (mixer_stream->priv->ports, (GFunc) free_port, NULL);
      4e9205d6
  13. 08 Sep, 2018 1 commit
  14. 07 Sep, 2018 2 commits
  15. 20 Aug, 2018 1 commit
  16. 30 Jan, 2018 6 commits
  17. 26 Jan, 2018 1 commit
  18. 06 Dec, 2017 2 commits
  19. 05 Oct, 2017 1 commit
  20. 10 Aug, 2017 1 commit
  21. 22 Jul, 2017 1 commit
    • Florian Müllner's avatar
      build: Don't include c_args in dependency · 3093bdb0
      Florian Müllner authored
      The defines are only relevant for compiling libgvc itself, not for
      any consumers of the library. In fact, setting G_LOG_DOMAIN is
      likely to conflict with the log domain defined by the including
      project ...
      3093bdb0
  22. 19 Jul, 2017 1 commit
  23. 29 May, 2017 1 commit