1. 15 Oct, 2021 1 commit
  2. 17 Mar, 2021 1 commit
  3. 07 Mar, 2021 1 commit
  4. 05 Feb, 2021 1 commit
  5. 23 Oct, 2020 1 commit
  6. 09 Feb, 2020 1 commit
  7. 25 Nov, 2019 1 commit
  8. 05 Oct, 2019 1 commit
  9. 25 Sep, 2019 1 commit
  10. 05 Aug, 2019 1 commit
  11. 01 Apr, 2019 3 commits
  12. 14 Mar, 2019 1 commit
  13. 16 Dec, 2018 3 commits
  14. 11 Feb, 2018 2 commits
  15. 11 Dec, 2017 2 commits
  16. 12 Sep, 2017 1 commit
  17. 21 Mar, 2017 1 commit
  18. 23 Feb, 2017 2 commits
  19. 17 Jan, 2017 1 commit
  20. 14 Dec, 2016 1 commit
  21. 23 Nov, 2016 1 commit
    • Colomban Wendling's avatar
      Fix converting enumerations and flags to arrays · 72671f62
      Colomban Wendling authored and Rico Tzschichholz's avatar Rico Tzschichholz committed
      Enumerations and flags are classed types for Vala, not integers, so
      they don't fall in the `typeof(G) == typeof(int)` kind of tests. This
      leads to using the generic code in which Vala assumes pointer-sized
      elements, which is often not true for enumerations and flags.
      
      Add special case for those to use the `int` converters for enumerations
      and flags.
      
      This is most generally correct, but not always: the compiler will
      likely chose a larger type for a specific enumeration if one of its
      value is larger than `int`.  It would be tempting to use the
      enumeration's class minimum and maximum values to determine the
      appropriate type, but unfortunately the API for this uses int itself,
      so doesn't help.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=774669
      72671f62
  22. 12 Oct, 2016 2 commits
  23. 11 Oct, 2016 1 commit
    • Ole André Vadla Ravnås's avatar
      Fix use-after-frees caused by weak pointer issues · 707456e3
      Ole André Vadla Ravnås authored and Maciej (Matthew) Piechotka's avatar Maciej (Matthew) Piechotka committed
      Same issue in HashMap and TreeMap:
      
      ```
      ==3251==ERROR: AddressSanitizer: heap-use-after-free on address 0x604000000870 at pc 0x000108be666b bp 0x7fff571e62b0 sp 0x7fff571e62a8
      WRITE of size 8 at 0x604000000870 thread T0
          #0 0x108be666a in g_nullify_pointer gutils.c:2051
          #1 0x108b8c906 in weak_refs_notify gobject.c:2638
          #2 0x108bbb17c in g_data_set_internal gdataset.c:407
          #3 0x108b887db in g_object_unref gobject.c:3148
          #4 0x108a4b0ec in map_tests_test_entry_weak_pointer_lifetime testmap.c:1358
      
      0x604000000870 is located 32 bytes inside of 40-byte region [0x604000000850,0x604000000878)
      freed by thread T0 here:
          #0 0x1090f0e29 in wrap_free (libclang_rt.asan_osx_dynamic.dylib+0x4ae29)
          #1 0x108ace566 in gee_hash_map_unset_helper hashmap.c:1692
          #2 0x108acc534 in gee_hash_map_real_unset hashmap.c:1520
          #3 0x108a4b0df in map_tests_test_entry_weak_pointer_lifetime testmap.c:1357
      
      previously allocated by thread T0 here:
          #0 0x1090f0c60 in wrap_malloc (libclang_rt.asan_osx_dynamic.dylib+0x4ac60)
          #1 0x108bce848 in g_malloc gmem.c:95
          #2 0x108bd6585 in g_slice_alloc gslice.c:1012
          #3 0x108bd6bee in g_slice_alloc0 gslice.c:1038
          #4 0x108acdc27 in gee_hash_map_node_new hashmap.c:2084
          #5 0x108acc277 in gee_hash_map_real_set hashmap.c:1494
          #6 0x108a4b032 in map_tests_test_entry_weak_pointer_lifetime testmap.c:1311
      
      https://bugzilla.gnome.org/show_bug.cgi?id=772418
      707456e3
  24. 29 Sep, 2016 2 commits
  25. 27 Sep, 2016 2 commits
  26. 14 Sep, 2016 1 commit
  27. 15 Jul, 2016 2 commits
  28. 09 Jun, 2016 1 commit
  29. 20 Jan, 2016 1 commit