Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libgda
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 67
    • Issues 67
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • libgda
  • Merge requests
  • !73

CI: Fixing PostgreSQL service

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Pavlo Solntsev requested to merge pavlosun/libgda:wip/postgres into master Dec 18, 2018
  • Overview 0
  • Commits 2
  • Pipelines 2
  • Changes 4
  • CI file was modified to remove DB definition
  • Fixing access of potentially NULL object with a function that doesn't accept this.

Some comments here. We don't need to provide DB name in the CI file. The test will create DB by itself. The connection can be tested using psql. I tested and removed from the CI. Variables POSTGERS_USER and POSTGRES_PASSWORD works for non postgres images. My previous statement about that was wrong. The check_postgres.c test is incomplete and buggy. We need another test where all DDL operation will be tested. I start working on this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/postgres