- 26 Jun, 2017 7 commits
-
-
Bastien Nocera authoredDACP (_touch-able._tcp) and DAAP (_daap._tcp) on macOS use the same default port, 3689, to advertise both services. A single server likely implements both protocols, and internally routes the requests. This is not the case with the libdmapsharing, with each protocol getting its own server running on the port (both in IPv4 and IPv6). When an application like rhythmbox would launch both possible types of share, the first one would go without a hitch, the second one would only be accessible via IPv6 on a different port. This doesn't make much difference as: - which port is used is ultimately unimportant as the port is advertised in mDNS - the port already being used might mean we're sharing music with another application on the same machine and none of those are programming or configuration errors. Ideally, services with the same port would share a single SoupServer, but until then, this change will not make any difference in terms of interoperability. https://bugzilla.gnome.org/show_bug.cgi?id=766723Signed-off-by:
W. Michael Petullo <mike@flyn.org>
-
Bastien Nocera authored
Use the retval of the API, instead of assuming that the API will always set the error (it'd be a bug, but at least we'd go down the correct branch). https://bugzilla.gnome.org/show_bug.cgi?id=766723Signed-off-by:
-
Bastien Nocera authored
Neither are used, so no need to have them in code. https://bugzilla.gnome.org/show_bug.cgi?id=784222Signed-off-by:
-
Bastien Nocera authored
The dispose call wasn't chaining up to the parent. Removing the empty custom implementation will make GObject call the parent directly. https://bugzilla.gnome.org/show_bug.cgi?id=784222Signed-off-by:
-
Bastien Nocera authored
https://bugzilla.gnome.org/show_bug.cgi?id=784221Signed-off-by:
-
Bastien Nocera authored
The generated enums file will live in builddir, not srcdir: libdmapsharing/dmap.h:11:10: fatal error: libdmapsharing/dmap-enums.h: No such file or directory #include <libdmapsharing/dmap-enums.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ https://bugzilla.gnome.org/show_bug.cgi?id=784221Signed-off-by: -
Bastien Nocera authored
As is the default for jhbuild. https://bugzilla.gnome.org/show_bug.cgi?id=784221Signed-off-by:
-
- 05 Jun, 2017 2 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by:
-
- 09 Jan, 2017 1 commit
-
-
W. Michael Petullo authored
Signed-off-by:
-
- 12 Nov, 2016 5 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
https://bugzilla.gnome.org/show_bug.cgi?id=773400Signed-off-by:
-
W. Michael Petullo authored
https://bugzilla.gnome.org/show_bug.cgi?id=773480Signed-off-by:
-
Bastien Nocera authored
GLib never fails to allocate memory. At least not in a way that applications can do anything about it. "If any call to allocate memory fails, the application is terminated. This also means that there is no need to check if the call succeeded." https://bugzilla.gnome.org/show_bug.cgi?id=755210Signed-off-by:
-
- 16 Sep, 2016 1 commit
-
-
W. Michael Petullo authored
Signed-off-by:
-
- 01 Aug, 2016 2 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by:
-
- 20 May, 2016 2 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
Bastien Nocera authored
On a 64-bit system, with gcc 6.0: format ‘%lld’ expects argument of type ‘long long int’, but argument 4 has type ‘gint64 {aka long int}’ https://bugzilla.gnome.org/show_bug.cgi?id=766721Signed-off-by:
-
- 20 Feb, 2016 1 commit
-
-
W. Michael Petullo authored
Signed-off-by:
-
- 18 Feb, 2016 3 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
See also https://bugzilla.gnome.org/show_bug.cgi?id=762129. Signed-off-by:
-
W. Michael Petullo authored
Signed-off-by:
-
- 08 Feb, 2016 5 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
Sam Thursfield authored
The SoupSession class now handles async and sync communications. Since we already call soup_session_queue_message() (which sends the message asynchronously) there are no other changes needed.
-
Sam Thursfield authored
A SoupURI is considered invalid if the path is NULL. Set the path of the base URI to an empty string, instead. This fixes a bunch of these warnings: (rhythmbox:32182): libsoup-WARNING **: (soup-uri.c:248):soup_uri_new_with_base: runtime check failed: (SOUP_URI_IS_VALID (base)) -
Sam Thursfield authored
This old API is deprecated, and with the new API we can report the actual error message if we hit an error.
-
Sam Thursfield authored
2.48 was released in September 2014, so should be in most distros by now. https://bugzilla.gnome.org/show_bug.cgi?id=761690
-
- 26 Oct, 2015 1 commit
-
-
W. Michael Petullo authored
Signed-off-by:
-
- 22 Oct, 2015 2 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by:
-
- 19 Oct, 2015 2 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by:
-
- 18 Oct, 2015 2 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by:
-
- 01 Jun, 2015 4 commits
-
-
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by: -
W. Michael Petullo authored
Signed-off-by:
-
