Commit f8923d27 authored by W. Michael Petullo's avatar W. Michael Petullo
Browse files

Small changes after reviewing code


Signed-off-by: W. Michael Petullo's avatarW. Michael Petullo <mike@flyn.org>
parent e37b7159
Fix DNSSD on Mac OS X
Audit remaining GSoC patch:
--- dmap-db.c
--- dmap-share.c
--- dacp-player.c
--- dacp-player.h
--- dacp-share.c
--- dacp-share.h
Does, e.g., handle_server_info need user_data parameter?
Complete DACP code and push Rhythmbox patch
Reduce the memory usage while building response to media list query.
......
......@@ -44,7 +44,7 @@ daap_record_init (DAAPRecordInterface *iface)
"Unknown",
G_PARAM_READWRITE));
//FIXME: This is actually an enum
/* FIXME: This is actually an enum */
g_object_interface_install_property (iface,
g_param_spec_int ("mediakind",
"Media kind",
......
......@@ -809,7 +809,7 @@ databases_browse_xxx (DMAPShare *share,
node = dmap_structure_add (abro, category_cc);
values = g_hash_table_get_keys (category_items);
if (g_hash_table_lookup (query, "include-sort-headers")) {
if (values && g_hash_table_lookup (query, "include-sort-headers")) {
g_debug ("Sorting...");
values = g_list_sort (values, (GCompareFunc) g_ascii_strcasecmp);
}
......
......@@ -373,7 +373,7 @@ resolve_cb (AvahiServiceResolver *service_resolver,
{
if (event == AVAHI_RESOLVER_FOUND) {
gchar *name = NULL;
gchar *pair = NULL;
gchar *pair = NULL; /* FIXME: extract DACP-specific items into sub-class? See also howl code. */
gchar host[AVAHI_ADDRESS_STR_MAX];
gboolean pp = FALSE;
DMAPMdnsBrowserService *service;
......
......@@ -389,7 +389,6 @@ dmap_structure_parse_container_buffer (GNode *parent,
cc = dmap_content_code_read_from_buffer ((const gchar*)&(buf[l]));
if (cc == DMAP_CC_INVALID) {
//g_debug ("Invalid/Unknown content_code recieved\n");
return;
}
l += 4;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment