Commit ebcff4a2 authored by Bastien Nocera's avatar Bastien Nocera Committed by W. Michael Petullo

dmap-share: Don't throw warnings during normal operations

DACP (_touch-able._tcp) and DAAP (_daap._tcp) on macOS use the same
default port, 3689, to advertise both services. A single server likely
implements both protocols, and internally routes the requests.

This is not the case with the libdmapsharing, with each protocol getting
its own server running on the port (both in IPv4 and IPv6). When an
application like rhythmbox would launch both possible types of share,
the first one would go without a hitch, the second one would only be
accessible via IPv6 on a different port.

This doesn't make much difference as:
- which port is used is ultimately unimportant as the port is
  advertised in mDNS
- the port already being used might mean we're sharing music with
  another application on the same machine
and none of those are programming or configuration errors.

Ideally, services with the same port would share a single SoupServer,
but until then, this change will not make any difference in terms of
interoperability.

https://bugzilla.gnome.org/show_bug.cgi?id=766723Signed-off-by: W. Michael Petullo's avatarW. Michael Petullo <mike@flyn.org>
parent f92c9697
......@@ -288,8 +288,8 @@ _dmap_share_server_start (DMAPShare *share)
ret = soup_server_listen_all (share->priv->server, desired_port, 0, &error);
if (ret == FALSE) {
g_warning ("Unable to start music sharing server on port %d: %s. "
"Trying any open IPv6 port", desired_port, error->message);
g_debug ("Unable to start music sharing server on port %d: %s. "
"Trying any open IPv6 port", desired_port, error->message);
g_clear_error (&error);
ret = soup_server_listen_all (share->priv->server, SOUP_ADDRESS_ANY_PORT,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment