From 5c0d38f8d2949efbbc1c6fd43e80d806ed135040 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ant=C3=B3nio=20Fernandes?= Date: Sun, 27 Aug 2023 22:11:55 +0000 Subject: [PATCH 1/2] header-bar: Advise against setting :show-back-button to FALSE Provide a more nuanced recommendation and an potential use case. --- src/adw-header-bar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/adw-header-bar.c b/src/adw-header-bar.c index 1ac821396..e8f2395f8 100644 --- a/src/adw-header-bar.c +++ b/src/adw-header-bar.c @@ -54,9 +54,9 @@ * When used together with [class@NavigationView] or [class@NavigationSplitView], * it will also display a back button that can be used to go back to the previous * page. The button also has a context menu, allowing to pop multiple pages at - * once, potentially across multiple navigation views. Set + * once, potentially across multiple navigation views. In rare scenarios, set * [property@HeaderBar:show-back-button] to `FALSE` to disable the back button - * if it's unwanted. + * if unwanted (e.g. in an extra header bar on the same page). * * ## Split View Integration * @@ -688,7 +688,7 @@ adw_header_bar_class_init (AdwHeaderBarClass *class) * Whether the header bar can show the back button. * * The back button will never be shown unless the header bar is placed inside an - * [class@NavigationView]. + * [class@NavigationView]. Usually, there is no reason to set this to `FALSE`. * * Since: 1.4 */ @@ -1106,7 +1106,7 @@ adw_header_bar_get_show_back_button (AdwHeaderBar *self) * Sets whether @self can show the back button. * * The back button will never be shown unless the header bar is placed inside an - * [class@NavigationView]. + * [class@NavigationView]. Usually, there is no reason to set it to `FALSE`. * * Since: 1.4 */ -- GitLab From 4b19356454abcfbeea86dce97913e3410fa157bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ant=C3=B3nio=20Fernandes?= Date: Sun, 27 Aug 2023 22:15:01 +0000 Subject: [PATCH 2/2] Apply 1 suggestion(s) to 1 file(s) --- src/adw-header-bar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/adw-header-bar.c b/src/adw-header-bar.c index e8f2395f8..052ce7599 100644 --- a/src/adw-header-bar.c +++ b/src/adw-header-bar.c @@ -56,7 +56,7 @@ * page. The button also has a context menu, allowing to pop multiple pages at * once, potentially across multiple navigation views. In rare scenarios, set * [property@HeaderBar:show-back-button] to `FALSE` to disable the back button - * if unwanted (e.g. in an extra header bar on the same page). + * if it's unwanted (e.g. in an extra header bar on the same page). * * ## Split View Integration * -- GitLab