AdwDialog: Window doesn't get focus when "Save Changes?" dialog is opened
Example scenario, with the old modal dialogs:
- Open Text Editor, type some stuff without saving
- Go to the overview, try to close the window using the close button
- The window opens a modal "Save Changes?" dialog, and you automatically go back to the app from the overview
- While the dialog is open, the window doesn't have a close button in the overview
With AdwDialog:
- Open Text Editor, type some stuff without saving
- Go to the overview, try to close the window using the close button
- The window opens a modal "Save Changes?" dialog, but you're still in the overview so it's not very noticeable
- While the dialog is open, the window still has a a close button in the overview. If you click this close button it will close the "Save Changes?" dialog
Screencast_from_2024-02-05_23-12-49
Behavior-wise we probably want the old behavior of going back to the session when the dialog opens, and not having a close button while it's open in the overview. Not sure how that's possible technically though, according to @verdre the way Shell detects this atm is that the window opens a modal dialog instead of closing when you hit the close button.
Kudos to @sonny for finding this :D
Edited by Tobias Bernard