3.36.4: build fails
vala 0.48.8.
[2/47] valac -C --pkg gio-2.0 --color=always --directory src/iagno-perfs-tests-generator.p --basedir ../src --enable-experimental-non-null ../src/vapi/config.vapi ../src/perfs-tests-generator.vala ../src/computer-player.vala ../src/computer-reversi.vala ../src/game.vala ../src/player.vala
FAILED: src/iagno-perfs-tests-generator.p/perfs-tests-generator.c src/iagno-perfs-tests-generator.p/computer-player.c src/iagno-perfs-tests-generator.p/computer-reversi.c src/iagno-perfs-tests-generator.p/game.c src/iagno-perfs-tests-generator.p/player.c
valac -C --pkg gio-2.0 --color=always --directory src/iagno-perfs-tests-generator.p --basedir ../src --enable-experimental-non-null ../src/vapi/config.vapi ../src/perfs-tests-generator.vala ../src/computer-player.vala ../src/computer-reversi.vala ../src/game.vala ../src/player.vala
../src/game.vala:46.5-46.28: warning: accessibility of struct fields can only be `public`
private Player [,] tiles;
^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:47.5-47.44: warning: accessibility of struct fields can only be `public`
private unowned uint8 [,] neighbor_tiles;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:303.5-303.25: warning: accessibility of struct fields can only be `public`
private uint8 x_saved;
^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:304.5-304.25: warning: accessibility of struct fields can only be `public`
private uint8 y_saved;
^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:462.5-462.37: warning: accessibility of struct fields can only be `public`
private uint8 [,] empty_neighbors;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/perfs-tests-generator.vala:45.16-45.20: error: The name `Posix' does not exist in the context of `PerfsTestsGenerator.handle_local_options'
return Posix.EXIT_SUCCESS;
^^^^^
Compilation failed: 1 error(s), 5 warning(s)
[3/47] valac -C --pkg gio-2.0 --color=always --directory src/iagno-tests.p --basedir ../src --enable-experimental-non-null ../src/test-iagno.vala ../src/computer-player.vala ../src/computer-reversi.vala ../src/game.vala ../src/player.vala
../src/game.vala:46.5-46.28: warning: accessibility of struct fields can only be `public`
private Player [,] tiles;
^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:47.5-47.44: warning: accessibility of struct fields can only be `public`
private unowned uint8 [,] neighbor_tiles;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:303.5-303.25: warning: accessibility of struct fields can only be `public`
private uint8 x_saved;
^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:304.5-304.25: warning: accessibility of struct fields can only be `public`
private uint8 y_saved;
^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:462.5-462.37: warning: accessibility of struct fields can only be `public`
private uint8 [,] empty_neighbors;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/computer-player.vala:61.5-61.22: warning: method `ComputerPlayer.move' never used
internal void move (double delay_seconds = 0.0)
^^^^^^^^^^^^^^^^^^
../src/computer-player.vala:108.5-108.29: warning: method `ComputerPlayer.cancel_move' never used
internal void cancel_move ()
^^^^^^^^^^^^^^^^^^^^^^^^^
../src/computer-reversi.vala:672.25-672.40: warning: use of possibly unassigned parameter `best_move'
while ((best_move.x == 1 || best_move.x == 6)
^^^^^^^^^^^^^^^^
../src/game.vala:974.5-974.35: warning: method `Game.test_placing_tile' never used
internal bool test_placing_tile (uint8 x, uint8 y, out unowned PossibleMove move)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:974.56-974.84: warning: use of possibly unassigned parameter `move'
internal bool test_placing_tile (uint8 x, uint8 y, out unowned PossibleMove move)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 10 warning(s)
[4/47] /usr/bin/meson --internal msgfmthelper ../data/themes/classic.theme.desktop.in data/themes/classic.theme desktop /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/po
[5/47] /usr/bin/meson --internal msgfmthelper ../data/themes/adwaita.theme.desktop.in data/themes/adwaita.theme desktop /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/po
[6/47] /usr/bin/meson --internal msgfmthelper ../data/themes/sun_and_star.theme.desktop.in data/themes/sun_and_star.theme desktop /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/po
[7/47] /usr/bin/meson --internal msgfmthelper ../data/org.gnome.Reversi.appdata.xml.in data/org.gnome.Reversi.appdata.xml xml /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/po
[8/47] /usr/bin/meson --internal msgfmthelper ../data/themes/high_contrast.theme.desktop.in data/themes/high_contrast.theme desktop /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/po
[9/47] /usr/bin/meson --internal msgfmthelper ../data/org.gnome.Reversi.desktop.in data/org.gnome.Reversi.desktop desktop /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/po
[10/47] valac -C --pkg librsvg-2.0 --pkg posix --pkg gtk+-3.0 --pkg gsound --target-glib ' 2.42.0' --pkg glib-2.0 --pkg gio-2.0 --color=always --directory src/iagno.p --basedir ../src --gresources=../data/iagno.gresource.xml --target-glib 2.44 --vapidir /home/tkloczko/rpmbuild/BUILD/iagno-3.36.4/src/vapi --enable-experimental-non-null ../src/vapi/config.vapi ../src/about-list.vala ../src/adaptative-window.vala ../src/base-headerbar.vala ../src/base-view.vala ../src/base-window.vala ../src/computer-player.vala ../src/computer-reversi.vala ../src/game-actionbar.vala ../src/game-headerbar.vala ../src/game-view.vala ../src/game-window.vala ../src/game.vala ../src/history-button.vala ../src/iagno.vala ../src/new-game-screen.vala ../src/night-light-monitor.vala ../src/notifications-revealer.vala ../src/overlayed-list.vala ../src/player.vala ../src/registry-placeholder.vala ../src/reversi-view.vala ../src/theme-manager.vala
../src/game.vala:46.5-46.28: warning: accessibility of struct fields can only be `public`
private Player [,] tiles;
^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:47.5-47.44: warning: accessibility of struct fields can only be `public`
private unowned uint8 [,] neighbor_tiles;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:303.5-303.25: warning: accessibility of struct fields can only be `public`
private uint8 x_saved;
^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:304.5-304.25: warning: accessibility of struct fields can only be `public`
private uint8 y_saved;
^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:462.5-462.37: warning: accessibility of struct fields can only be `public`
private uint8 [,] empty_neighbors;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game-actionbar.vala:58.5-58.43: warning: `override' not required to implement `abstract' interface method `AdaptativeWidget.set_window_size'
protected override void set_window_size (AdaptativeWidget.WindowSize new_size)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game-actionbar.vala:122.5-122.43: warning: `override' not required to implement `abstract' interface method `AdaptativeWidget.set_window_size'
protected override void set_window_size (AdaptativeWidget.WindowSize new_size)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/reversi-view.vala:316.28-316.31: warning: `Rsvg.DimensionData' has been deprecated since 2.46.
../src/history-button.vala:49.5-49.43: warning: `override' not required to implement `abstract' interface method `AdaptativeWidget.set_window_size'
protected override void set_window_size (AdaptativeWidget.WindowSize new_size)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/history-button.vala:109.28-109.31: warning: `Rsvg.DimensionData' has been deprecated since 2.46.
../src/base-headerbar.vala:305.5-305.37: warning: method `BaseHeaderBar.has_popover' never used
internal virtual bool has_popover ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/computer-player.vala:50.5-50.27: warning: method `ComputerPlayer.move_sync' never used
internal void move_sync (out uint8 x, out uint8 y) // for tests
^^^^^^^^^^^^^^^^^^^^^^^
../src/computer-reversi.vala:672.25-672.40: warning: use of possibly unassigned parameter `best_move'
while ((best_move.x == 1 || best_move.x == 6)
^^^^^^^^^^^^^^^^
../src/game-window.vala:257.5-257.34: warning: method `GameWindow.cannot_undo_more' never used
internal void cannot_undo_more ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/game.vala:974.56-974.84: warning: use of possibly unassigned parameter `move'
internal bool test_placing_tile (uint8 x, uint8 y, out unowned PossibleMove move)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/history-button.vala:82.5-82.37: warning: field `HistoryButton.tileset_pixbuf' never used
private Gdk.Pixbuf tileset_pixbuf;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/new-game-screen.vala:92.5-92.55: warning: method `NewGameScreen.get_size_button_label' never used
internal static inline string get_size_button_label (int size)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:78.5-78.34: warning: method `OverlayedList.add_placeholder' never used
protected void add_placeholder ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:119.5-119.28: warning: method `OverlayedList.next_match' never used
internal bool next_match ()
^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:141.5-141.32: warning: method `OverlayedList.previous_match' never used
internal bool previous_match ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:170.5-170.28: warning: method `OverlayedList.select_all' never used
internal void select_all ()
^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:175.5-175.30: warning: method `OverlayedList.unselect_all' never used
internal void unselect_all ()
^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:180.5-180.38: warning: method `OverlayedList.select_row_for_real' never used
protected void select_row_for_real (ListBoxRow row) // ahem...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:190.5-190.46: warning: method `OverlayedList.get_selected_rows_indices' never used
protected int [] get_selected_rows_indices ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:216.5-216.32: warning: method `OverlayedList.scroll_bottom' never used
protected void scroll_bottom ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/overlayed-list.vala:284.5-284.47: warning: method `OverlayedList.get_selection_state' never used
internal SelectionState get_selection_state ()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 26 warning(s)