SFTP login code should have more cancellation points
Submitted by Christian Neumair
Assigned to gvf..@..e.bugs
When clicking a SFTP bookmark in Nautilus, and quickly afterwards clicking a non-SFTP bookmark, the GIO operation cancelled but the password dialog is displayed. gvfsbackendsftp.c:handle_login() does not seem to handle cancellation. I am not sure whether g_input_stream_read() should be passed the GCancellable when reading from the prompt stream, but at least before asking the password (i.e. after reading from the stream), g_cancellable_is_cancelled () should be called.
Other remote backends potentially suffer from the same issue.
Version: git master