1. 04 Jan, 2021 2 commits
  2. 23 Jun, 2020 1 commit
  3. 18 Mar, 2020 1 commit
  4. 07 Feb, 2020 2 commits
  5. 23 Jul, 2019 2 commits
  6. 28 Jun, 2019 1 commit
  7. 27 Jun, 2019 1 commit
    • Michael Catanzaro's avatar
      Fix gvdb_table_write_contents_async() · d83587b2
      Michael Catanzaro authored
      It worked when I first wrote it, but I broke it during the late stages
      of code review. str is already freed here, so this is a use-after-free
      vulnerability for starters. It also causes the file saved to be always
      empty.
      d83587b2
  8. 24 Jun, 2019 2 commits
  9. 22 Jun, 2019 2 commits
    • Michael Catanzaro's avatar
      Fix -Wsign-compare warning · 18a0d95a
      Michael Catanzaro authored
      [23/236] Compiling C object 'lib/76b5a...isc@sha/contrib_gvdb_gvdb-reader.c.o'.
      ../../../../Projects/epiphany/lib/contrib/gvdb/gvdb-reader.c: In function ‘gvdb_table_get_names’:
      ../../../../Projects/epiphany/lib/contrib/gvdb/gvdb-reader.c:428:27: warning: comparison of integer expressions of different signedness: ‘guint32’ {aka ‘unsigned int’} and ‘gint’ {aka ‘int’} [-Wsign-compare]
        428 |           else if (parent < n_names && names[parent] != NULL)
            |                           ^
      
      To fix this, we have to change n_names to guint, and then also change
      the types of everything it's compared against. This seems to be safe
      since none of these should ever be negative.
      18a0d95a
    • Michael Catanzaro's avatar
      Don't free FileBuilder in serialize function · 0d03b2c6
      Michael Catanzaro authored
      It's confused both myself and Jan-Michael, when reviewing my changes to
      this code. It's weird for the serialize function to take ownership of
      the passed FileBuilder. Don't do that.
      
      We can also add a convenience free function.
      0d03b2c6
  10. 21 Jun, 2019 5 commits
  11. 20 Jun, 2019 1 commit
  12. 25 Feb, 2019 2 commits
  13. 21 Nov, 2018 2 commits
  14. 16 Aug, 2018 4 commits
  15. 13 Aug, 2018 6 commits
  16. 09 Nov, 2012 1 commit
    • Allison Karlitskaya's avatar
      reader: embrace GBytes · 26000821
      Allison Karlitskaya authored
      Drop gvdb_table_new_from_data() and add gvdb_table_new_from_bytes().
      
      Since the underlying backingstore of a GvdbTable is now always
      refcounted, drop the refcounting on GvdbTable itself.
      26000821
  17. 09 Jul, 2012 2 commits
    • Allison Karlitskaya's avatar
      gvdb-reader: drop gvdb_table_walk() · fc37611a
      Allison Karlitskaya authored
      The attempt at the simple method for preventing unbounded recursion
      proved to be insufficient due to the existence of dconf databases in the
      wild that violated the rule (leading to the entire content of the
      database being scrapped).  It also still had the ugly assert for less
      than 64 levels of recursion that could have been hit by a determined
      advisary.
      
      gvdb_table_get_names() allows the dconf-service to do everything it
      needs without the troubles associated with the walk approach.
      fc37611a
    • Allison Karlitskaya's avatar
      gvdb-reader.c: add gvdb_table_get_names() · d9577f10
      Allison Karlitskaya authored
      This function lists off all names that appear within a particular hash.
      d9577f10
  18. 08 Jul, 2012 1 commit
    • Allison Karlitskaya's avatar
      remove a stray variable · 82cbc592
      Allison Karlitskaya authored
      This was used to implement a much more complicated check which was
      dismissed in favour of the simple 'must follow in file' approach.
      82cbc592
  19. 07 Jul, 2012 1 commit
    • Allison Karlitskaya's avatar
      gvdb-reader: robustness improvements · 374cb1bc
      Allison Karlitskaya authored
      Improve the robustness of gvdb-reader in two ways.
      
      First: ensure that the result of gvdb_table_has_value() always agrees
      with gvdb_table_get_value().  Those two could disagree in the case that
      the value was recorded as existing but pointed to an out-of-bounds
      region.
      
      Second: prevent gvdb_table_walk() from getting stuck in finite loops due
      to self-referential directories.
      374cb1bc
  20. 06 Jul, 2012 1 commit