Crashes browsing remote file systems
Because of bugs in commit c925221a, GtkFileChooser will:
- fail to show any files on most remote file systems when there's a file filter, because it only ever checks for
content-type
(which gvfs-implemented filesystems don't export) and notfast-content-type
(which they do) - crash when we ask it to show all files and there are files without a generic icon
Reproducer:
- launch gnome-disks
- insert a USB key
- select "restore disk image..." and browse to a remote share with ISO images
- the ISO images won't be visible
- select "all files" in the file types drop down leads to a crash
#0 0x00007ffff6e6e802 in __strcmp_avx2 () from /lib64/libc.so.6
#1 0x00007ffff7ee1293 in cache_lookup_icon (mime=mime@entry=0x0, header=header@entry=36) at ../../../../Projects/jhbuild/glib/gio/xdgmime/xdgmimecache.c:1083
#2 0x00007ffff7ee217a in __gio_xdg_cache_get_generic_icon (mime=mime@entry=0x0) at ../../../../Projects/jhbuild/glib/gio/xdgmime/xdgmimecache.c:1103
#3 0x00007ffff7ee0c2c in _gio_xdg_get_generic_icon (mime=mime@entry=0x0) at ../../../../Projects/jhbuild/glib/gio/xdgmime/xdgmime.c:1022
#4 0x00007ffff7e7222b in g_content_type_get_generic_icon_name (type=0x0) at ../../../../Projects/jhbuild/glib/gio/gcontenttype.c:618
#5 0x00007ffff76df137 in file_system_model_set () from /lib64/libgtk-3.so.0
#6 0x00007ffff76ecd88 in _gtk_file_system_model_get_value () from /lib64/libgtk-3.so.0
#7 0x00007ffff76ece6e in gtk_file_system_model_get_value () from /lib64/libgtk-3.so.0