Matthiasc/for master

See merge request !1626

The color swatch in the button does not need a
context menu. Turn it off.

The colorbutton contains a button which contains a colorswatch.
We want the focus to go straight to the button, nowhere else,
so mark the swatch as !can-focus.

Adapt tests to match.

Add GtkScrollbarAccessible

See merge request !1623

Somehow the scrollbar accessible manages to call
gtk_scrollbar_get_adjustment when priv->range is NULL.
Survive taht.

Shortcut action parse

See merge request !1625

This is so we can test this code. While doing it
I also fixed the missing else that was caused it
not to work.

When GtkScrollbar stopped being a GtkRange,
GtkRangeAccessible stopped working for scrollbars.

Update a11y tests to match.

imwayland: Clamp the surrounding string end correctly

Closes #2565

See merge request !1621

Focus test

See merge request !1622

In the paths where len > MAX_LEN and cursor/anchor are separated by
at least MAX_LEN from text edges, we were clamping the right end of
the surrounding string at MAX_LEN. Oops.

This end anchor may go as far as the string length, although just
up to len - MAX_LEN in real terms (due to the condition above that
caches cursor/anchor positions being near enough the text end).

Closes: #2565

(cherry-picked from commit d7fb15c8)

It is hard to avoid widgets with the same name in a
large ui file - try harder to record a full focus chain
before decide that we've wrapped, by including the widget
address in the comparison. Note that we don't include
the addresses in the generated output, since that would
make expected output vary from run to run.

Annotation fixes

See merge request !1616

gdk: Move GdkGrabStatus and GdkGrabOwnership decl.

See merge request !1615

Match the arguments name in the declaration and the definition, and make
sure we have the proper transfer annotations.

With the removal of `gdk_seat_grab` we do not need to keep the
definitions of `GdkGrabStatus` and `GdkGrabOwnership` public.

Move those definitions to become internal only.

Matthiasc/for master

See merge request !1611

Clarify a point that took me a few hours to fully track
down, so lets preserve what I found for the next poor
sould coming this way.

Entries and menubuttons are no longer focusable themselves,
they have focusable children. Since we don't have accessible
objects for those, transfer the focus-related state (focusable
and focused) from the children to the main accessible object.

We don't get a focus-out on the event controller, when
the surface is losing keyboard focus, since we are not
moving our focus to some other widget, so we are never
unsetting the mnemonics-visible property. Do that in
response to surface state changes instead.

gdk/wayland: Clear modifiers when we lose keyboard focus

Closes #2112

See merge request !1610

When we `Alt+Tab` away from a GTK application, it loses keyboard focus.
If we don't clear the modifiers, events from other devices that we
receive while unfocused will assume `Alt` is still pressed. This results
in e.g. Firefox navigating through the history instead of scrolling the
page when using the mouse wheel on it.

We don't get any information about modifiers while we are missing
keyboard focus, so assuming no modifiers are active is the best we can
do.

The shell sends us a modifier update immediately before we regain
keyboard focus, so the state shouldn't get out of sync.

Fixes #2112

supp: Use a single suppressions file for lib, lib64 and multiarch

See merge request !1603

Im context wayland fixes

See merge request !1605

This ensures that it is done only once.

We are not loading the Compose file for individual contexts,
it just gets added to a global list. So don't pass an im context
along. This will let us move the loading out of the initialization
of individual contexts, and only do it once.

There is nothing display-specific in the ~/.Compose file,
so we can just try to load it without looking at the
display we are on.

We are loading a file here, thankfully in a thread, but
we do it every time an entry is created. Add a profiler
mark, to make this visible.

In addition to the traditional library directory lib and the 64-bit
multilib directory lib64, this will cover Debian-style multiarch
(lib/x86_64-linux-gnu etc.), Arch Linux 32-bit (lib32), x32 and
various others.
Signed-off-by: Simon McVittie <smcv@debian.org>

Fix crossing event generation

Closes #2536

See merge request !1601

We were not properly setting the new_descendent field
in Crossing structs for GTK_CROSSING_OUT events. This
was causing extraneous ::leave signals to be emitted,
and make model buttons in popover menus flicker when
hovered.

Fixes: #2536

gtk-demo: Remove the popover demo

Closes #2429

See merge request !1600

It doesn't work anymore, since popovers now need
support in the parent, and we don't really need
a demo just for popovers. They are used everywhere
already.

Fixes: #2429

gtkflowbox: Fix a minor typo in the documentation

See merge request !1599