1. 26 Jun, 2018 1 commit
    • Chun-wei Fan's avatar
      gtk/: Fix build without PangoFT2 and HarfBuzz · eebf151f
      Chun-wei Fan authored
      On Windows HarfBuzz and PangoFT2 are optional, so we need to ensure that
      we only build the bits that require HarfBuzz and PangoFT2 when needed.
      We may need to see later whether we can get the needed functionality in
      gtkfontchooserwidget.c with the Windows APIs without the need of
      HarfBuzz nor PangoFT2 (and starting programs on Windows using FontConfig
      is very slow).
      eebf151f
  2. 04 Jun, 2018 3 commits
  3. 18 May, 2018 5 commits
  4. 19 Jan, 2018 2 commits
  5. 27 Dec, 2017 1 commit
  6. 19 Dec, 2017 1 commit
    • Matthias Clasen's avatar
      font chooser: Stop listening to style-updated · 09c94c27
      Matthias Clasen authored
      The only time a style-updated indicates we need
      to reload fonts is when it is synthesized by GtkSettings
      in response to a fontconfig timestamp change, but
      we are listening to those already, anyway.
      09c94c27
  7. 08 Feb, 2016 1 commit
    • Timm Bäder's avatar
      Various documentation fixes · c5369356
      Timm Bäder authored
      Always have Since: annotations at the very bottom, use the correct
      ClassName::signal-name/ClassName:property-name syntax, fix a few typos
      in type names, wrong function names, non-existing type names, etc.
      c5369356
  8. 14 Jan, 2016 1 commit
  9. 04 Dec, 2015 1 commit
    • Matthias Clasen's avatar
      Fix make check · f210dc92
      Matthias Clasen authored
      GtkFontChooserWidget is using a GThemedIcon in its template,
      so we need to ensure that the type is registered before
      loading it. This was causing the defaultvalue test to fail.
      f210dc92
  10. 11 Aug, 2015 2 commits
  11. 29 Jul, 2015 1 commit
  12. 22 Jul, 2015 1 commit
    • Benjamin Otte's avatar
      fontchooserwidget: Refactor code so we actually optimize · 31191d55
      Benjamin Otte authored
      Previously, we would pango_font_describe() every time the code ran and
      we wouldn't ever hit the optimized quick exit.
      
      The code now is a lot more complex because the
      compute-actual-value-when-required-the-first-time approach is not
      supported out of the box in GtkTreeModel (or GValue).
      31191d55
  13. 11 Jul, 2015 1 commit
  14. 13 Jun, 2015 1 commit
    • Matthias Clasen's avatar
      Redo font map support in GtkFontChooser · 6f955a7d
      Matthias Clasen authored
      We can't add properties to the interface, since it breaks
      3rd party implementations of the GtkFontChooser interface.
      These exist, for example in gnumeric.
      
      So, instead of a new property, add getter/setter vfuncs.
      6f955a7d
  15. 12 Jun, 2015 1 commit
    • Benjamin Otte's avatar
      fontchooser: Don't cause "row-changed" signal in cell data func · 8c6130e6
      Benjamin Otte authored
      The font chooser delays creating the font description from the font face
      as long as possible (it's slow). Because we use fixed height mode, we
      only have to create font descriptions for rows we are actually going to
      show.
      
      This was achieved by looking at the font description column and if it
      was NULL, we created a font description and gtk_list_stiore_set() it.
      Unfortunately this caused a "row-changed" signal to be emitted and this
      emission could happen during the cell data func.
      And that caused infinite loops with accessibility when you were unlucky.
      
      This change replaces the NULL font description with an empty one and
      instead of setting the correct font description, we
      pango_font_description_merge() it in. This way, the list store doesn't
      change and no signals are emitted.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1197267
      8c6130e6
  16. 09 May, 2015 1 commit
  17. 07 May, 2015 3 commits
  18. 06 May, 2015 1 commit
    • Matthias Clasen's avatar
      GtkFontChooserWidget: Listen for fontconfig changes · 07f4c9c3
      Matthias Clasen authored
      We were relying on indirectly getting notify when fontconfig
      configuration changes, by GtkSettings translating the timestamp
      change into a style-invalidation, which gets fed through the
      css invalidation machinery. That machinery has gotten good enough
      at optimizing away redundant changes that it no longer emits
      ::style-updated in this case.
      
      So, instead make the font chooser listen directly to what it
      cares about: the fontconfig change notification from GtkSettings.
      07f4c9c3
  19. 05 May, 2015 1 commit
  20. 27 Oct, 2014 2 commits
    • Christophe Fergeau's avatar
      Return correct font from gtk_font_chooser_widget_find_font · 506d59f5
      Christophe Fergeau authored
      Commit 30a1c4ab fixed several memleaks including one in
      gtk_font_chooser_widget_find_font.
      
      However, the fix causes one extra call to gtk_tree_model_iter_next()
      after finding the font we look for (ie pango_font_description_equal
      returns TRUE): the 'increment' part of the for loop
      (gtk_tree_model_iter_next) is run before the 'exit condition' of the for
      loop is evaluated.
      
      This commit reverts this part of commit 30a1c4ab and adds an extra
      call to pango_font_description_free in order to fix the leak.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=739111
      506d59f5
    • Christophe Fergeau's avatar
      fontchooserwidget: Don't invalidate priv->font_iter in load_fonts · 77487fef
      Christophe Fergeau authored
      When using GtkFontChooserButton, the same GtkFontChooserWidget can be
      hidden and shown multiple times. When doing that, the font that was
      chosen the previous time should be the selected one in the
      GtkFontChooserWidget, however this does not work as expected and a
      somehow 'random' font gets selected (or none) instead.
      
      Every time the font chooser widget is shown, its style will be updated,
      causing gtk_font_chooser_widget_style_updated and then
      gtk_font_chooser_widget_load_fonts to be called.
      
      gtk_font_chooser_widget_load_fonts starts by clearing the GtkListStore
      listing the available fonts, repopulates it, and then makes sure the
      current font is selected.
      
      However, this does not work as expected, as during the call to
      gtk_list_store_clear, the cursor_changed_cb will be invoked multiple
      times when the GtkTreeView cursor gets moved when the line where the
      cursor currently is gets removed. This will cause the 'current font'
      state (priv->font_desc) to be unexpectedly modified, and when
      gtk_font_chooser_widget_load_fonts tries to reposition the cursor to the
      'current font', we won't get the expect result.
      
      This commit avoids that by making sure cursor_changed_cb does not get
      called when we call gtk_list_store_clear in
      gtk_font_chooser_widget_load_fonts.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=739111
      77487fef
  21. 15 Oct, 2014 1 commit
  22. 03 Oct, 2014 1 commit
  23. 02 Oct, 2014 1 commit
  24. 15 Aug, 2014 3 commits
  25. 22 Mar, 2014 1 commit
  26. 19 Feb, 2014 1 commit
  27. 24 Jan, 2014 1 commit