1. 21 Apr, 2016 1 commit
  2. 18 Mar, 2015 1 commit
  3. 06 Feb, 2015 1 commit
  4. 20 Jan, 2015 1 commit
    • Benjamin Otte's avatar
      render: Remove spinner special-cases · e697213b
      Benjamin Otte authored
      The spinner is a regular builtin image now. There is no need to go
      through the shadows code manually anymore as regular items do get
      shadows automatically.
      
      This also allows simplifying the actual spinner drawing code so that it
      actually works.
      e697213b
  5. 07 Jan, 2015 1 commit
  6. 20 Aug, 2014 1 commit
  7. 09 Jun, 2014 1 commit
    • Benjamin Otte's avatar
      css: Parse text-shadow values properly · 3759190c
      Benjamin Otte authored
      We used to accept the same syntax for text-shadow and icon-shadow as
      we accept for box-shadow. However, box-shadow does accept a spread and
      the inset keyword while the others should not.
      3759190c
  8. 23 May, 2014 1 commit
  9. 14 May, 2014 1 commit
  10. 03 Feb, 2014 1 commit
  11. 03 Jul, 2013 1 commit
    • Alexander Larsson's avatar
      css: Add a scale argument to css-value compute vfunc · af2c40bd
      Alexander Larsson authored
      We need to be able to compute different GtkCssImage values
      depending on the scale, and we need this at compute time so that
      we don't need to read any images other than the scale in used (to
      e.g. calculate the image size). GtkStyleProviderPrivate is shared
      for all style contexts, so its not right.
      af2c40bd
  12. 22 Apr, 2013 1 commit
  13. 09 Apr, 2013 1 commit
  14. 16 Oct, 2012 1 commit
    • Cosimo Cecchi's avatar
      cssshadowsvalue: handle gtk_css_value_transition returning NULL · a021b72c
      Cosimo Cecchi authored
      The implementation of transition for GtkCssShadowValue can return NULL
      at least when the two values have a different inset; all other parts of
      the GTK/CSS machinery (e.g. GtkCssArrayValue) handle this by returning
      NULL too. Instead, GtkCssShadowsValue was returning an invalid value,
      where "len" was set, but some values in the array were NULL, which would
      lead to a segfault when this value is later evaluated by the compute
      function.
      
      Fix this by making GtkCssShadowsValue return NULL if a shadow transition
      fails, like GtkCssArrayValue does.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=686013
      a021b72c
  15. 28 Sep, 2012 1 commit
    • Benjamin Otte's avatar
      css: Huge refactoring to avoid computing wrong values · 1454ba15
      Benjamin Otte authored
      Here's the shortest description of the bug I can come up with:
      When computing values, we have 3 kinds of dependencies:
      (1) other properties ("currentColor" or em values)
      (2) inherited properties ("inherit")
      (3) generic things from the theme (@keyframes or @define-color)
      Previously, we passed the GtkStyleContext as an argument, because it
      provided these 3 things using:
      (1) _gtk_style_context_peek_property()
      (2) _gtk_style_context_peek_property(gtk_style_context_get_parent())
      (3) context->priv->cascade
      
      However, this makes it impossible to lookup values other than the ones
      accessible via _gtk_style_context_peek_property(). And this is exactly
      what we are doing in gtk_style_context_update_cache(). So when the cache
      updates encountered case (1), they were looking up the values from the
      wrong style data.
      
      So this large patch essentially does nothing but replace the
      context argument in all compute functions with new arguments for the 3
      cases above:
      (1) values
      (2) parent_values
      (3) provider
      
      We apparently have a lot of computing code.
      1454ba15
  16. 03 Sep, 2012 1 commit
    • Benjamin Otte's avatar
      cssvalue: Pass property ID to transition function · e3fc081c
      Benjamin Otte authored
      This is to allow animating arrays properly. I'm not really thrilled
      about this solution (we leak propertys into the values again...), but
      it's the best I can come up with - I prefer it to having N different
      array types...
      e3fc081c
  17. 28 Aug, 2012 4 commits
    • Matthias Clasen's avatar
      27fd3fdf
    • Benjamin Otte's avatar
      css: Introduce dependencies for value computations · 0e2f35ed
      Benjamin Otte authored
      When values are computed, they might depend on various other values and
      we need to track this so we can update the values when those other
      values change. This is the first step in making that happen.
      
      This patch does not do any dependency tracking at all, instead it uses
      GTK_CSS_DEPENDS_ON_EVERYTHING as a sort of FIXME.
      0e2f35ed
    • Benjamin Otte's avatar
      css: Pass property_id to compute function · 9b4ed662
      Benjamin Otte authored
      This is a reorganization of how value computing should be done.
      Previously the GtkCssStyleProperty.compute vfunc was supposed to take
      care of special cases when it needed those for computation. However,
      this proved to be very complicated in cases where values were nested and
      only the last value (of a common type) needed to be special cased.
      
      A common example for this was the fallback handling for unresolvable
      colors.
      
      Now, we pass the property's ID along with all compute functions so we
      can do the special casing where it's necessary.
      Note that no actual changes happen in this commit. This will happen in
      follow-ups.
      9b4ed662
    • Benjamin Otte's avatar
      css: Introduce _gtk_css_value_compute() · 9b953829
      Benjamin Otte authored
      This commit is essentially a large reorganization. Instead of all value
      subtypes having their own compute function, there is the general
      _gtk_css_value_compute() function that then calls a vfunc on the
      subtype.
      9b953829
  18. 17 Apr, 2012 2 commits