1. 02 Nov, 2012 1 commit
    • Federico Mena Quintero's avatar
      bgo#687196 - Fix model corruption during file removal · ea3a750f
      Federico Mena Quintero authored
      The main problem is that we were emitting the row-deleted signal for the model in the middle
      of the process that actually deletes the row from the model (remove the row from the array,
      update the model->file_lookup hash table, etc.).  In the model's caller, one of the row-deleted
      callbacks was requesting an iter, which caused the model to revalidate itself - but it did
      this while it was in an inconsistent state.  This led to an assertion failure later when the
      model resorted itself.
      
      The fix in remove_file() is like this:
      
      * The filteredness/visibility of the deleted node is not updated.  The
        node will simply be gone; we don't need to update those values at
        all.
      
      * We invalidate just the node that is being deleted.
      
      * The model->file_lookup hash table is not completely nuked; instead,
        we carefully adjust its indices.
      
      * The row-deleted signal is only emitted at the very end, when
        deletion is complete and the model is consistent.
      
      Many thanks to William Hua for doing the detective work on this bug!
      Signed-off-by: Federico Mena Quintero's avatarFederico Mena Quintero <federico@gnome.org>
      ea3a750f
  2. 01 Nov, 2012 4 commits
  3. 19 Oct, 2012 2 commits
  4. 18 Oct, 2012 3 commits
  5. 17 Oct, 2012 10 commits
  6. 16 Oct, 2012 10 commits
  7. 15 Oct, 2012 10 commits