1. 24 Jun, 2013 1 commit
  2. 13 May, 2013 2 commits
    • Jasper St. Pierre's avatar
    • Allison Karlitskaya's avatar
      add GtkMenuTrackerItem · a4276a6c
      Allison Karlitskaya authored
      Add a new class, GtkMenuTrackerItem that represents a menu item, to be
      used with GtkMenuTracker.
      
      GtkMenuTracker's insert callback now works in terms of this new type
      (instead of passing reference to the model and an index to the item).
      
      GtkMenuShell now handles all of the binding tasks internally, mostly
      through the use of property bindings.  Having bindings for the label and
      visibility attributes, in partiular, will help with supporting upcoming
      extensions to GMenuModel.
      
      GtkModelMenu has been reduced to a helper class that has nothing to do
      with GMenuModel.  It represents something closer to an "ideal" API for
      GtkMenuItem if we didn't have compatibility concerns (eg: not emitting
      "activate" when setting toggle state, no separate subclasses per menu
      item type, supporting icons, etc.) Improvements to GtkMenuItem could
      eventually shrink the size of this class or remove the need for it
      entirely.
      
      Some GtkActionHelper functionality has been duplicated in
      GtkMenuTracker, which is suboptimal.  The duplication exists so that
      other codebases (such as Unity and gnome-shell) can reuse the
      GtkMenuTracker code, whereas GtkActionHelper is very much tied to
      GtkWidget.  Supporting binding arbitrary GtkWidgets to actions vs.
      supporting the full range of GMenuModel features for menu items turns
      out to be two overlapping but not entirely similar problems.  Some of
      the duplication (such as roles) can be removed from GtkActionHelper once
      Gtk's internal Mac OS menubar support is ported to GtkMenuTracker.
      
      The intent to reuse the code outside of Gtk is also the reason for the
      unusual treatment of the enum type introduced in this comment.
      
      This adds no new "public" API to the Gtk library, other than types that
      we cannot make private due to GType limitations.
      a4276a6c
  3. 01 Apr, 2013 1 commit
    • Allison Karlitskaya's avatar
      Introduce GtkMenuTracker · 5617b584
      Allison Karlitskaya authored
      GtkMenuTracker folds a nested structure of sections in a GMenuModel into
      a single linear menu, which it expresses to its user by means of 'insert
      item at position' and 'remove item at position' callbacks.
      
      The logic for where to insert separators and how to handle action
      namespaces is contained within the tracker, removing the need to have
      this logic duplicated in the 3 or 4 places that consume GMenuModel.
      
      In comparison with the previous code, the tracker no longer completely
      destroys and rebuilds menus every time a single change occurs.  As a
      result, the new gtkmenu testcase now runs in approximately 3 seconds
      instead of ~60 before.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=696468
      5617b584