1. 31 Jan, 2019 1 commit
    • Suyuan Chang's avatar
      macOS: Fix bug that entry cannot press and hold a key to input accented character. · cfad43b8
      Suyuan Chang authored
      There're two issues in GdkQuartzView's NSTextInputClient implementation
      causes this bug.
      
      1. The -(NSRange)selectedRange should not return [NSNotFound, 0] if
         there's no selection. The accented character window will not show
         if returned NSRange's location is NSNotFound. Instead of that, the
         NSRange's location should be the caret position in the text input
         buffer.
      
      2. The accented character window will invoke
         -(void)insertText:replacementRange: with non-empty replacement
         range, to replace non-accented character with accented character
         after user select it from accented character window. This case is
         not implemented in original code. Here I use another gobject data
         to pass the information to input module and convert it into
         'delete-surrounding' event.
      
      Besides these, there's another bug cause gtk_im_context_filter_keypress()
      return wrong value while user press and hold a key. When user press
      and hold a key, the accented character window will consume the
      repeating key down event. Is this case, gtk_im_context_filter_keypress()
      should return TRUE, indicate the key press is filtered by input
      method module. But it will return FALSE because
      gtk_im_context_filter_keypress() assume that every key press event
      will generate some text from input method module.
      
      Fixes #1618
      cfad43b8
  2. 18 Jan, 2019 1 commit
    • Chun-wei Fan's avatar
      MSVC builds: Improve introspection build process · 5ffbeeff
      Chun-wei Fan authored
      To avoid confusion, have the NMake Makefiles output the built introspection
      files in the same location where the binaries are built for the project
      files, according to the Visual Studio version, platform and configuration
      where the build is carried out.
      
      Also make generating the introspection NMake snippet portion more robust to
      source additions and removals by checking on Makefile changes too.
      5ffbeeff
  3. 17 Jan, 2019 1 commit
  4. 08 Jan, 2019 2 commits
    • Jonas Ådahl's avatar
      wayland/cursor: Make sure the cached cursor has the right size · a907552d
      Jonas Ådahl authored
      The cache key is just the name of the cursor, so if a previously added
      cursor had e.g. scale == 1, if we ask for a new cursor with scale == 2,
      we might still fetch the scale == 1 cursor from the cache. Avoid this by
      making sure the scale of the cached one is correct.
      
      If it isn't, load the cursor as normal, and update the cache entry with
      the new properly scaled cursor.
      
      Fixes: #1183
      a907552d
    • Jonas Ådahl's avatar
      wayland/cursor: Rename GdkWaylandCursor variable · d31107c4
      Jonas Ådahl authored
      It was called "private" for some reason. Call it "wayland_cursor"
      instead, as it's a GdkWaylandCursor, and also not private.
      d31107c4
  5. 06 Jan, 2019 1 commit
  6. 04 Jan, 2019 2 commits
  7. 03 Jan, 2019 1 commit
  8. 22 Dec, 2018 1 commit
    • Tomasz Miąsko's avatar
      Annotate values of PRIORITY constants · d3b6d16d
      Tomasz Miąsko authored
      g-ir-scanner incorrectly evaluates macro definition that include
      references to other macro definitions. Provide a correct value as an
      annotation.
      
      Differences in generated gir files:
      
      ```diff
      @@ -19017 +19017 @@
      -    <constant name="PRIORITY_REDRAW" value="20" c:type="GDK_PRIORITY_REDRAW">
      +    <constant name="PRIORITY_REDRAW" value="120" c:type="GDK_PRIORITY_REDRAW">
      @@ -74229,3 +74229,3 @@
           </constant>
      -    <constant name="PRIORITY_RESIZE" value="10" c:type="GTK_PRIORITY_RESIZE">
      +    <constant name="PRIORITY_RESIZE" value="110" c:type="GTK_PRIORITY_RESIZE">
             <doc xml:space="preserve">Use this priority for functionality related to size allocation.
      @@ -106786,3 +106786,3 @@
           <constant name="TEXT_VIEW_PRIORITY_VALIDATE"
      -              value="5"
      +              value="125"
                     c:type="GTK_TEXT_VIEW_PRIORITY_VALIDATE">
      ```
      d3b6d16d
  9. 18 Dec, 2018 5 commits
    • Ignacio Casal Quinteiro's avatar
      quartz/display: add back scaling factor · 1a9377ba
      Ignacio Casal Quinteiro authored
      With the last patches one thing that got lost if the scaling
      factor. This is very visible when i.e loading a svg image
      in a Retina display.
      1a9377ba
    • John Ralls's avatar
      Fix copy-paste error. · e105fefc
      John Ralls authored
      e105fefc
    • Peter Hutterer's avatar
      x11: make the tool lookup dependent on the hw id as well · 7b33369b
      Peter Hutterer authored
      Tools on the same physical item have the same serial number, so the eraser
      and the pen part of a single pen share that serial number. With the current
      lookup code, we'll always return whichever tool comes first into proximity.
      
      Change the code to use the hw id in addition to the serial number, this way we
      can differ between two tools.
      7b33369b
    • Peter Hutterer's avatar
      x11: don't add unknown tools to our list · c6dd9229
      Peter Hutterer authored
      Generic tools (Bamboo, built-in tablets) always have the same serial number
      assigned by the wacom driver. This includes the touch tool when the wacom
      driver handles the touch evdev node (common where users require the wacom
      gestures to work).
      
      When the first device is the touch device, a tool is created with that serial.
      All future tools now return the touch tool on lookup since they all share the
      same serial number. Worse, this happens *across* devices, so the pen
      event node gets assigned the touch tool because they all have the same serial.
      
      Since we don't actually care about the touch as a tool, let's skip any unknown
      tool. This captures pads as well.
      c6dd9229
    • Peter Hutterer's avatar
      x11: get the tool type from the wacom driver properties · f173d1bc
      Peter Hutterer authored
      Any wacom device currently sets the tool type to UNKNOWN. The wacom driver has
      a property that exports the tool type as one of stylus, eraser, cursor, pad or
      touch. Only three of those are useful here but that's better than having all
      of them as unknown.
      f173d1bc
  10. 17 Dec, 2018 4 commits
  11. 16 Dec, 2018 2 commits
  12. 13 Dec, 2018 2 commits
    • Daniel Boles's avatar
      x11: Fix deprecation macro use · e3a1593a
      Daniel Boles authored
      G_GNUC_END_IGNORE_DEPRECATIONS terminates the if statement and does not
      consider the following block to be part of the if. So that block was
      always taken irregardless of the pattern.
      
      Fixes #1280
      e3a1593a
    • Benjamin Otte's avatar
      x11: Be a lot more careful about setting ParentRelative · 6a47e9a8
      Benjamin Otte authored
      We don't want to set ParentRelative when:
      
      - the parent window is NULL
        In that case we are unsure about the depth, so better err on the side
        of caution and avoid a BadMatch by accepting ugly output.
      - the cairo pattern is in an error status
        This should never happen - unless you start up in OOM - but better
        be safe than sorry.
      
      Might help with the spurious crashes in #1280.
      6a47e9a8
  13. 12 Dec, 2018 1 commit
  14. 08 Dec, 2018 16 commits