1. 24 Oct, 2001 8 commits
    • Kristian Rietveld's avatar
      more changes in an attempt to get it right. It's not yet ready for general · beaba6a4
      Kristian Rietveld authored
      Wed Oct 24 20:29:47 2001  Kristian Rietveld  <kristian@planet.nl>
      
              * gtk/gtktreemodelsort.c: more changes in an attempt to get
              it right. It's not yet ready for general consumption.
      
              * tests/treestoretest.c: add a button and entry for the new
              iter_change function
              (iter_change): new function, to test
              the row_changed signal implementation of the GtkTreeModelSort
      
              * tests/testtreesort.c: cleanups, changes to test more features
              of the GtkTreeModelSort at once
      beaba6a4
    • Havoc Pennington's avatar
      remove hack to strip off the bogus newline, since we killed the bogus · 9b7d528a
      Havoc Pennington authored
      2001-10-24  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextbuffer.c (clipboard_clipboard_buffer_received):
      	remove hack to strip off the bogus newline, since we killed the
      	bogus newline; fixes #61779
      9b7d528a
    • Havoc Pennington's avatar
      87b1f401
    • Havoc Pennington's avatar
      don't create layout if we didn't have one (gtk_text_view_set_buffer): · 4e8cbdca
      Havoc Pennington authored
      2001-10-24  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_update_adjustments): don't
      	create layout if we didn't have one
      	(gtk_text_view_set_buffer): invalidate so we get the idle handlers
      	as appropriate, avoids blanking the screen
      	(gtk_text_view_invalidate): new function to do invalidation,
      	containing old guts of invalidated_handler
      4e8cbdca
    • Owen Taylor's avatar
      Improve dreadful tooltips. · 679ca1ae
      Owen Taylor authored
      Wed Oct 24 10:29:47 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkalignment.c (gtk_alignment_class_init): Improve
      	dreadful tooltips.
      679ca1ae
    • Owen Taylor's avatar
      Always set window->parent (except or the root window itself); if the · b7c639ea
      Owen Taylor authored
      Tue Oct 23 17:31:42 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c: Always
      	set window->parent (except or the root window itself); if
      	the window's parent is not a GdkWindow, or is a window of
              type GDK_WINDOW_FOREIGN, set window->parent to the root parent.
      
      	* gdk/gdkwindow.c (gdk_window_get_toplevels): Don't include
      	windows of type GDK_WINDOW_FOREIGN.
      b7c639ea
    • Stanislav Visnovsky's avatar
      More updates. · ec00283f
      Stanislav Visnovsky authored
      2001-10-24  Stanislav Visnovsky  <visnovsky@nenya.ms.mff.cuni.cz>
      
              * sk.po: More updates.
      ec00283f
    • Havoc Pennington's avatar
      if we move to the front of a segment, use the "slow" technique for moving · da4a3112
      Havoc Pennington authored
      2001-10-24  Havoc Pennington  <hp@pobox.com>
      
      	* gtk/gtktextiter.c (gtk_text_iter_backward_chars): if we move to
      	the front of a segment, use the "slow" technique for moving
      	backward, so we don't mess up the any_segment field in the iter.
      	Fixes #57707
      
      	* tests/testtextbuffer.c: add code to detect #57707, to avoid
      	regression
      da4a3112
  2. 23 Oct, 2001 13 commits
    • Havoc Pennington's avatar
      only sensitize Cut if selection contains some editable text, #60975 · fa4e7a31
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (popup_targets_received): only sensitize Cut
      	if selection contains some editable text, #60975
      	(gtk_text_view_scroll_to_iter): remove warning about scrolling
      	prior to map; it should actually be OK to do so in many cases,
      	it would be nice to warn about scrolling when many lines have
      	height 0, but I don't know what to do about that. Perhaps
      	move part of flush_scroll into this function? comment added
      	to consider this.
      fa4e7a31
    • Havoc Pennington's avatar
      oops, didn't quite compile. · 60bec4dc
      Havoc Pennington authored
      60bec4dc
    • Havoc Pennington's avatar
      Correctly keep the same text on the top of the screen, considering that · 14cc0e8f
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (changed_handler): Correctly keep the same
      	text on the top of the screen, considering that the changed region
      	may have overlapped the first paragraph. Should fix msw's "text
      	widget scrolled to wrong place on map" bug, and probably some
      	other scrolling cases as well.
      	(gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
      	instead of some random value
      
      	* gtk/gtktextview.c (gtk_text_view_class_init): actually override
      	grab_focus, so #59708 is really fixed
      14cc0e8f
    • Anders Carlsson's avatar
      Use an image menu item here (popup_targets_received): Call · fd3196d9
      Anders Carlsson authored
      2001-10-24  Anders Carlsson  <andersca@gnu.org>
      
      	* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
      	(popup_targets_received): Call append_action_signal with stock items
      
      	* gtk/gtklabel.c: (append_action_signal): Use an image menu item here
      	(gtk_label_do_popup): Call append_action_signal with stock items
      
      	* gtk/gtktextview.c: (append_action_signal): Use an image menu item here
      	(popup_targets_received): Call append_action_signal with stock items
      fd3196d9
    • Havoc Pennington's avatar
      queue a resize here; will temporarily slow down the widget a lot, until we · b6ba7a5f
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (changed_handler): queue a resize here; will
      	temporarily slow down the widget a lot, until we figure out how to
      	optimize to avoid full redraw everytime we queue a resize
      b6ba7a5f
    • Havoc Pennington's avatar
      handle case where offset == 0 and char_len == 0, bug #61729 · 10f47690
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextiter.c (test_log_attrs): handle case where offset ==
      	0 and char_len == 0, bug #61729
      10f47690
    • Havoc Pennington's avatar
      fix return value, #61714 (Vitaly Tishkov) · 85cdc1ce
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextiter.c (gtk_text_iter_forward_cursor_positions): fix
      	return value, #61714 (Vitaly Tishkov)
      	(gtk_text_iter_backward_sentence_starts): ditto
      	(gtk_text_iter_backward_word_starts): ditto
      	(gtk_text_iter_forward_word_ends): ditto
      	(gtk_text_iter_forward_sentence_ends): ditto
      	(gtk_text_iter_backward_cursor_positions): ditto
      85cdc1ce
    • Havoc Pennington's avatar
      Apply fix from Dov Grobgeld, #61858 · 9894b89b
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextlayout.c (gtk_text_layout_get_iter_at_pixel): Apply
      	fix from Dov Grobgeld, #61858
      9894b89b
    • Havoc Pennington's avatar
      credit Hidetoshi · bd3b53c4
      Havoc Pennington authored
      bd3b53c4
    • Havoc Pennington's avatar
      Update IM spot location at appropriate times, #50626 · cfcf8366
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_update_im_spot_location):
      	Update IM spot location at appropriate times, #50626
      cfcf8366
    • Havoc Pennington's avatar
      remove conflict markers · dceeec35
      Havoc Pennington authored
      dceeec35
    • Havoc Pennington's avatar
      scroll to cursor on grab focus, unless it's caused by button click, #59708 · 13a24b1b
      Havoc Pennington authored
      2001-10-23  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_grab_focus): scroll to cursor
      	on grab focus, unless it's caused by button click, #59708
      13a24b1b
    • Owen Taylor's avatar
      Remove G_DISABLE_CONST_RETURNS. · 4e32ede2
      Owen Taylor authored
      Tue Oct 23 11:53:00 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/Makefile.am (INCLUDES): Remove G_DISABLE_CONST_RETURNS.
      
      	* gtk/gtkfontsel.[ch]: Make gtk_font_selection_get_font()
      	G_CONST_RETURN. (Murray Cumming)
      
      	* gtk/gtkfontsel.c (gtk_font_selection_dialog_get_preview_text):
      	Make G_CONST_RETURN.
      
      	* gtk/gtkfilesel.c (open_user_dir): Fix bug with freeing
      	results of g_get_home_dir().
      
      	* gtk/gtkfilesel.c: Make filesel->fileop_file a duplicated
      	copy. Storing the return from gtk_entry_get_text() is evil.
      
      	* gtk/gtkcombo.c gtk/gtkcellrenderertext.c gtk/gtkbindings.c
      	gtk/gtkfilesel.c gtk/gtkfontsel.c gtk/gtkimmodule.c
      	gtk/gtkobject.c gtk/gtkoldeditable.c gtk/gtktreedatalist.c
      	gtk/gtksignal.c: Add const.
      
      	* gdk/x11/gdkkeys-x11.c (get_direction): Add missing const.
      
      	* gtk/gtktreeview.c: Namespace object data keys to be safe, even
      	if we are setting them on private widgets.
      
      	* gtk/gtktreeview.c (gtk_tree_view_real_start_interactive_search):
      	Duplicate entry->text before setting it as object data.
      4e32ede2
  3. 22 Oct, 2001 19 commits
    • Havoc Pennington's avatar
      don't back up a char from the end iterator, fixes #61859 ("can't put · 0d5635b3
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextbuffer.c (gtk_text_buffer_place_cursor): don't back
      	up a char from the end iterator, fixes #61859 ("can't put cursor
      	at the end of the buffer")
      
      	* gtk/gtktextiter.c (gtk_text_iter_forward_to_line_end): fix this
      	to work with delimiters other than newline.
      
      	* tests/testtextbuffer.c: add some tests for get_chars_in_line,
      	get_bytes_in_line
      
      	* gtk/gtktextiter.c (gtk_text_iter_get_chars_in_line): fix for the
      	last line, since the newline is no longer counted.
      	(gtk_text_iter_get_bytes_in_line): ditto
      0d5635b3
    • Tor Lillqvist's avatar
    • Tor Lillqvist's avatar
    • Tor Lillqvist's avatar
    • Havoc Pennington's avatar
      add assertion that #58290 would trigger if it reappeared, I think · f2bf563d
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextbtree.c (_gtk_text_btree_insert): add assertion that
      	#58290 would trigger if it reappeared, I think
      f2bf563d
    • Havoc Pennington's avatar
      add temporary code to dump btree contents on assertion failure described · 0a522533
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextiter.c (_gtk_text_iter_forward_indexable_segment):
      	add temporary code to dump btree contents on assertion failure
      	described in #62656
      
      	* gtk/gtktextbtree.c (ensure_end_iter_segment): add some
      	assertions that we're getting the right end iter segment
      
      	* gtk/gtktextiter.c (_gtk_text_iter_forward_indexable_segment):
      	verify that we aren't on the end iterator after moving
      	forward one segment - fixes return value in an obscure case.
      	Also, some trivial code cleanup/rearranging.
      0a522533
    • Havoc Pennington's avatar
      add a #error unless you define GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API, so · 64464846
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextlayout.h: add a #error unless you define
      	GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API, so people don't use this accidentally
      
              * gtk/gtktext*.c: #define GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API as appropriate.
      64464846
    • Havoc Pennington's avatar
      fix #62365 · a959d3da
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_get_border_window_size): fix
      	#62365
      a959d3da
    • Havoc Pennington's avatar
      fix #62436 · 347da0ea
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_get_window_type): fix
      	#62436
      347da0ea
    • Havoc Pennington's avatar
      Fix #62366 · c33d1718
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_set_border_window_size): Fix
      	#62366
      c33d1718
    • Owen Taylor's avatar
      Add cursor-position, selection-bound properties. (#62148, reported by · c8b58228
      Owen Taylor authored
      Mon Oct 22 11:47:47 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtklabel.c: Add cursor-position, selection-bound
      	properties. (#62148, reported by Padraig O'Briain)
      
      	* gtk/gtkentry.c (gtk_entry_class_init): Rename text_position
      	to cursor_position. (1.3.x addition, text_position is an awful
      	name.) Make cursor_position read-only to avoid sticky questions
      	of interaction with selection_bound. (#62636, reported by
      	Padraig O'Briain)
      c8b58228
    • Owen Taylor's avatar
      Fixing popup menus to have "Paste" sensitized correctly. Original patches · 92d2dc0b
      Owen Taylor authored
      Mon Oct 22 16:25:12 2001  Owen Taylor  <otaylor@redhat.com>
      
      	Fixing popup menus to have "Paste" sensitized correctly. Original
      	patches from Damian Ivereigh, much mangled.
      
      	* gtk/gtkselection.c: Add functions gtk_selection_data_get_targets(),
      	gtk_selection_data_targets_include_text(). (#60854)
      
      	* gtk/gtkclipboard.c: Add a simple do-it-all non-async "check if
      	the clipboard has text" function gtk_clipboard_wait_is_text_available.
      	(#60854)
      
      	* gtk/gtkentry.c: Only enable the paste item if the clipboard
      	contains text. (#60973)
      
      	* gtk/gtktextview.c: Only enable the paste item if the clipboard
      	contains text. (#60975)
      92d2dc0b
    • Havoc Pennington's avatar
      rip out "height_lines" and "width_columns" properties, it doesn't make · 8fe96693
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c (gtk_text_view_class_init): rip out
      	"height_lines" and "width_columns" properties, it doesn't make
      	sense to set the size request on a text view really. #62103
      8fe96693
    • Jonathan Blandford's avatar
      Realized g_node_depth is broken, and that it's not worth being consistent · 12396ed1
      Jonathan Blandford authored
      Mon Oct 22 15:17:05 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreestore.c (gtk_tree_store_iter_depth): Realized
      	g_node_depth is broken, and that it's not worth being consistent
      	with it.
      12396ed1
    • Havoc Pennington's avatar
      Clarify behavior in docs, #61777 (gtk_text_iter_forward_search) · 72e6566b
      Havoc Pennington authored
      2001-10-22  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextiter.c (gtk_text_iter_set_line): Clarify behavior in
      	docs, #61777
      	(gtk_text_iter_forward_search) (gtk_text_iter_backward_search):
      	change the two boolean args to a flags field, so we can extend
      	to add case insensitive, regexp searches later. #61852
      72e6566b
    • Jonathan Blandford's avatar
      update docs to reflect reality, #62810 · 6bf176c3
      Jonathan Blandford authored
      Mon Oct 22 15:07:17 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreestore.c (gtk_tree_store_iter_depth): update docs to
      	reflect reality, #62810
      6bf176c3
    • Jonathan Blandford's avatar
      Remove handle_box from App demo. · dc754528
      Jonathan Blandford authored
      
      Mon Oct 22 14:08:26 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* demos/gtk-demo/appwindow.c: Remove handle_box from App demo.
      
      	* gtk/gtktreeview.c (size_allocate): Move to a different drawing
      	system.  Instead of having a window the size of the tree, we have
      	a window the size of widget->allocation, and simply draw with the
      	offset.
      	(coords_are_over_arrow): ditto.  Move to window coordinates.
      	(do_prelight): ditto
      	(do_unprelight): ditto
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_rows_reordered):
      	Minor fix from Kristian Rietveld to fix unsorted case.
      dc754528
    • jacob berkman's avatar
      don't cast a PIXTEXT cell to a PIXMAP cell (fixes crash when using PIXTEXT · eb037279
      jacob berkman authored
      2001-10-22  jacob berkman  <jacob@ximian.com>
      
      	* gtk/gtkclist.c (cell_size_request): don't cast a PIXTEXT cell to
      	a PIXMAP cell (fixes crash when using PIXTEXT cells)
      eb037279
    • Owen Taylor's avatar
      Deprecate gtk_entry_set_editable. (#58768, Vitaly Tishkov) · 0c6a8f53
      Owen Taylor authored
      Sat Oct 20 18:58:25 2001  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkentry.h: Deprecate gtk_entry_set_editable.
              (#58768, Vitaly Tishkov)
      
              * gtk/gtkobject.h: Deprecate with abandon.
              (#61942, Vitaly Tishkov, Matthias Clasen)
      
              * gtk/gtksignal.h: Deprecate everything.
      
              * gtk/gtkmain.h (GTK_PRIORITY_INTERNAL): Deprecate
              all GTK_PRIORITY_* defines other than GKT_PRIORITY_RESIZE>
              (#61942, Matthias Clasen)
      
              * gtk/gtkstyle.h: Deprecate gtk_draw_*. (#61140,
              Havoc Pennington)
      
              * gtk/gtkitemfactory.h: Deprecate compat functions
              for GtkMenuFactory code. (#62071)
      
              * gdk/gdkdrawable.h: Deprecate gdk_draw_string,
              gdk_draw_text,gdk_draw_text_wc. (#62071)
      
              * gtk/{gtkentry.c,gtklabel.c,gtkoldeditable.c,gtktextview.c}:
              Use GDK_SELECTION_CLIPBOARD instead of GDK_NONE in calls
              to gtk_clipboard_get().
      0c6a8f53