1. 23 Jan, 2009 18 commits
    • Matthias Clasen's avatar
      i Bug 560228 – Add "action-controller" property to GtkWidgetClass · bb72b647
      Matthias Clasen authored
              Rework the way actions and proxies interact, to make the
              interaction less ad hoc, more extensible, and better suited
              for support in GUI builders like glade.
      
              To be used as a proxy, a widget must now implement the
              GtkActivatable interface, and GtkActivatable implementations
              are responsible for syncing their appearance with the action
              and for activating the action.
      
              All the widgets that are commonly used as proxies implement
              GtkActivatable now.
      
              Patch by Tristan van Berkom.
      
              * gtk/gtkactivatable.[hc]: The GtkActivatable interface.
      
              * gtk/gtkbutton.c:
              * gtk/gtktogglebutton.c:
              * gtk/gtktoolitem.c:
              * gtk/gtktoolbutton.c:
              * gtk/gtktoggletoolbutton.c:
              * gtk/gtkmenuitem.c:
              * gtk/gtkcheckmenuitem.c:
              * gtk/gtkimagemenuitem.c:
              * gtk/gtkradiomenuitem.c:
              * gtk/gtkrecentchooserprivate.h:
              * gtk/gtkrecentchooser.c:
              * gtk/gtkrecentchooserdefault.c:
              * gtk/gtkrecentchoosermenu.c: Implement GtkActivatable.
              * gtk/gtkaction.[hc]: Move appearance synchronization to
              GtkActivatable implementations.
      
              * gtk/gtkradioaction.c:
              * gtk/gtkrecentaction.c:
              * gtk/gtktoggleaction.c:
              * gtk/gtkactiongroup.c: Adapt.
      
              * gtk/gtk.h: Include gtkactivatable.h
              * gtk/gtk.symbols: Add new functions
      
      
      svn path=/trunk/; revision=22195
      bb72b647
    • Matthias Clasen's avatar
      Don't set up im stuff if the widget is not realized. · 280eeb02
      Matthias Clasen authored
              * gtk/gtktextview.c: Don't set up im stuff if the widget
              is not realized.
      
              * gtk/gtkimmodule.c: Assert that we have a window.
      
      
      svn path=/trunk/; revision=22193
      280eeb02
    • Matthias Clasen's avatar
      Skip Desktop if it equals the home folder · a220373a
      Matthias Clasen authored
      svn path=/trunk/; revision=22192
      a220373a
    • Matthias Clasen's avatar
      Keep GtkPlug in sync with the global list of toplevels. · 4569b49b
      Matthias Clasen authored
              Patch by Federico Mena Quintero
      
              * gtk/gtkwindow.h:
              * gtk/gtkwindow.c (_gtk_window_set_is_toplevel): New internal
              function used when a GtkPlug parents/unparents itself by an
              in-process GtkSocket.  This keeps the plug's GTK_TOPLEVEL flag in
              sync with the global toplevel_list.
      
              * gtk/gtkplug.c (gtk_plug_set_is_child): Call
              _gtk_window_set_is_toplevel() to keep the toplevel list updated,
              instead of just setting/unsetting the GTK_TOPLEVEL flag.
      
      
      svn path=/trunk/; revision=22191
      4569b49b
    • Matthias Clasen's avatar
      Fix typos · 5c99971a
      Matthias Clasen authored
      svn path=/trunk/; revision=22190
      5c99971a
    • Matthias Clasen's avatar
      Bug 567761 – Spellfixes in GTK+ documentation · 5c317ec7
      Matthias Clasen authored
              * gdk/x11/gdkselection-x11.c:
              * gtk/gtktestutils.c: Fix typos in the docs.
      
      
      svn path=/trunk/; revision=22189
      5c317ec7
    • Matthias Clasen's avatar
      Improve docs · b71609e2
      Matthias Clasen authored
      svn path=/trunk/; revision=22188
      b71609e2
    • Matthias Clasen's avatar
      Use a different approach to snapshotting that is in line with what is done · 379822c7
      Matthias Clasen authored
              * gtk/gtkwidget.c (gtk_widget_get_snapshot): Use a different approach
              to snapshotting that is in line with what is done in the client-side
              windows branch, and that works for widgets regardless if they are
              double-buffered or not. Patch by Alex Larsson.
      
              * gdk/gdkwindow.c (_gdk_window_calculate_full_clip_region): Clip
              to the parent.
      
      
      svn path=/trunk/; revision=22187
      379822c7
    • Federico Mena Quintero's avatar
      GtkFileChooserEntry: handle slow folders by not autocompleting when the cursor... · ba54644c
      Federico Mena Quintero authored
      GtkFileChooserEntry: handle slow folders by not autocompleting when the cursor is not at the end of the text
      2009-01-22  Federico Mena Quintero  <federico@novell.com>
      
      	* gtk/gtkfilechooserentry.c (autocomplete): Relax the assertion;
      	just do nothing if the folder is not loaded or if the cursor position
      	is not at the end of the text.  A very slow-to-load folder can get
      	us into the latter state if the user starts typing first.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22186
      ba54644c
    • Matthias Clasen's avatar
      Revert the previous change · 0b2554da
      Matthias Clasen authored
      svn path=/trunk/; revision=22185
      0b2554da
    • Federico Mena Quintero's avatar
      GtkFileChooserEntry: fix the computation of 'complete but not unique' and... · 7fde4a85
      Federico Mena Quintero authored
      GtkFileChooserEntry: fix the computation of 'complete but not unique' and appending a '/' to unique directory names
      2009-01-22  Federico Mena Quintero  <federico@novell.com>
      
      	Fix the computation of "complete but unique" in
      	GtkFileChooserEntry.  Fix the case where "/" was not appended to a
      	unique directory name during explicit Tab completion.
      
      	* gtk/gtkfilechooserentry.c (maybe_append_separator_to_file):
      	Return whether anything was appended as well as the new string
      	itself.
      	(find_common_prefix): Oops, only turn on
      	is_complete_not_unique_ret if we had a unique match!
      	(append_common_prefix): If we appended a directory separator, we
      	*did* expand the common prefix, so we are not in the "nothing
      	inserted" case.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22184
      7fde4a85
    • Federico Mena Quintero's avatar
      Comments for translators on the file chooser entry's completion feedback · a8b06ad5
      Federico Mena Quintero authored
      	(start_explicit_completion): Add comments for translators, to
      	explain the purpose of the various feedback messages used during
      	completion.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22183
      a8b06ad5
    • Federico Mena Quintero's avatar
      Pass refresh errors from the very bottom of the loading sequence up to the top · cabc9f7f
      Federico Mena Quintero authored
      	(start_loading_current_folder): Check if the folder to be loaded
      	is non-native for the local_only=TRUE case; if so, return an error
      	as we are configured to load only local folders.
      	(reload_current_folder): Pass on errors from
      	start_loading_current_folder().  Tighten the preconditions, as we
      	are sure that we can only receive non-NULL folder-files to load.
      	(refresh_current_folder_and_file_part): Pass on errors from
      	reload_current_folder().  At the very end, assert the invariant
      	described above.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22182
      cabc9f7f
    • Federico Mena Quintero's avatar
      Factor out function to discard the loading process and the current folder file · 7ba4268d
      Federico Mena Quintero authored
      	(discard_loading_and_current_folder_file): Factor out function to
      	cancel the cancellable and discard the current_folder_file,
      	i.e. to reset the invariant to the "nothing valid is loaded" case.
      	(gtk_file_chooser_entry_dispose): Use
      	discard_loading_and_current_folder_file().
      	(reload_current_folder): Likewise.
      	(refresh_current_folder_and_file_part): Likewise, and ensure that
      	the error cases result in the invariant being held.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22181
      7ba4268d
    • Federico Mena Quintero's avatar
      Process the result of refreshing the folder during autocompletion · fe636e4b
      Federico Mena Quintero authored
      	(start_autocompletion): Process the result from refresh...().  We
      	only do completion in the REFRESH_OK case.  For the error cases,
      	we don't do anything, as this is autocompletion and must not
      	result in non-asked-for errors popping up.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22180
      fe636e4b
    • Federico Mena Quintero's avatar
      Don't handle errors when committing the completion · c1205bbb
      Federico Mena Quintero authored
      	(commit_completion_and_refresh): Don't do anything with the result
      	of refresh...(), since this function doesn't get called during
      	completion-related interaction.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22179
      c1205bbb
    • Federico Mena Quintero's avatar
      Process the result of refreshing the folder during explicit completion · 65cd4f8d
      Federico Mena Quintero authored
      	(start_explicit_completion): Process the result from
      	refresh...().  Here we present the actual feedback about only
      	being able to display local folders for local_only=TRUE.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22178
      65cd4f8d
    • Federico Mena Quintero's avatar
      Return an error code when refreshing the entry from the user's input · 2dd7cf49
      Federico Mena Quintero authored
      2009-01-22  Federico Mena Quintero  <federico@novell.com>
      
      	Return an error code when refreshing the entry from the user's
      	input.  We use this in the completion code to know when completion
      	can't happen due to (for example) having a non-local URI in a file
      	chooser that is local_only=TRUE.
      
      	Also, we start maintaining an invariant that
      	chooser_entry->current_folder_file != NULL implies that:
      
      		* what the user entered is valid
      
      		* we are loading that folder (chooser_entry->load_folder_cancellable != NULL)
      
      		* or we are done loading that folder, or we have a handle
      		to it at least (chooser_entry->current_folder != NULL)
      
      	The invariant also says that all of the above are NULL (and
      	chooser_entry->current_folder_file == NULL) implies that the user
      	typed something invalid.  This makes
      	_gtk_file_chooser_entry_get_current_folder() not able to return
      	an invalid folder.
      
      	* gtk/gtkfilechooserentry.c (RefreshStatus): New enum.
      	(refresh_current_folder_and_file_part): Return a RefreshStatus.
      	We filter out incomplete hostnames here (typing
      	"sftp://incompl[tab]" will error out), as well as completely
      	unparsable input.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22177
      2dd7cf49
  2. 22 Jan, 2009 4 commits
  3. 21 Jan, 2009 10 commits
    • Matthias Clasen's avatar
      Change the Caps Lock warning to the more neutral "Caps Lock is on". · d2367d94
      Matthias Clasen authored
      009-01-21  Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtkentry.c: Change the Caps Lock warning to the more
              neutral "Caps Lock is on". Requested by Wouter Bolsterlee
      
      
      svn path=/trunk/; revision=22166
      d2367d94
    • Matthias Clasen's avatar
      Bug 568552 – gtk_combo + gtk entry in invisible mode takes 100% cpu · 579f457c
      Matthias Clasen authored
              * gtk/gtkentry.c: Fix an expose loop caused by raising windows out
              of an expose handler. Also, don't show the 'Caps Lock' warning for
              activated input methods, since that makes it permanently shown
              for some locales. It should not be that necessary, now that we
              do show preedit text even in password entries. Pointed out by
              Frederic Crozat.
      
      
      svn path=/trunk/; revision=22164
      579f457c
    • Federico Mena Quintero's avatar
      GtkFileChooser: only set local_only on the location entry if it exists · c6f4b327
      Federico Mena Quintero authored
      2009-01-21  Federico Mena Quintero  <federico@novell.com>
      
      	* gtk/gtkfilechooserdefault.c (save_widgets_create): Set
      	local_only on the location entry when we create it...
      	(set_local_only): ... and set it here only if the location entry
      	exists.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22163
      c6f4b327
    • Marek Kašík's avatar
      Bug 561801 - "scheduled printing" doesn't function as expected · 6dbb29a5
      Marek Kašík authored
      2009-01-21  Marek Kasik  <mkasik@redhat.com>
      	Bug 561801 - "scheduled printing" doesn't function as expected
      
      	* gtk/gtkprintunixdialog: Add tooltip.
      	* modules/printbackends/cups/gtkprintbackendcups.c: Add conversion
      	  from local time to utc time for scheduled printing.
      
      svn path=/trunk/; revision=22158
      6dbb29a5
    • Federico Mena Quintero's avatar
      Don't do completion in the middle of an incomplete hostname · e4bc68ba
      Federico Mena Quintero authored
      	Fix completion so it doesn't pop up for every character in a URI
      	hostname:
      
      	* gtk/gtkfilechooser.h (GtkFileChooserError): Add a
      	GTK_FILE_CHOOSER_ERROR_INCOMPLETE_HOSTNAME.
      
      	* gtk/gtkfilesystem.c (_gtk_file_system_parse): Return an
      	"incomplete hostname" error if the user has not typed a full
      	hostname yet in an URI.
      
      	* gtk/gtkfilechooserentry.c (append_common_prefix): If we get an
      	incomplete hostname, just don't pop up an error, since that is a
      	transient state and the user doesn't need to be notified about it.
      	(refresh_current_folder_and_file_part): Don't revert to showing
      	the base folder if we have an incomplete hostname.
      	(reload_current_folder): Handle the passed folder being NULL, even
      	if we must force a reload.  Also, reload the folder if we didn't
      	have a cancellable for it (i.e. we hadn't started to load it
      	before).
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22157
      e4bc68ba
    • Federico Mena Quintero's avatar
      Add a local_only property to GtkFileChooserEntry · 2c07a59e
      Federico Mena Quintero authored
      	Patch by Carlos Garnacho <carlos@imendio.com> - add a local_only
      	property to GtkFileChooserEntry:
      
      	* gtk/gtkfilechooserentry.c (struct _GtkFileChooserEntry): Add a
      	local_only field.
      	(_gtk_file_chooser_entry_init): Default to local_only being true.
      	(start_explicit_completion): Don't allow completion of non-native
      	files if local_only is turned on.
      	(start_loading_current_folder): Don't start loading non-native
      	folders if local_only is turned on.
      	(_gtk_file_chooser_entry_set_local_only): New function.
      	(_gtk_file_chooser_entry_get_local_only): New function.
      
      	* gtk/gtkfilechooserentry.h (_gtk_file_chooser_entry_set_local_only,
      	_gtk_file_chooser_entry_get_local_only): New prototypes.
      
      	* gtk/gtkfilechooserdefault.c (set_local_only): Set the local_only
      	property on the entry.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22156
      2c07a59e
    • Federico Mena Quintero's avatar
      Factor out code to discard the current_folder · 92ec0276
      Federico Mena Quintero authored
      Patch by Carlos Garnacho <carlos@imendio.com>:
      
      * gtk/gtkfilechooserentry.c (discard_current_folder): New
      function, factored out for when we need to get rid of the
      current_folder.
      (gtk_file_chooser_entry_dispose): Use discard_current_folder().
      (finished_loading_cb): Fix prototype.
      (load_directory_get_folder_callback): Discard the completion
      store, as well as clearing the completion feedback, if we find an
      error while loading the folder.  Also, use
      discard_current_folder().
      (reload_current_folder): Use discard_current_folder().
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22155
      92ec0276
    • Federico Mena Quintero's avatar
      bgo545980 - parse URIs in GtkFileChooserEntry · 9f62525f
      Federico Mena Quintero authored
      2009-01-15  Federico Mena Quintero  <federico@novell.com>
      
      	http://bugzilla.gnome.org/show_bug.cgi?id=545980 -
      	GtkFileChooserEntry should handle URIs
      
      	* gtk/gtkfilesystem.c (_gtk_file_system_parse): Detect URI schemes
      	and parse the full URI.
      	(has_uri_scheme): New function, stolen from the old
      	gtkfilesystemgnomevfs.c.
      Signed-off-by: 's avatarFederico Mena Quintero <federico@novell.com>
      
      svn path=/trunk/; revision=22154
      9f62525f
    • Matthias Clasen's avatar
      Add setters and getters for GtkAction properties, in preparation for bug · 3f185072
      Matthias Clasen authored
              * gtk/gtk.symbols:
              * gtk/gtkaction.[hc]: Add setters and getters for GtkAction
              properties, in preparation for bug 560228.
      
      
      svn path=/trunk/; revision=22153
      3f185072
    • Christian Dywan's avatar
      Bug 567413 – GtkComboBoxEntry doesn't emit "changed" signal on entry · a8cc721e
      Christian Dywan authored
      2009-01-21  Christian Dywan  <christian@twotoasts.de>
      
      	Bug 567413 – GtkComboBoxEntry doesn't emit "changed" signal
              on entry editing
      
      	* gtk/gtkcombobox.c (gtk_combo_box_set_active): Return only if index
              is set. Patch by Carl-Anton Ingmarsson.
      
      svn path=/trunk/; revision=22152
      a8cc721e
  4. 20 Jan, 2009 3 commits
    • Torsten Schönfeld's avatar
      Add a "Since: 2.16" tag to gtk_style_get. · 71a975f6
      Torsten Schönfeld authored
      svn path=/trunk/; revision=22151
      71a975f6
    • Matthias Clasen's avatar
      Bug 565656 – Add marks to scales · 26490a2d
      Matthias Clasen authored
      
              Bug 565656 – Add marks to scales
      
              * gtk/gtkrange.[hc]: Add internal api to define 'stop values'
              that have a little resistance when dragging the slider over it.
      
              * gtk/gtk.symbols:
              * gtk/gtkscale.[hc] (gtk_scale_add_mark): New function to add
              a 'mark' to a scale, which will draws a tick, plus optionally
              some text, and makes the value a stop value.
              (gtk_scale_clear_values): Removes all marks.
      
              * tests/testscale.c: Test for marks on scales
              * tests/Makefile.am: Integrate it
      
      
      svn path=/trunk/; revision=22149
      26490a2d
    • Matthias Clasen's avatar
      Replace several implementation of blank cursor setting by · b6b52376
      Matthias Clasen authored
              * gtk/gtkentry.c:
              * gtk/gtkfilechooserentry.c:
              * gtk/gtktextview.c: Replace several implementation of
              blank cursor setting by GDK_BLANK_CURSOR.
      
      
      svn path=/trunk/; revision=22148
      b6b52376
  5. 19 Jan, 2009 2 commits
  6. 18 Jan, 2009 3 commits