1. 05 Nov, 2015 1 commit
  2. 02 Jun, 2015 1 commit
  3. 30 Aug, 2014 1 commit
  4. 27 Mar, 2014 1 commit
  5. 19 Feb, 2014 1 commit
  6. 15 Feb, 2014 1 commit
  7. 09 Feb, 2014 1 commit
  8. 07 Feb, 2014 2 commits
  9. 05 Feb, 2014 1 commit
  10. 02 Feb, 2014 1 commit
  11. 29 Jan, 2014 2 commits
  12. 28 Jan, 2014 1 commit
  13. 14 Jan, 2014 1 commit
  14. 09 Jul, 2013 1 commit
  15. 05 Dec, 2012 1 commit
  16. 17 Jul, 2012 1 commit
  17. 19 Mar, 2012 1 commit
  18. 27 Feb, 2012 1 commit
  19. 15 Oct, 2011 1 commit
  20. 03 Oct, 2011 2 commits
    • Kristian Rietveld's avatar
      Bug 659022 - gtk_tree_model_filter_clear_cache_helper: assertion failed · bbc1e883
      Kristian Rietveld authored
      This bug is resolved by fixing two things in
      gtk_tree_model_filter_row_deleted():
      
        (1) It is possible for an elt to have elt->visible_siter == NULL, when
        it is deleted.  Only call g_sequence_remove() if this pointer is
        non-NULL.
      
        (2) For the case len (level->seq) > 1, free the elt->children level
        if non-NULL.  Failing to do this means the level will stick around.
        If this child level was not referenced, it will still have a zero
        ref count on its parent which cannot be removed!
      
      For both bugs unit tests have been added in the preceding commit.
      bbc1e883
    • Kristian Rietveld's avatar
      Fix first part of bug 659022 · f646ed6f
      Kristian Rietveld authored
      Push creation of path into if clause, the path cannot be created anyway
      (and would be meaningless otherwise) if the parent is not visible.
      f646ed6f
  21. 20 Sep, 2011 1 commit
  22. 17 Sep, 2011 1 commit
  23. 11 Sep, 2011 5 commits
  24. 07 Sep, 2011 4 commits
    • Kristian Rietveld's avatar
      gtktreemodelfilter: child levels of the root level must remain cached · 022327c4
      Kristian Rietveld authored
      This is due to the special handling for filter functions that depend
      on child level state.  If the parent level of a level is the root level,
      the level cannot be removed from the cache.  Any change in this level
      can cause its parent in the root level to become visible again.
      022327c4
    • Kristian Rietveld's avatar
      gtktreemodelfilter: rework gtk_tree_model_filter_remove_elt_from_level · ae2b2e7c
      Kristian Rietveld authored
      The most important change is that the function now properly releases
      any external ref count and propagates these changes to the child model.
      If a node is removed due to a filtering action, we now properly release
      all external reference counts for its hierarchy of child nodes.
      
      Apart from that, the function has been restructured to remove code
      duplication.
      
      Finally, there is still some doubt whether there are more calls to
      gtk_tree_model_filter_free_level() which need unref_external set to TRUE.
      ae2b2e7c
    • Kristian Rietveld's avatar
      gtktreemodelfilter: add a debug define and more assertions · 767b2e26
      Kristian Rietveld authored
      Should be helpful when debugging this thing.  Perhaps this needs to
      be properly integrated in G_DEBUG/GTK_DEBUG, but currently I do not see
      the need to.
      767b2e26
    • Kristian Rietveld's avatar
      gtktreemodelfilter: make rule used for level caching consistent · f317dd38
      Kristian Rietveld authored
      There was still a discrepancy between the comments and the code about when
      exactly a level was to be removed.  The rule is now set on that for a level
      to be removed its zero_ref_count as well as the zero_ref_count of its
      parent has to be zero.
      f317dd38
  25. 22 Aug, 2011 6 commits