1. 18 Mar, 2015 1 commit
  2. 07 Jan, 2015 2 commits
  3. 29 Aug, 2014 1 commit
  4. 16 Aug, 2014 1 commit
  5. 22 May, 2014 1 commit
  6. 05 May, 2014 1 commit
  7. 17 Sep, 2013 1 commit
  8. 03 Jul, 2013 1 commit
  9. 05 May, 2013 1 commit
  10. 28 Mar, 2013 1 commit
    • Benjamin Otte's avatar
      cssvalue: At cycle detection to color resolving · cbee3901
      Benjamin Otte authored
      The following CSS would infloop:
      
      @define-color self @self
      
      as it would infinitely lookup the color named "self" and try to resolve
      it. This patch adds detection of such cycles to the resolve function by
      keeping a list of currently resolving colors in the cycle_list variable.
      cbee3901
  11. 25 Nov, 2012 4 commits
  12. 24 Nov, 2012 1 commit
  13. 02 Oct, 2012 1 commit
  14. 28 Sep, 2012 2 commits
    • Benjamin Otte's avatar
      css: Huge refactoring to avoid computing wrong values · 1454ba15
      Benjamin Otte authored
      Here's the shortest description of the bug I can come up with:
      When computing values, we have 3 kinds of dependencies:
      (1) other properties ("currentColor" or em values)
      (2) inherited properties ("inherit")
      (3) generic things from the theme (@keyframes or @define-color)
      Previously, we passed the GtkStyleContext as an argument, because it
      provided these 3 things using:
      (1) _gtk_style_context_peek_property()
      (2) _gtk_style_context_peek_property(gtk_style_context_get_parent())
      (3) context->priv->cascade
      
      However, this makes it impossible to lookup values other than the ones
      accessible via _gtk_style_context_peek_property(). And this is exactly
      what we are doing in gtk_style_context_update_cache(). So when the cache
      updates encountered case (1), they were looking up the values from the
      wrong style data.
      
      So this large patch essentially does nothing but replace the
      context argument in all compute functions with new arguments for the 3
      cases above:
      (1) values
      (2) parent_values
      (3) provider
      
      We apparently have a lot of computing code.
      1454ba15
    • Benjamin Otte's avatar
      css: Don't crash when printing gradients · 5c4fc16c
      Benjamin Otte authored
      ... in the fallback code. Instead print a FIXME.
      5c4fc16c
  15. 28 Aug, 2012 3 commits
  16. 11 May, 2012 2 commits
  17. 17 Apr, 2012 11 commits
  18. 08 Mar, 2012 2 commits
    • Alexander Larsson's avatar
      Use GtkCssValue in symbolic color resolving · 616cc5b9
      Alexander Larsson authored
      We now store the symbolic colors as a GtkCssValue which means that
      we can reuse the color when resolving and storing the color in
      the computed values in the style context.
      
      Additionally we keep a last_resolved GtkCssValue cache in the
      GtkSymbolicColor, and if resolving the color returns the same as
      last time we reuse the old value. This further increases sharing
      of Css Values.
      616cc5b9
    • Alexander Larsson's avatar
      css: Use GtkCssValues instead of GValue in the css machinery · 7603e6e4
      Alexander Larsson authored
      Also, in places where we're computing a new CssValue based on an
      old one, make sure that if nothing changes we're returning a reference
      to the old one, rather than creating a new identical instance.
      7603e6e4
  19. 27 Feb, 2012 1 commit
  20. 02 Feb, 2012 2 commits