1. 29 Sep, 2005 5 commits
    • Tor Lillqvist's avatar
      DLLs are always in bin nowadays, no need to test. · 840796df
      Tor Lillqvist authored
      2005-09-29  Tor Lillqvist  <tml@novell.com>
      
      	* gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
      840796df
    • Federico Mena Quintero's avatar
      Oops, return if the unmap test fails. (test_reload_sequence): Use · e14ad12b
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/autotestfilechooser.c (test_reload_sequence): Oops, return
      	if the unmap test fails.
      	(test_reload_sequence): Use gtk_widget_show_now() instead of
      	gtk_widget_show() for the dialog.
      	Thanks to Tim Janik for noticing these.
      e14ad12b
    • Federico Mena Quintero's avatar
      Add a comment - Federico · c5d43cdb
      Federico Mena Quintero authored
      c5d43cdb
    • Federico Mena Quintero's avatar
      New file with a set of tests for GtkCellRendererText. The idea is to run a · 3e9f549d
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/testcellrenderertext.c: New file with a set of tests for
      	GtkCellRendererText.  The idea is to run a text renderer through
      	most of its interesting property values to see that it works
      	correctly.
      
      	* tests/Makefile.am: Added testcellrenderertext.
      
      	* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
      	entry/exit of this function for profiling.
      	(gtk_file_chooser_default_style_set): Mark the start/end of the
      	calls to the parent class and the the signal emission for profiling.
      3e9f549d
    • Federico Mena Quintero's avatar
      New file with a set of tests for GtkCellRendererText. The idea is to run a · 77b52249
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/testcellrenderertext.c: New file with a set of tests for
      	GtkCellRendererText.  The idea is to run a text renderer through
      	most of its interesting property values to see that it works
      	correctly.
      
      	* tests/Makefile.am: Added testcellrenderertext.
      
      	* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
      	entry/exit of this function for profiling.
      	(gtk_file_chooser_default_style_set): Mark the start/end of the
      	calls to the parent class and the the signal emission for profiling.
      77b52249
  2. 28 Sep, 2005 7 commits
    • Tor Lillqvist's avatar
      The locale directory is passed to bindtextdomain() which isn't · 4ac3ee58
      Tor Lillqvist authored
      2005-09-29  Tor Lillqvist  <tml@novell.com>
      
      	* gtk/gtkmain.c (_gtk_get_localedir): The locale directory is
      	passed to bindtextdomain() which isn't UTF-8-aware, so convert to
      	system codepage using g_win32_locale_filename_from_utf8().
      	(#317457, Kazuki Iwamoto)
      4ac3ee58
    • Matthias Clasen's avatar
      Free mult_atoms here. (#317039, Paolo Borelli) · d1a3c8dc
      Matthias Clasen authored
      2005-09-28  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkselection.c (_gtk_selection_request): Free mult_atoms
      	here. (#317039, Paolo Borelli)
      d1a3c8dc
    • Matthias Clasen's avatar
      Change header too · f5b53f13
      Matthias Clasen authored
      f5b53f13
    • Matthias Clasen's avatar
      Return the attributes to make this function work as boxed copy function. · 037e90b8
      Matthias Clasen authored
      2005-09-28  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktexttag.c (gtk_text_attributes_ref): Return the attributes
      	to make this function work as boxed copy function.  (#317455,
      	Gustavo Carneiro)
      037e90b8
    • Matthias Clasen's avatar
      Don't unref NULL. (#316828, Tor Lillqvist) · d52e81d5
      Matthias Clasen authored
      2005-09-28  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkclipboard.c (request_image_received_func): Don't unref
      	NULL.  (#316828, Tor Lillqvist)
      d52e81d5
    • Tor Lillqvist's avatar
      Include <config.h>. (#317444, Kazuki Iwamoto) · 2f4eb8fd
      Tor Lillqvist authored
      2005-09-28  Tor Lillqvist  <tml@novell.com>
      
      	* modules/input/imime.c: Include <config.h>. (#317444, Kazuki
      	Iwamoto)
      2f4eb8fd
    • Federico Mena Quintero's avatar
      Don't reload the current folder unnecessarily on ::map(). · 6cd6a0a2
      Federico Mena Quintero authored
      2005-09-27  Federico Mena Quintero  <federico@ximian.com>
      
      	Don't reload the current folder unnecessarily on ::map().
      
      	* gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
      	the reloading state.
      	(struct _GtkFileChooserDefault): Added a "reload_state" field.
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
      	Initialize impl->reload_state.
      	(gtk_file_chooser_default_map): Check the impl->reload_state; load
      	a default folder if no folder has been set, or reload the current
      	one only if we had been unmapped first.
      	(gtk_file_chooser_default_update_current_folder): Set the
      	reload_state to RELOAD_HAS_FOLDER.
      	(gtk_file_chooser_default_unmap): Implement, and set the
      	reload_state to RELOAD_WAS_UNMAPPED.
      	(shortcuts_model_create): Don't call shortcuts_add_bookmarks()
      	here; they'll get (re)loaded on ::map() anyway.
      
      	* gtk/gtkfilechooserwidget.c
      	(gtk_file_chooser_widget_constructor): Don't set a default folder here.
      
      	* tests/autotestfilechooser.c (test_action_widgets): Don't take in
      	a dialog; build it ourselves.
      	(test_reload): New test to ensure that we don't load the default
      	folder more than once, and that we reload it when
      	unmapping/remapping.
      	(get_impl_from_dialog): New utility function.
      	(test_widgets_for_current_action): Use get_impl_from_dialog().
      6cd6a0a2
  3. 27 Sep, 2005 4 commits
    • Federico Mena Quintero's avatar
      Don't reload the current folder unnecessarily on ::map(). · 72851a22
      Federico Mena Quintero authored
      2005-09-27  Federico Mena Quintero  <federico@ximian.com>
      
      	Don't reload the current folder unnecessarily on ::map().
      
      	* gtk/gtkfilechooserprivate.h (ReloadState): New enum to represent
      	the reloading state.
      	(struct _GtkFileChooserDefault): Added a "reload_state" field.
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init):
      	Initialize impl->reload_state.
      	(gtk_file_chooser_default_map): Check the impl->reload_state; load
      	a default folder if no folder has been set, or reload the current
      	one only if we had been unmapped first.
      	(gtk_file_chooser_default_update_current_folder): Set the
      	reload_state to RELOAD_HAS_FOLDER.
      	(gtk_file_chooser_default_unmap): Implement, and set the
      	reload_state to RELOAD_WAS_UNMAPPED.
      	(shortcuts_model_create): Don't call shortcuts_add_bookmarks()
      	here; they'll get (re)loaded on ::map() anyway.
      
      	* gtk/gtkfilechooserwidget.c
      	(gtk_file_chooser_widget_constructor): Don't set a default folder here.
      
      	* tests/autotestfilechooser.c (test_action_widgets): Don't take in
      	a dialog; build it ourselves.
      	(test_reload): New test to ensure that we don't load the default
      	folder more than once, and that we reload it when
      	unmapping/remapping.
      	(get_impl_from_dialog): New utility function.
      	(test_widgets_for_current_action): Use get_impl_from_dialog().
      72851a22
    • Federico Mena Quintero's avatar
      Mark the entry/exit of this function for profiling. (check_icon_theme): · 58a2a796
      Federico Mena Quintero authored
      2005-09-27  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_constructor): Mark the entry/exit of
      	this function for profiling.
      	(check_icon_theme): Likewise.
      	(change_icon_theme): Likewise.
      	(settings_notify_cb): Likewise.
      	(gtk_file_chooser_default_screen_changed): Likewise.
      	(update_chooser_entry): If the selection is empty, clear the file
      	name entry only if we are in CREATE_FOLDER mode.  In SAVE mode,
      	nothing will be selected when the user starts typeahead in the
      	treeview, and we don't want to clear the file name entry in that
      	case --- the user could be typing-ahead to look for a folder name.
      	Fixes bug #308332, patch by Jürg Billeter.
      58a2a796
    • Matthias Clasen's avatar
      Pop below the entry if there's more free space below the entry than above. · aa79f94a
      Matthias Clasen authored
              * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
              Pop below the entry if there's more free space below the entry
              than above.  (#316948, Tommi Komulainen)
      aa79f94a
    • Federico Mena Quintero's avatar
      Do not create the save mode-specific widgets in the open modes, so that we · e9465843
      Federico Mena Quintero authored
      2005-09-26  Federico Mena Quintero  <federico@ximian.com>
      
      	Do not create the save mode-specific widgets in the open modes, so
      	that we don't carry their baggage around.
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_constructor): Don't create the
      	save_widgets here.
      	(save_widgets_create): Set the impl->save_widgets directly here,
      	instead of passing the widgets back to the caller.  Also, pack
      	them into the impl's box.
      	(update_appearance): Create or destroy the save widgets as
      	appropriate.  Set the action of the save_file_name_entry here.
      	(shortcuts_add_current_folder): Set the active item in the
      	save_folder_combo only if it exists.
      	(gtk_file_chooser_default_set_property): Don't set the action of
      	the save_file_name_entry here.
      	(gtk_file_chooser_default_update_current_folder): Set the base
      	folder of the save_file_name_entry only if the entry exists.
      	(shortcuts_drag_data_received_cb): Cast the selection_data->data
      	to (const char *) since that's what shortcuts_drop_uris() expects.
      	(file_list_drag_data_received_cb): Likewise, for
      	g_uri_list_extract_uris().
      e9465843
  4. 26 Sep, 2005 3 commits
    • Tor Lillqvist's avatar
      Set the shaped flag here, too. (#316871) · bca0cefe
      Tor Lillqvist authored
      2005-09-26  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkwindow-win32.c (gdk_window_shape_combine_mask): Set
      	the shaped flag here, too. (#316871)
      	(gdk_window_shape_combine_region): Currently unimplemented, so
      	don't do anything to the shaped flag here.
      bca0cefe
    • Matthias Clasen's avatar
      Fix #316871, reported by Dan Winship: · 44012804
      Matthias Clasen authored
      2005-09-26  Matthias Clasen  <mclasen@redhat.com>
      
      	Fix #316871, reported by Dan Winship:
      
      	* gdk/gdkwindow.h (struct _GdkWindowObject): Add a shaped flag.
      
      	* gdk/x11/gdkwindow-x11.c (gdk_window_shape_combine_mask)
      	(gdk_window_shape_combine_region): Set it here.
      
      	* gdk/gdkwindow.c (gdk_window_invalidate_maybe_recurse): Don't
      	remove the child area for shaped windows.
      44012804
    • Matthias Clasen's avatar
      Fix a comment. · 3392bdad
      Matthias Clasen authored
      2005-09-26  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/tmpl/gcs.sgml: Fix a comment.
      3392bdad
  5. 24 Sep, 2005 2 commits
  6. 23 Sep, 2005 1 commit
  7. 22 Sep, 2005 3 commits
  8. 20 Sep, 2005 5 commits
    • Tor Lillqvist's avatar
      Free return value from gdk_atom_name(). · 67a0d5df
      Tor Lillqvist authored
      2005-09-21  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkselection-win32.c (gdk_selection_convert,
      	gdk_text_property_to_text_list_for_display,
      	gdk_text_property_to_utf8_list_for_display,
      	gdk_win32_selection_add_targets,
      	_gdk_win32_selection_convert_to_dib): Free return value from
      	gdk_atom_name().
      	(gdk_text_property_to_text_list_for_display): Drop GError variable
      	that isn't actually used after being set.
      67a0d5df
    • Johan Dahlin's avatar
      Mention NULL in documentation. · a8a097c0
      Johan Dahlin authored
          * gtk/gtkentry.c (gtk_entry_set_completion): Mention NULL in
          documentation.
      a8a097c0
    • Tim Janik's avatar
      added anchor. complexity doesn't get worse than O(n^2) with recent glib. · aecc12a9
      Tim Janik authored
      Tue Sep 20 17:16:50 2005  Tim Janik  <timj@imendio.com>
      
              * gtk/tmpl/gtkrc.sgml: added anchor. complexity doesn't get worse
              than O(n^2) with recent glib.
      aecc12a9
    • Tor Lillqvist's avatar
      Do return the correct owner for CLIPBOARD (i.e., the owner of the Windows · d46d791d
      Tor Lillqvist authored
      2005-09-20  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkselection-win32.c
      	(gdk_selection_owner_get_for_display): Do return the correct owner
      	for CLIPBOARD (i.e., the owner of the Windows Clipboard, if it is
      	a window GDK knows about). The reason to return NULL seems to have
      	gone when in the fix for bug #163702 the artificial
      	GDK_SELECTION_CLEAR event generation was removed from
      	gdk_selection_send_notify_for_display(). Fixes bug #316552.
      d46d791d
    • Matthias Clasen's avatar
      *** empty log message *** · cd63ed1e
      Matthias Clasen authored
      cd63ed1e
  9. 19 Sep, 2005 3 commits
  10. 18 Sep, 2005 5 commits
    • Hans Breuer's avatar
      now handling events by hard-coded g_signal_emit_by_name() - will break · 7e1f4b5e
      Hans Breuer authored
      2005-09-18  Hans Breuer  <hans@breuer.org>
      
      	* gtk/gtktrayicon-win32.c : now handling events by hard-coded
      	g_signal_emit_by_name() - will break when gtkstatusicon.c changes.
      7e1f4b5e
    • Hans Breuer's avatar
      export _gdk_win32_pixbuf_to_hicon() as · 99b5586a
      Hans Breuer authored
      2005-09-18  Hans Breuer  <hans@breuer.org>
      
      	* gdk/gdk.symbols gdk/win32/gdkwin32.h gdk/win32/gdkcursorwin32.c : export
      	_gdk_win32_pixbuf_to_hicon() as gdk_win32_pixbuf_to_hicon_libgtk_only()
      	* gtk/gtktrayicon-win32.c : a lot of debug spew but it has started to show
      	the icon and is blinking with teststatusicon. More to come ...
      99b5586a
    • Hans Breuer's avatar
      fix typo for GTK_VER; define HAVE_CONFIG_H cause gtkprogressbar.c has · e5d06c7c
      Hans Breuer authored
      2005-09-18  Hans Breuer  <hans@breuer.org>
      
      	* gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
      	cause gtkprogressbar.c has #include <config.h> conditionally; less
      	noise from generated gtk.def
      	* gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
      
      	* gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
      	For me it works as well as the *NIX implemenation, that is not at all.
      
      	* gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
      
      	* gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
      	only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
      	back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
      	again - if compiled properly.
      
      	* tests/teststatusicon.c : don't use GNOME icons for testing, but icons
      	already coming with Gtk+. Makes it compile on win32.
      e5d06c7c
    • Hans Breuer's avatar
      fix typo for GTK_VER; define HAVE_CONFIG_H cause gtkprogressbar.c has · 1127a03f
      Hans Breuer authored
      2005-09-18  Hans Breuer  <hans@breuer.org>
      
      	* gtk/makefile.msc.in : fix typo for GTK_VER; define HAVE_CONFIG_H
      	cause gtkprogressbar.c has #include <config.h> conditionally; less
      	noise from generated gtk.def
      	* gtk/stock-icons/makefile.msc gdk/makefile.msc tests/makefile.msc : updated
      
      	* gtk/gtktrayicon-win32.c : dummy implmentation to make gtk compile.
      	For me it works as well as the *NIX implemenation, that is not at all.
      
      	* gdk/win32/gdkproperty-win32.c : implement gdk_atom_intern_static_string()
      
      	* gdk/win32/gdkwindow-win32.c(gdk_window_set_urgency_hint) : only use
      	only use (WINVER >= 0x0500) when available from the SDK. Otherwise fall
      	back to true dynamic linking of FlashWindowEx. Makes gtk+ work on NT4.0
      	again - if compiled properly.
      
      	* tests/teststatusicon.c : don't use GNOME icons for testing, but icons
      	already coming with Gtk+. Makes it compile on win32.
      1127a03f
    • Guilherme de S. Pastore's avatar
      baf847bd
  11. 15 Sep, 2005 2 commits
    • Tor Lillqvist's avatar
      Check whether the widget actually is a GtkNotebook before treating it as · 6c544097
      Tor Lillqvist authored
      2005-09-16  Tor Lillqvist  <tml@novell.com>
      
      	* modules/engines/ms-windows/msw_style.c (draw_extension,
      	draw_box_gap): Check whether the widget actually is a GtkNotebook
      	before treating it as such. Drop some unneeded local variables,
      	use parameter with same information instead. (#316412)
      6c544097
    • Federico Mena Quintero's avatar
      Start a set of automated tests for the file chooser. The only test in · 329bc4e2
      Federico Mena Quintero authored
      2005-09-15  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/autotestfilechooser.c: Start a set of automated tests for
      	the file chooser.  The only test in there right now doesn't pass
      	yet.  It specifies the intended behavior of the first optimization
      	of a series which I'll do on the file chooser (see
      	http://primates.ximian.com/~federico/news-2005-09.html#14 for the
      	details of this optimization).
      
      	* tests/Makefile.am: Added autotestfilechooser.c.
      
      	* gtk/gtkfilechooserprivate.h (struct
      	_GtkFileChooserDialogPrivate): Move all the file chooser's private
      	structures to here, so that they can be accessed by
      	tests/autotestfilechooser.c:  _GtkFileChooserDialogPrivate,
      	_GtkFileChooserWidgetPrivate, LoadState, _GtkFileChooserDefault.
      
      	* gtk/gtkfilechooserdialog.c: See above.
      
      	* gtk/gtkfilechooserwidget.c: See above.
      
      	* gtk/gtkfilechooserdefault.c: See above.
      329bc4e2