1. 11 Feb, 2018 1 commit
    • Emmanuele Bassi's avatar
      selection: Disable deprecation warnings · 81c0e7af
      Emmanuele Bassi authored
      We are using a lot of deprecated API, and we know it.
      
      Since the selection code is going to be replaced in GTK 4.0, there's no
      real point in keeping the warnings enabled in 3.22.
      81c0e7af
  2. 30 Nov, 2017 1 commit
    • LRN's avatar
      GDK W32: Special handling for DELETE requests · 3fd23fcf
      LRN authored
      1) Ensure that any DELETE requests from the target are sent to GDK, even if
         both the source and the target are in the same process and it
         is therefore possible to use a shortcut and call the handler directly
         in GTK layer
      2) Ensure that target GDK doesn't do anything when GTK asks it to send
         a DELETE request, just report back immediately (the code up the stack
         does not check for successfullness when request is DELETE, so not giving
         it any data is OK).
      
      The source code already synthesizes a DELETE request, so that side is
      also taken care of.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=786509
      3fd23fcf
  3. 25 Nov, 2017 1 commit
    • LRN's avatar
      W32: Massive W32 DnD fix · 8caba953
      LRN authored
      Massive changes to OLE2 DnD protocol, which was completely broken before:
      * Keep GdkDragContext and OLE2 objects separate (don't ref/unref them
        together, don't necessarily create them together).
      * Keep IDataObject formats in the object itself, not in a global variable.
      * Fix getdata() to look up the request target in its format list, not in the
        global hash table
      * Create target GdkDragContext on each drag_enter, destroy it on drag_leave,
        whereas IDropTarget is created when a window becomes a drag destination
        and is re-used indefinitely.
      * Query the source IDataObject for its supported types, cache them in the
        target (!) context. This is how GTK+ works, honestly.
      * Remember current_src_object when we initiate a drag, to be able
        to detect later on that the data object is ours and use a
        shortcut when querying targets
      * Make sure GDK_DRAG_MOTION is only sent when something changes
      * Support GTK drag cursors
      * Ensure that exotic GTK clipboard formats are registered
        (but try to avoid registering formats that can't be used between applications).
      * Don't enumerate internal formats
      * Ensure that DnD indicator window can't accept drags or receive any kind of input
        (use WS_EX_TRANSPARENT).
      * Remove unneeded indentation in _gdk_win32_dnd_do_dragdrop()
      * Fix indentation in gdk_win32_drag_context_drop_finish()
      * Remove obsolete comments in _gdk_win32_window_register_dnd()
      * Check for DnD in progress when processing WM_KILLFOCUS, don't emit a grab
        break event in such cases (this allows alt-tabbing while DnD is in progress,
        though there may be lingering issues with focus after dropping...)
      * Support Shell ID List -> text/uri-list conversion, now it's possible
        to drop files (dragged from Explorer) on GTK+ applications
      * Explicitly use RegisterClipboardFormatA() when we know that the string
        is not in unicode. Otherwise explicitly use RegisterClipboardFormatW()
        with a UTF8->UTF16 converted string
      * Fix _gdk_win32_display_get_selection_owner() to correctly bail
        when selection owner HWND is NULL (looking up GdkWindow for NULL
        HWND always succeeds and returns the root window - not the intended
        effect)
      * More logging
      * Send DROP_FINISHED event after DnD loop ends
      * Send STATUS event on feedback
      * Move GetKeyboardState() and related code into _gdk_win32_window_drag_begin(),
        so that it's closer to the point where last_pt and start_pt are set
      * Use & 0x80 to check for the key being pressed. Windows will set low-order bit
        to 1 for all mouse buttons to indicate that they are toggled, so simply
        checking for the value not being 0 is not enough anymore.
        This is probably a new thing in modern W32 that didn't exist before
        (OLE2 DnD code is old).
      * Fixed (hopefully) and simplified HiDPI parts of the code.
      
      Also adds managed DnD implementation for W32 GDK backend (for both
      OLE2 and LOCAL protocols). Mostly a copy of the X11 backend code, but
      there are some minor differences:
      * doesn't use drag_window field in GdkDragContext,
        uses the one in GdkWin32DragContext exclusively
      * subtracts hotspot offset from the window coordinates when showing
        the dragback animation
      * tries to consistently support scaling and caches the scale
        in the context
      * Some keynav code is removed (places where grabbing/ungrabbing should
        happen is marked with TODOs), and the rest is probably inert.
      
      Also significantly changes the way selection (and clipboard) is handled
      (as MSDN rightly notes, the handling for DnD and Clipboard
       formats is virtually the same, so it makes sense to handle
       both with the same code):
      * Don't spam GDK_OWNER_CHANGE, send them only when owner
        actually changes
      * Open clipboard when our process becomes the clipboard owner
        (we are doing it anyway, to empty the clipboard and *become* the owner),
        and then don't close it until a scheduled selection request event
        (with TARGETS target) is received. Process that event by announcing
        all of our supported formats (by that time add_targets() should have
        been called up the stack, thus the formats are known; just in case,
        add_targets() will also schedule a selection request, if one isn't
        scheduled already, so that late-coming formats can still be announced).
      * Allow clipboard opening for selection_convert() to be delayed if it
        fails initially.
      * The last two points above should fix all the bugs about GTK+ rising
        too much ruckus over OpenClipboard() failures, as owner change
        *is allowed* to fail (though not all callers currently handle
        that case), and selection_convert() is asynchronous to begin with.
        Still, this is somewhat risky, as there's a possibility that the
        code will work in unexpected ways and the clipboard will remain open.
        There's now logging to track the clipboard being opened and closed,
        and a number of failsafes that try to ensure that it isn't kept open
        for no reason.
      * Added copious notes on the way clipboard works on X11, Windows and GDK-W32,
        also removed old comments in DnD implementation, replaced some of them
        with the new ones
      * A lot of crufty module-global variables are stuffed into a singleton
        object, GdkWin32Selection. It's technically possible to make it a
        sub-object of the Display object (the way Wayland backend does),
        but since Display object on W32 is a singleton anyway... why bother?
      * Fixed the send_change_events() a bit (was slightly broken in one of the
        previous iterations)
      * Ensure that there's no confusion between selection conversion (an artifact
        term from X11) and selection transmutation (changing the data to be W32-compatible)
      * Put all the transmutation code and format-target-matching code into gdkselection-win32.c,
        now this code isn't spread across multiple files.
      * Consequently, moved some code away from gdkproperty-win32.c and gdkdnd-win32.c
      * Extensive format transmutation checks for OLE2 DnD and clipboard.
        We now keep track of which format mappings are for transmutations,
        and which aren't (for example, when formats are passed as-is, or when
        a registered name is just an alias)
      * Put transmutation code into separate functions
      
      * Ensure that drop target keeps a format->target map for supported formats,
        this is useful when selection_convert() is called, as it only receives a
        single target and no hints on the format from which the data should
        be transmuted into this target.
      * Add clear_targets() on W32, to de called by GTK
      * Use g_set_object() instead of g_ref_object() where it is allowed.
      * Fix indentation (and convert tabs to spaces), remove unused variables
      
      https://bugzilla.gnome.org/show_bug.cgi?id=786509
      8caba953
  4. 22 Oct, 2015 1 commit
  5. 20 Oct, 2015 1 commit
  6. 28 Oct, 2014 1 commit
  7. 01 Sep, 2014 2 commits
  8. 20 Aug, 2014 1 commit
  9. 22 Jul, 2014 1 commit
  10. 12 Jun, 2014 1 commit
  11. 30 May, 2014 1 commit
  12. 28 May, 2014 1 commit
  13. 15 Apr, 2014 1 commit
  14. 19 Feb, 2014 1 commit
  15. 09 Feb, 2014 1 commit
  16. 07 Feb, 2014 3 commits
  17. 05 Feb, 2014 1 commit
  18. 28 Jan, 2014 2 commits
  19. 22 Jan, 2014 1 commit
  20. 21 Jan, 2014 1 commit
  21. 14 Dec, 2013 1 commit
  22. 13 Dec, 2013 1 commit
  23. 23 Oct, 2013 1 commit
  24. 09 Oct, 2013 1 commit
  25. 10 Sep, 2013 1 commit
  26. 02 Jul, 2012 1 commit
  27. 27 Feb, 2012 1 commit
  28. 07 Sep, 2011 1 commit
  29. 01 Feb, 2011 1 commit
  30. 20 Jan, 2011 4 commits
  31. 15 Jan, 2011 1 commit
  32. 03 Jan, 2011 1 commit
  33. 21 Dec, 2010 1 commit