1. 17 Feb, 2017 1 commit
  2. 18 Nov, 2016 1 commit
  3. 29 Aug, 2016 1 commit
  4. 10 Mar, 2016 2 commits
    • Federico Mena Quintero's avatar
    • Federico Mena Quintero's avatar
      GtkFileChooserEntry: regenerate the completions if the dir_part changes · 81059c35
      Federico Mena Quintero authored
      Consider this bug:
      
      1. Open a file chooser; switch it to $HOME
      
      2. Start typing "~/Dow" with some file that *does* exist in your $HOME
      
      3. Delete the inline-completion selection (e.g. the "nloads" after "~/Down").
      
      4. While you are at "~/Dow_" hit Tab.  No completion will occur.
      
      This happens because of the following.
      
      Say the GtkFileChooserEntry is in the process of loading $HOME,
      because _set_base_folder() was called.  If the entry contains no text,
      then the FULL_PATH_COLUMN of the file system model will be set to
      unprefixed filenames from $HOME, like
      
        .ssh/
        Documents/
        Downloads/
        somefile.txt
      
      Later we avoid reloading the folder if g_file_equal(old_folder, new_folder).
      
      However, the FULL_PATH_COLUMN gets populated in completion_store_set()
      out of the actual filenames that GIO returned, plus the chooser_entry->dir_part.
      
      If the user starts typing "~/Dow" then dir_part changes to "~/", *but*
      the folder won't be reloaded since it is also $HOME.  However, the completion
      machinery assumes that FULL_PATH_COLUMN will contain prefixed entries like
      
        ~/.ssh/
        ~/Documents/
        ~/Downloads/
        ~/somefile.txt
      
      So, we add an invariant that chooser_entry->dir_part and
      chooser_entry->current_folder_file must change at the same time, and
      must not get out of sync:  If any of them changes, then the
      completions are regenerated.
      81059c35
  5. 23 Jul, 2015 2 commits
  6. 04 Jul, 2015 1 commit
    • Matthias Clasen's avatar
      file chooser entry: Capture Escape and emit :hide-entry · 9b5e00b3
      Matthias Clasen authored
      Make the file chooser entry optionally capture Escape
      and emit a signal. Make the file chooser widget hide the
      entry on that signal and go back to the path bar.
      This gives us a two-level undo:
      location entry -> path bar -> dialog close.
      When the location entry is permanently displayed in the
      header for save mode, we still let the first Escape close
      the dialog.
      9b5e00b3
  7. 06 Apr, 2015 1 commit
  8. 22 May, 2014 1 commit
  9. 19 Feb, 2014 1 commit
  10. 21 Jun, 2013 1 commit
  11. 05 Mar, 2013 2 commits
  12. 29 Mar, 2012 1 commit
  13. 27 Feb, 2012 1 commit
  14. 16 Dec, 2011 24 commits