1. 17 Jan, 2004 3 commits
    • Soeren Sandmann's avatar
      don't leak the menu item ID. · 1daf55ae
      Soeren Sandmann authored
      Sat Jan 17 12:55:13 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	* gtk/gtktoolitem.c (gtk_tool_item_finalize): don't leak the menu
      	item ID.
      1daf55ae
    • Soeren Sandmann's avatar
      Don't leak the overflow menu. · 43b44fff
      Soeren Sandmann authored
      Sat Jan 17 12:37:46 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	* gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the
      	overflow menu.
      
      	* gtk/gtktoolbar.h (struct _GtkToolbar): Make some fields public.
      	[#127726]
      43b44fff
    • Federico Mena Quintero's avatar
      Added a has_editable field. (_gtk_file_system_model_add_editable): New · 02cb4554
      Federico Mena Quintero authored
      2004-01-16  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystemmodel.c (struct _GtkFileSystemModel): Added a
      	has_editable field.
      	(_gtk_file_system_model_add_editable): New function.
      	(_gtk_file_system_model_remove_editable): New function.
      	(gtk_file_system_model_get_value): Return appropriate values for
      	the temporary editable row.
      	(_gtk_file_system_model_get_info): Handle the editable row.
      	(_gtk_file_system_model_get_path): Likewise.
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_append_bookmarks):
      	Removed an unused variable.
      	(toolbar_button_new): Optionally show the button.
      	(up_button_clicked_cb): Renamed from up_button_cb(), fixed prototype.
      	(toolbar_create): Add a "New Folder" button for Save mode.
      	(error_building_filename_dialog): New helper function.
      	(gtk_file_chooser_default_get_paths): Use error_building_filename_dialog().
      	(create_file_list): Connect to the "edited" signal of the text
      	cell renderer.  Store the name column and text renderer in the
      	impl structure.
      	(renderer_edited_cb): New callback.
      	(gtk_file_chooser_default_set_property): Show/hide the "New
      	folder" button when the save action changes.
      	(COMPARE_DIRECTORIES): Allow the info values to be NULL.
      	(COMPARE_DIRECTORIES): Duh, use the list_model, not the
      	tree_model.
      	(get_list_file_info): Likewise!
      	(list_icon_data_func): Handle the path being NULL.
      	(new_folder_button_clicked): New callback.
      	(list_name_data_func): If we are on the editable row, set the text
      	to "Type name of new folder".
      	(list_selection_changed): Handle the editable row.
      	(list_mtime_data_func): Likewise.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_make_path): Return
      	NULL, not FALSE.
      	(gtk_file_system_unix_create_folder): Test the result of mkdir() correctly.
      02cb4554
  2. 16 Jan, 2004 4 commits
    • Matthias Clasen's avatar
      The first part of the fix for #114351 (see also gdk-pixbuf/ChangeLog and · 07d4d314
      Matthias Clasen authored
      Fri Jan 16 23:59:01 2004  Matthias Clasen  <maclas@gmx.de>
      
      	The first part of the fix for #114351 (see also
      	gdk-pixbuf/ChangeLog and po/ChangeLog):
      
      	* gtk/gtkintl.h:
      	* gdk-pixbuf/gdk-pixbuf-i18n.h:
      	* gdk/gdkintl.h: Define P_() for property blurbs and nicks.
      
      	* gdk/gdkdisplaymanager.c:
      	* gdk-pixbuf/gdk-pixbuf.c:
      	* modules/input/gtkimcontextxim.c:
      	* gtk/*.c:  Mark property blurbs and nicks with P_().
      
      	* po/Makefile.in.in: Add --keyword=P_ to the xgettext
      	invocation, since property blurbs and nicks are
      	now marked with P_().
      07d4d314
    • Federico Mena Quintero's avatar
      Fix #130969. · fb526d23
      Federico Mena Quintero authored
      2004-01-16  Federico Mena Quintero  <federico@ximian.com>
      
      	Fix #130969.
      
      	* gtk/gtkcellrenderer.h (struct _GtkCellRendererClass): Added an
      	editing_canceled signal.
      
      	* gtk/gtkcellrenderer.c (gtk_cell_renderer_class_init): Create the
      	"editing-canceled" signal.
      	(gtk_cell_renderer_editing_canceled): New function.
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_editing_done):
      	Call gtk_cell_renderer_editing_canceled().
      fb526d23
    • Federico Mena Quintero's avatar
      Do not allow setting select_multiple when in Save mode. (set_list_model): · c6860c11
      Federico Mena Quintero authored
      2004-01-16  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_set_property): Do not allow setting
      	select_multiple when in Save mode.
      	(set_list_model): No need to nullify the list_model and
      	sort_model.
      	(gtk_file_chooser_default_get_paths): Handle folder mode as well.
      	(get_paths_foreach): Likewise.
      
      	* gtk/gtkfilechooser.c (gtk_file_chooser_get_filename): Clarify
      	documentation about folder mode.
      	(gtk_file_chooser_get_uri): Likewise.
      c6860c11
    • Federico Mena Quintero's avatar
      New get_volume_for_path() method. (struct _GtkFileSystemIface): Finally · f2f12b9a
      Federico Mena Quintero authored
      2004-01-16  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystem.h (struct _GtkFileSystemIface): New
      	get_volume_for_path() method.
      	(struct _GtkFileSystemIface): Finally removed the list_roots() and
      	get_root_info() methods, and the "roots-changed" signal.
      
      	* gtk/gtkfilesystem.c (gtk_file_system_get_volume_for_path): New
      	function.
      	(gtk_file_system_list_roots): Removed.
      	(gtk_file_system_get_root_info): Removed.
      
      	* gtk/gtkfilesystemunix.c
      	(gtk_file_system_unix_get_volume_for_path): Implement.
      	(get_root_volume): New helper function.
      	(gtk_file_system_unix_list_volumes): Use get_root_volume().
      	(gtk_file_system_unix_list_roots): Removed.
      	(gtk_file_system_unix_get_root_info): Removed.
      
      	* gtk/gtkfilesystemmodel.c (_gtk_file_system_model_new): Don't
      	accept a NULL root_path.
      	(struct _GtkFileSystemModel): Add a field to remember the
      	root_path.
      	(_gtk_file_system_model_new): Store the root_path in the model
      	structure.
      	(find_and_ref_path): Stop going up the hierarchy at the root_path
      	of the model.  Also, don't return prematurely when walking up the
      	hierarchy.
      
      	* gtk/gtkfilechooserdefault.c (create_file_list): Sigh, restore
      	the rules_hint.
      	(struct _GtkFileChooserDefault): Added a current_volume_path field.
      	(set_tree_model): New function; create the folder tree model here.
      	(create_folder_tree): Don't create the model here.
      	(set_list_model): Set the show_hidden flag on the list model.
      f2f12b9a
  3. 15 Jan, 2004 3 commits
  4. 14 Jan, 2004 4 commits
  5. 13 Jan, 2004 1 commit
  6. 12 Jan, 2004 1 commit
    • Jody Goldberg's avatar
      Adjust to the new connect_proxy signals. · c73ab06e
      Jody Goldberg authored
      Mon Jan 12 23:40:34 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* tests/testmerge.c: Adjust to the new connect_proxy signals.
      
      	* gtk/gtkuimanager.c
      	* gtk/gtkactiongroup.c
      	* gtk/gtkaction.c: Move the connect_proxy and disconnect_proxy signals
      	from GtkAction to GtkActionGroup and proxy it on GtkUIManager. This
      	removes the confusion between the disconnect_/connect_proxy signals
      	and the (unrelated) virtual functions of the same name and aligns
      	the setup with the pre_/post_activate signals.
      
      2004-01-12  Jody Goldberg <jody@gnome.org>
      
      	* gtk/gtkaction.c (connect_proxy) : only connect activate for menus
      	  with no submenus otherwise it looks like we activate every time a
      	  submenu opens.
      
      2004-01-10  Jody Goldberg <jody@gnome.org>
      
      	* gtk/gtkuimanager.c (d) : Add a debug macro to quiet the spew.
      	s/merge_signals/ui_manager_signals/ for readability.
      	(gtk_ui_manager_class_init) : add pre_activate and post_activate
      	  signals.
      	(cb_proxy_pre_activate) : new.
      	(cb_proxy_post_activate) : new.
      	(gtk_ui_manager_insert_action_group) : connect the proxies for
      	  GtkActionGroup::pre/post_activate
      	(gtk_ui_manager_remove_action_group) : disconnect them.
      
      	* gtk/gtkactiongroup.c (gtk_action_group_class_init) : add
      	  'sensitive', and 'visible' properties.  Also add pre_activate and
      	  post_activate signals to help deal with activations at a higher
      	  level (eg GtkUIManager)
      	(gtk_action_group_init) : init sensitive and visible
      	(gtk_action_group_set_property) : add sensitive and visible
      	(gtk_action_group_get_property) : add sensitive and visible
      	(gtk_action_group_get_sensitive) : new.
      	(gtk_action_group_get_visible) : new.
      	(cb_set_action_sensitivity) : new with minor optimization that only
      	  signals sensitivity changes if the action could possibly change.
      	(cb_set_action_visiblility) : ditto.
      	(gtk_action_group_set_sensitive) : new.  walk the actions directly
      	  rather than using notify::sensitive because that is simpler, easier
      	  to read, and more efficient.
      	(gtk_action_group_set_visible) : ditto.
      	(gtk_action_group_add_action) : Each action can only be in 1 group,
      	  set GtkAction::action_group.
      	(gtk_action_group_remove_action) : clear it.
      	(gtk_action_group_add_toggle_actions_full) : warning suppression.
      	(gtk_action_group_add_radio_actions_full) : warning suppression.
      	(_gtk_action_group_emit_pre_activate) : new protected routine for use
      	  by GtkAction.
      	(_gtk_action_group_emit_post_activate) : ditto.
      
      	* gtk/gtkaction.c (gtk_action_class_init) : add 'action_group' property.
      	(gtk_action_init) : initialize it.
      	(gtk_action_get_property) : get.
      	(gtk_action_set_property) : set it via
      	(gtk_action_set_action_group) : new function.
      	(gtk_action_sync_sensitivity) : new routine to sync proxy sensitivity
      	  with the logical sensitivity (action & group) rather than the simple
      	  action::sensitivity.
      	(gtk_action_sync_visible) : use gtk_action_is_visible to handle
      	  logical visibility (action & group) rather than the simple
      	  action::visible.  Use widget show/hide directly.
      	(connect_proxy) : handle the custom sensitivity handler.
      	  Make the TOOL_BUTTON signals more general and support TOOL_ITEM
      	  directly, with special cases for TOOL_BUTTON.  Still not especially
      	  good it might be useful to handle label/use_underline by parmspec
      	  lookup.  Those are likely to be implemented by custom types, and are
      	  assumed to exist in GtkToolItem.
      	(disconnect_proxy) : disconnect the new sensitivity handler.
      	(_gtk_action_emit_activate) : add pre/post signals.
      	(gtk_action_activate) : use logical sensitivity.
      	(gtk_action_is_sensitive) : logical sensitivity.
      	(gtk_action_get_sensitive) : actual sensitivity.
      	(closure_accel_activate) : use logical sensitivity.
      c73ab06e
  7. 11 Jan, 2004 2 commits
    • Matthias Clasen's avatar
      Remove accidentially committed debug spew. · 93bc689c
      Matthias Clasen authored
      Mon Jan 12 00:10:20 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkuimanager.c: Remove accidentially committed debug spew.
      93bc689c
    • Matthias Clasen's avatar
      Remove accidentally committed notification stuff. · 130c18a1
      Matthias Clasen authored
      Sun Jan 11 01:55:07 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkaccelmap.c: Remove accidentally committed notification stuff.
      	(gtk_accel_map_lock_path):
      	(gtk_accel_map_unlock_path): Path locking can now be nested, a missing
      	entry is silently created during lock_path(), and treated as an error
      	during unlock_path(). These changes have been requested by Tim Janik.
      130c18a1
  8. 09 Jan, 2004 3 commits
  9. 08 Jan, 2004 1 commit
    • Matthias Clasen's avatar
      New function to obtain a list of toplevel widgets constructed by the ui · f2bb20cc
      Matthias Clasen authored
      Fri Jan  9 00:34:57 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkuimanager.h:
      	* gtk/gtkuimanager.c (gtk_ui_manager_get_toplevels): New function to
      	obtain a list of toplevel widgets constructed by the ui manager.
      
      	* gtk/gtkuimanager.h (GtkUIManagerItemType): Change to flags, so that
      	the values can be combined for gtk_ui_manager_get_toplevels().
      
      	* tests/testmerge.c: Add a "Dump toplevels" button to test
      	gtk_ui_manager_get_toplevels().
      f2bb20cc
  10. 07 Jan, 2004 8 commits
    • Matthias Clasen's avatar
      Add entry_completion.c · 5c919e50
      Matthias Clasen authored
      Wed Jan  7 23:20:06 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* demos/gtk-demo/Makefile.am (demos): Add entry_completion.c
      
      	* demos/gtk-demo/entry_completion.c: New demo for GtkEntryCompletion
      	by Anders Carlsson  (#130464).
      5c919e50
    • Matthias Clasen's avatar
      Change the return value from gint to gboolean. (#130718, reported by · bdc6765b
      Matthias Clasen authored
      Wed Jan  7 23:07:28 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkmain.h:
      	* gtk/gtkmain.c (gtk_events_pending): Change the return value from
      	gint to gboolean.  (#130718, reported by Johannes Weißl)
      bdc6765b
    • Matthias Clasen's avatar
      Remove the redundant name and stock_id parameters, adjust all callers. · bc3d9ffa
      Matthias Clasen authored
      Wed Jan  7 23:03:32 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkactiongroup.h:
      	* gtk/gtkactiongroup.c (gtk_action_group_add_action_with_accel):
      	Remove the redundant name and stock_id parameters, adjust all callers.
      bc3d9ffa
    • Matthias Clasen's avatar
      Add creation functions for actions. · a11e45a1
      Matthias Clasen authored
      Wed Jan  7 22:20:20 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkaction.h:
      	* gtk/gtkaction.c (gtk_action_new):
      	* gtk/gtktoggleaction.h:
      	* gtk/gtktoggleaction.c (gtk_toggle_action_new):
      	* gtk/gtkradioaction.h:
      	* gtk/gtkradioaction.c (gtk_radio_action_new): Add creation
      	functions for actions.
      
      	* gtk/gtkactiongroup.c (gtk_action_group_add_actions_full):
      	(gtk_action_group_add_toggle_actions_full):
      	(gtk_action_group_add_radio_actions_full): and use the
      	new functions here.  (#125322, Patch by Jeff Frank)
      a11e45a1
    • Matthias Clasen's avatar
      Fix a bug reference. · 6d665c3a
      Matthias Clasen authored
      6d665c3a
    • Matthias Clasen's avatar
      Fix grammar of docs. · c22143c9
      Matthias Clasen authored
      Wed Jan  7 21:42:49 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkaccelmap.c (gtk_accel_map_lock_path): Fix grammar of
      	docs.
      c22143c9
    • Jan Arne Petersen's avatar
      add REMOVABLE column to the shortcuts_model. · 77cbf47a
      Jan Arne Petersen authored
      2004-01-07  Jan Arne Petersen  <jpetersen@uni-bonn.de>
      
              * gtk/gtkfilechooserdefault.c: (shortcuts_insert_path),
              (shortcuts_append_home), (shortcuts_append_desktop),
              (shortcuts_append_paths), (shortcuts_add_volumes),
              (shortcuts_append_bookmarks), (create_shortcuts_model),
              (gtk_file_chooser_default_add_shortcut_folder): add REMOVABLE column
              to the shortcuts_model.
      
              (remove_bookmark_button_clicked_cb),
              (bookmarks_check_remove_sensitivity): use REMOVABLE column to check if
              bookmarks can be removed. Fixes #129873
      77cbf47a
    • Matthias Clasen's avatar
      Make s, S, Control-S, p, P, Control-P, i, I, Control-I test · 5119687a
      Matthias Clasen authored
      Wed Jan  7 02:50:55 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* demos/testpixbuf-save.c: Make s, S, Control-S, p, P, Control-P,
      	i, I, Control-I test gdk_pixbuf_save(), gdk_pixbuf_save_to_buffer()
      	and gdk_pixbuf_save_to_callback() with jpeg, png and ico formats,
      	respectively. Tests #82203.
      5119687a
  11. 06 Jan, 2004 7 commits
  12. 05 Jan, 2004 1 commit
  13. 04 Jan, 2004 2 commits
    • Soeren Sandmann's avatar
      Change API so group is a GtkRadioButton, not a GtkWidget. · 27ca7a08
      Soeren Sandmann authored
      Sun Jan  4 15:29:04 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	* gtk/gtkradiotoolbutton.[ch]
      	(gtk_radio_tool_button_new_with_stock_from_widget): Change API so
      	group is a GtkRadioButton, not a GtkWidget.
      27ca7a08
    • Hans Breuer's avatar
      use SWP_NOACTIVATE in gdk_window_set_keep_(above|below) to make DND work · 5f987629
      Hans Breuer authored
      2004-01-04  Hans Breuer  <hans@breuer.org>
      
      	* gdk/win32/gdkwindow-win32.c : use SWP_NOACTIVATE in
      	gdk_window_set_keep_(above|below) to make DND work again.
      	Thanks to Alif Wahid for noticing.
      
      	* gdk/gdk.def : update externals
      
      	* gtk/gtkfilesystemwin32.c : adapt to GtkFileSystemIFace changes
      
      	* gtk/gtk-stock.[hc] gtk/gtkiconfactory.c
      	  gtk/stock-icons/Makefile.am gtk/stock-icons/makefile.msc :
      	  gtk/stock-icons/stock_harddisk_16.png
      	  gtk/stock-icons/stock_harddisk_24.png
      	Harddisk stock icons for file system implementations. Beside
      	FLOPPY and CDROM there is now HARDDISK, probably some
      	GTK_STOCK_NETWORK would be useful, but I could not find one.
      5f987629