1. 12 Dec, 2014 1 commit
  2. 26 Nov, 2014 1 commit
    • Emmanuele Bassi's avatar
      Freeze file system model during editing · cbb29385
      Emmanuele Bassi authored
      If a file system event arrives while GtkFileChooserWidget is asking the
      user to edit the name of a newly created folder, the file system model
      will drop the row with the editable cell, and the user will have to
      start from scratch.
      
      This makes creating new directories impossible inside a directory with a
      file currently being downloaded, for instance, and it's really unhelpful
      to the user because the editable row simply disappears.
      
      We already have a mechanism in place to freeze the file system model, so
      we can reuse it between the add_editable() and the remove_editable()
      calls.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=729927
      cbb29385
  3. 21 Feb, 2014 1 commit
  4. 19 Feb, 2014 1 commit
  5. 07 Feb, 2014 1 commit
  6. 05 Feb, 2014 1 commit
  7. 28 Jan, 2014 1 commit
  8. 23 Oct, 2013 1 commit
  9. 02 Nov, 2012 1 commit
    • Federico Mena Quintero's avatar
      bgo#687196 - Fix model corruption during file removal · ea3a750f
      Federico Mena Quintero authored
      The main problem is that we were emitting the row-deleted signal for the model in the middle
      of the process that actually deletes the row from the model (remove the row from the array,
      update the model->file_lookup hash table, etc.).  In the model's caller, one of the row-deleted
      callbacks was requesting an iter, which caused the model to revalidate itself - but it did
      this while it was in an inconsistent state.  This led to an assertion failure later when the
      model resorted itself.
      
      The fix in remove_file() is like this:
      
      * The filteredness/visibility of the deleted node is not updated.  The
        node will simply be gone; we don't need to update those values at
        all.
      
      * We invalidate just the node that is being deleted.
      
      * The model->file_lookup hash table is not completely nuked; instead,
        we carefully adjust its indices.
      
      * The row-deleted signal is only emitted at the very end, when
        deletion is complete and the model is consistent.
      
      Many thanks to William Hua for doing the detective work on this bug!
      Signed-off-by: Federico Mena Quintero's avatarFederico Mena Quintero <federico@gnome.org>
      ea3a750f
  10. 01 Nov, 2012 4 commits
  11. 15 Jul, 2012 5 commits
  12. 27 Feb, 2012 1 commit
  13. 16 Dec, 2011 1 commit
  14. 03 Oct, 2011 1 commit
  15. 28 Mar, 2011 1 commit
  16. 24 Aug, 2010 1 commit
  17. 10 Jul, 2010 1 commit
  18. 28 Jun, 2010 3 commits
  19. 02 May, 2010 1 commit
  20. 04 Apr, 2010 2 commits
  21. 29 Mar, 2010 1 commit
  22. 19 Feb, 2010 1 commit
  23. 02 Nov, 2009 1 commit
    • Benjamin Otte's avatar
      Don't keep the filesystem model alive while querying files · ba9f5339
      Benjamin Otte authored
      This allows disposing of the filesystemmodel while the file enumeration
      is still happening.
      As the filechooser does not disconnect its signals because it assumes it
      is the only owner of the model, this also prevents a SEGV when emitting
      the "load-finished" signal in that case.
      ba9f5339
  24. 15 Oct, 2009 7 commits