1. 17 Nov, 2014 1 commit
    • Timm Bäder's avatar
      GtkDialog: Connect to activate signals only once · 56133a1f
      Timm Bäder authored
      If the widget is an action widget, it's been previously added with
      gtk_dialog_add_action_widget, which calls add_response_data on it, which
      in turn connects to the clicked/activate signal of that widget, so we
      don't need to connect to that signal a second time in
      gtk_buildable_custom_finished.
      56133a1f
  2. 06 Sep, 2014 1 commit
  3. 29 Aug, 2014 1 commit
  4. 20 Jul, 2014 1 commit
  5. 17 Jul, 2014 2 commits
    • Matthias Clasen's avatar
      GtkDialog: Be more careful in handling the headerbar · 24e70731
      Matthias Clasen authored
      Just because an action widget has a parent thats a headerbar,
      it is not guaranteed that it is 'our' headerbar. Add some
      assertions to enforce this.
      24e70731
    • Matthias Clasen's avatar
      GtkDialog: rejigger headerbar handling · 7b407145
      Matthias Clasen authored
      We can't avoid calling set_titlebar in buildable_add_child, since
      GtkBuilder assumes that it can e.g. call grab_default at the end,
      which only works if the widget is inside a toplevel at that point.
      
      Instead, drop the titlebar and clean up priv->headerbar in constructed
      if we find that we don't want a headerbar.
      7b407145
  6. 16 Jul, 2014 1 commit
  7. 13 Jul, 2014 1 commit
  8. 09 Jul, 2014 1 commit
    • Matthias Clasen's avatar
      GtkDialog: Fix setting of default action · 8afd4b71
      Matthias Clasen authored
      The recent reshuffling caused an ordering problem where we would
      hide the action area before relocating the buttons to the header
      bar. But hiding makes the default button loose its defaultness.
      Rearrange things so that we move the buttons before hiding the
      action area, and thus preserve the default.
      8afd4b71
  9. 02 Jul, 2014 1 commit
    • Matthias Clasen's avatar
      GtkDialog: fix invisible action area · 10892863
      Matthias Clasen authored
      When there area explicitly added buttons in the action area,
      we were trying to ensure that the action area is visible,
      but failed, since we are now hiding the action_box. Fix it
      by showing the action_box when things are left in the action
      area.
      10892863
  10. 01 Jul, 2014 1 commit
  11. 26 Jun, 2014 1 commit
  12. 06 Jun, 2014 2 commits
    • Matthias Clasen's avatar
      GtkDialog: Be a little more careful about button placement · 02a44c45
      Matthias Clasen authored
      We were applying response based heuristics, even if the button
      is explicitly put in the headerbar. That broke button placement
      in some epiphany dialogs, such as the Cookies one. Therefore,
      restrict the heuristics to action widgets that are added through
      gtk_widget_add_action_widget() or <child type="action">, where it
      is not possible to specify placement explicitly.
      02a44c45
    • Matthias Clasen's avatar
      GtkDialog: avoid a crash · 9c6c4fde
      Matthias Clasen authored
      Just because use-header-bar is set, it is not safe to assume
      every action widget is in the headerbar, so be careful when
      setting child properties.
      9c6c4fde
  13. 05 Jun, 2014 2 commits
    • Matthias Clasen's avatar
      Remove unintentional addition · 7aadd6fd
      Matthias Clasen authored
      Debugging leftovers.
      7aadd6fd
    • Matthias Clasen's avatar
      GtkDialog: Improve the buildable implementation · d724175e
      Matthias Clasen authored
      When combining action child type with <action-widgets> to assign
      response ids, we were not properly updating buttons that ended up
      getting added to the headerbar before they have a response id.
      Fix this by reapplying the headerbar button setup after parsing
      <action-widgets>, and make sure to also update the suggested-action
      style class.
      d724175e
  14. 28 May, 2014 1 commit
  15. 03 May, 2014 1 commit
  16. 02 May, 2014 1 commit
  17. 26 Apr, 2014 2 commits
  18. 23 Apr, 2014 1 commit
  19. 10 Apr, 2014 1 commit
    • Matthias Clasen's avatar
      GtkDialog: fix up handling of style properties · 28327ee9
      Matthias Clasen authored
      The use of border-width-set here was an attempt to differentiate
      between explicitly set (from code / ui files) border width from
      theme changes. But when we are calling gtk_window_set_border_width
      to apply the theme value, the -set property gets set, and all
      further theme changes are ignored. This has the effect of only
      letting the default value of these properties get applied.
      
      Fix this by unsetting border-width-set after applying theme values.
      28327ee9
  20. 24 Mar, 2014 2 commits
  21. 21 Mar, 2014 1 commit
  22. 18 Mar, 2014 1 commit
  23. 17 Mar, 2014 1 commit
  24. 14 Mar, 2014 1 commit
    • Matthias Clasen's avatar
      Show dialog titles · 3504f494
      Matthias Clasen authored
      We want to present a clean, rounded top when there is nothing
      else to show, but many dialogs in applications rely on showing
      information in their title, so add a label and show the title
      when it is not empty.
      3504f494
  25. 03 Mar, 2014 1 commit
  26. 27 Feb, 2014 2 commits
  27. 19 Feb, 2014 1 commit
  28. 15 Feb, 2014 1 commit
  29. 12 Feb, 2014 1 commit
    • William Jon McCann's avatar
      docs: fully break lines in examples · 37a8ee6e
      William Jon McCann authored
      Try to do a better job of keeping example content
      from being too wide. It is often rendered as <pre>
      text so the only time we can wrap it is in the source.
      
      It is best to full break lines at all punctuation and
      to try to keep the width under 70 chars or so.
      37a8ee6e
  30. 09 Feb, 2014 1 commit
  31. 08 Feb, 2014 1 commit
  32. 07 Feb, 2014 3 commits