1. 08 Dec, 2004 5 commits
    • Matthias Clasen's avatar
      Fix #111031, reported by Padraig O'Briain: · 057ab5a4
      Matthias Clasen authored
      2004-12-08  Matthias Clasen  <mclasen@redhat.com>
      
      	Fix #111031, reported by Padraig O'Briain:
      
      	* gtk/gtktextlayout.h:
      	* gtk/gtktextlayout.c (gtk_text_layout_get_iter_at_position):
      	Add a variant of gtk_text_layout_get_iter_at_pixel() which
      	returns the character at the position, not the closest
      	cursor position.
      
      	* gtk/gtktextview.h:
      	* gtk/gtktextview.c (gtk_text_view_get_iter_at_position):
      	Add a variant of gtk_text_view_get_iter_at_location() which
      	returns the character at the position, not the closest
      	cursor position.
      057ab5a4
    • Matthias Clasen's avatar
      Remove all entries for the same key, not just the first one. (#159498, · 456ebcea
      Matthias Clasen authored
      2004-12-08  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkaccelmap.c (internal_change_entry): Remove all
      	entries for the same key, not just the first one.  (#159498,
      	Christian Persch)
      456ebcea
    • Matthias Clasen's avatar
      Use button->event_window for the fake leave event, otherwise the button · 2851547b
      Matthias Clasen authored
      2004-12-08  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Use
      	button->event_window for the fake leave event, otherwise
      	the button ignores it.
      2851547b
    • Matthias Clasen's avatar
      Make this work, no need to invert the array. · cc0cc60e
      Matthias Clasen authored
      2004-12-07  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkiconview.c (gtk_icon_view_rows_reordered): Make this
      	work, no need to invert the array.
      
      	* gtk/gtkliststore.c (gtk_list_store_sort_iter_changed): Emit
      	rows_reordered if the row has been moved.  (#160063)
      cc0cc60e
    • Matthias Clasen's avatar
      Don't mess up the column header state if the button release event is · d4d6f28a
      Matthias Clasen authored
      2004-12-07  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_button_event):
      	Don't mess up the column header state if the button release
      	event is missed.  (#159640)
      d4d6f28a
  2. 07 Dec, 2004 3 commits
  3. 06 Dec, 2004 1 commit
  4. 05 Dec, 2004 2 commits
  5. 03 Dec, 2004 4 commits
  6. 02 Dec, 2004 4 commits
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · bc63304b
      Federico Mena Quintero authored
      2004-12-02  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #159656:
      
      	* gtk/gtkfilechooserdefault.c (PendingOp): New enumeration for the
      	pending operation to perform when finishing loading a folder.
      	(struct _GtkFileChooserDefault): New fields 'pending_op' and
      	'pending_select_path'.
      	(pending_op_queue): New utility function.
      	(pending_op_process): New utility function.
      	(gtk_file_chooser_default_select_path): Don't select the path
      	immediately; delay it until the folder is finished loading.
      	(browse_files_model_finished_loading_cb): Process the pending
      	operation.
      	(browse_files_select_first_row): New utility function.
      	(gtk_file_chooser_default_initial_focus): Use
      	browse_files_select_first_row().
      	(gtk_file_chooser_default_should_respond): Queue an operation to
      	select the first row once we load the child folder.
      	(up_folder_handler): Queue an operation to select the current
      	folder once we load the parent folder.
      	(gtk_file_chooser_default_finalize): Free the pending_select_path.
      bc63304b
    • Manish Singh's avatar
      Make sure we always return a value. Return None in the fallthrough case. · a5e9b748
      Manish Singh authored
      Thu Dec  2 13:18:34 2004  Manish Singh  <yosh@gimp.org>
      
              * gdk/x11/gdkgc-x11.c (make_fg_tile_picture): Make sure we always
              return a value. Return None in the fallthrough case.
      a5e9b748
    • Matthias Clasen's avatar
      Don't leak pango_font_description object (#160214, Frederic Crozat). · 69055d82
      Matthias Clasen authored
      2004-12-02  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkmessagedialog.c: (setup_primary_label_font):
      	Don't leak pango_font_description object (#160214, Frederic Crozat).
      69055d82
    • Matthias Clasen's avatar
      Handle the fact the the changed row may also be moved. (#159387, Olivier · 0a100408
      Matthias Clasen authored
      2004-12-01  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkiconview.c (gtk_icon_view_row_changed): Handle the
      	fact the the changed row may also be moved.  (#159387, Olivier
      	Andrieu)
      0a100408
  7. 01 Dec, 2004 5 commits
  8. 30 Nov, 2004 13 commits
    • Dom Lachowicz's avatar
      39b513a5
    • Søren Sandmann's avatar
      Assign an arbitrary, but consistent, order to nodes that the user function · 0045a92d
      Søren Sandmann authored
      Tue Nov 30 17:53:37 2004  Søren Sandmann  <sandmann@redhat.com>
      
      	* gtk/gtksequence.c (node_compare): Assign an arbitrary, but
      	consistent, order to nodes that the user function compares as
      	equal. Better fix for bug #157670 and a better way to make sorting
      	stable.
      0045a92d
    • Hans Breuer's avatar
      remove the disputable memset at the end of gdk_pixmap_new() - on X11 the · 8dcf7d1d
      Hans Breuer authored
      2004-11-30  Hans Breuer  <hans@breuer.org>
      
      	* gdk/win32/gdkpixmap-win32.c : remove the disputable memset at
      	the end of gdk_pixmap_new() - on X11 the bits are not initialized
      	either - fixes bug #145107
      
      	* gtk/gtkfilesystemwin32.c : add an idle handler to emit "volumes-changed"
      	when drives are plugged in or removed. Fixes bug #137815
      8dcf7d1d
    • Matthias Clasen's avatar
      Update the documentation to specify a more useful behaviour, which can be · 35a3099e
      Matthias Clasen authored
      2004-11-30  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktreesortable.c (gtk_tree_sortable_get_sort_column_id): Update
      	the documentation to specify a more useful behaviour, which can be
      	implemented with the multiple special values we have now.  (#159984,
      	Nicholas Rahn)
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_get_sort_column_id):
      	* gtk/gtktreestore.c (gtk_tree_store_get_sort_column_id):
      	* gtk/gtkliststore.c (gtk_list_store_get_sort_column_id): Update the
      	implementations.
      35a3099e
    • Owen Taylor's avatar
      Don't paint in the trailing end of a wrapped line when the selection · 126efafc
      Owen Taylor authored
      Tue Nov 30 16:25:29 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktextdisplay.c (render_para): Don't paint in the
              trailing end of a wrapped line when the selection
              starts after the line. (#159984, Matthias Clasen)
      
              * gtk/gtktextdisplay.c (gtk_text_layout_draw): pass in byte_count + 1
              for selection_end index when the selection end is past the end of the
              line so that render_para() can distinguish it from selection-end
              *at* the end of the line. Fixes newlines not being selected.
      126efafc
    • James M. Cape's avatar
      removed "GtkFileChooserButton:active" property and getter/setter. · 1b45c640
      James M. Cape authored
      2004-11-30  James M. Cape  <jcape@ignore-your.tv>
      
              * gtk/gtkfilechooserbutton.h (gtk_file_chooser_button_get_active)
              (gtk_file_chooser_button_set_active):
              * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_class_init)
              (gtk_file_chooser_button_get_active)
              (gtk_file_chooser_button_set_active):
              * docs/reference/gtk/gtk-sections.txt:
              * docs/reference/gtk/tmpl/gtkfilechooserbutton.sgml:
              * gtk/gtk.symbols: removed "GtkFileChooserButton:active" property and
              getter/setter.
      
              * gtk/gtkfilechooserbutton.c (struct _GtkFileChooserButtonPrivate)
              (button_toggled_cb) (dialog_response_cb) (button_notify_active_cb)
              (gtk_file_chooser_button_init) (button_clicked_cb)
              (gtk_file_chooser_button_show): Use a GtkButton instead of a
              GtkToggleButton.
              (struct _GtkFileChooserButtonPrivate)
              (gtk_file_chooser_button_destroy) (gtk_file_chooser_button_style_set)
              (gtk_file_chooser_button_screen_changed): Don't bother with the
              (remove_settings_signal) (settings_notify_cb) (check_icon_theme):
              Don't use GtkSettings at all, just call change_icon_theme() directly.
              (struct _GtkFileChooserButtonPrivate)
              (gtk_file_chooser_button_init)
              (gtk_file_chooser_button_drag_data_received)
              (gtk_file_chooser_button_mnemonic_activate)
              (gtk_file_chooser_button_set_width_chars)
              (gtk_file_chooser_button_get_width_chars)
              (entry_changed_cb) (update_idler) (update_entry) (update_dialog)
              (dialog_selection_changed_cb) (dialog_response_cb)
              (entry_size_allocate_cb): Remove all references to the now-defunct
              entry, store the old path (to support "Cancel") in an instance member.
              (update_label_and_image) (update_label) (update_image)
              (gtk_file_chooser_button_init) (dialog_response_cb)
              (dialog_selection_changed_cb): Merge label/image updates, only display
              the filename (not the whole path, fixes #157725).
              (struct _GtkFileChooserButtonPrivate)
              (dialog_selection_changed_cb)
              (dialog_selection_changed_proxy_cb): Merge "selection-changed"
              handlers, block while dialog is visible (fixes #158482).
      
              * tests/testfilechooserbutton.c (delete_event_cb)
              (properties_button_clicked_cb) (print_selected_path_clicked_cb)
              (tests_button_clicked_cb) (main): Add per-chooser "tests" window,
              don't delete on WM close, update properties_button_clicked_cb()
              "delete-event" callback.
      1b45c640
    • Dwayne Bailey's avatar
      Added "nso" to ALL_LINGUAS. · f79a113b
      Dwayne Bailey authored
      2004-11-30  Dwayne Bailey  <dwayne@translate.org.za>
      
      	* configure.in: Added "nso" to ALL_LINGUAS.
      
      	* po/nso.po, po-properties/nso.po: Added Northern Sotho translation by
      	Zuza Software Foundation <info@translate.org.za>.
      f79a113b
    • Owen Taylor's avatar
      gdk/x11/gdkdrawable-x11.c (_gdk_x11_drawable_draw_xtrapezoids) Call · 683a00b6
      Owen Taylor authored
      Tue Nov 30 09:46:49 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gdk/x11/gdkdrawable-x11.c (_gdk_x11_drawable_draw_xtrapezoids)
              * gdk/x11/gdkdrawable-x11.c (_gdk_x11_drawable_draw_xft_glyphs):
              Call gdk_x11_drawable_update_xft_clip (part of #159929,
              James Henstridge)
      
              * gdk/x11/gdkdrawable-x11.c (gdk_x11_draw_glyphs_transformed):
              Remove unused variables.
      683a00b6
    • Owen Taylor's avatar
      A little bit of microoptimization of repeated GDK_GC_XDISPLAY()/XGC(). · 6510bbf4
      Owen Taylor authored
      Tue Nov 23 19:37:34 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gdk/x11/gdkgc-x11.c (_gdk_x11_gc_flush): A little bit
              of microoptimization of repeated GDK_GC_XDISPLAY()/XGC().
      6510bbf4
    • Matthias Clasen's avatar
      Updates · 71a28b4b
      Matthias Clasen authored
      71a28b4b
    • Matthias Clasen's avatar
      Don't do the popup-on-click handling for menubars. (#159931, Søren · 4e67511f
      Matthias Clasen authored
      2004-11-29  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkmenushell.c (gtk_menu_shell_button_release): Don't
      	do the popup-on-click handling for menubars.  (#159931,
      	Søren Sandmann)
      
      	* gtk/gtkmenuitem.c (gtk_real_menu_item_select): Don't
      	handle popup delay if the submenu is already mapped.
      4e67511f
    • Manish Singh's avatar
      remove gtk_cell_view_set_cell_data() declaration. · eec3339f
      Manish Singh authored
      Mon Nov 29 16:56:33 2004  Manish Singh  <yosh@gimp.org>
      
              * gtk/gtkcellview.h: remove gtk_cell_view_set_cell_data() declaration.
      eec3339f
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · d5323add
      Federico Mena Quintero authored
      2004-11-29  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c (trap_activate_cb): Don't handle
      	Enter if we are in SELECT_FOLDER or CREATE_FOLDER actions.  This
      	lets us navigate thei file system more easily.
      	(gtk_file_chooser_default_should_respond): If we are in
      	SELECT_FOLDER or CREATE_FOLDER modes, return TRUE if something is
      	selected.
      d5323add
  9. 29 Nov, 2004 3 commits
    • Søren Sandmann's avatar
      If the item is already in the right place, don't move it. Bug #157670. · f985442a
      Søren Sandmann authored
      Mon Nov 29 17:51:51 2004  Søren Sandmann  <sandmann@redhat.com>
      
             * gtk/gtksequence.c (_gtk_sequence_sort_changed): If the item is
             already in the right place, don't move it. Bug #157670.
      
             * gtk/gtksequence.c (already_in_place): New function
      f985442a
    • Søren Sandmann's avatar
      Take nodes in reverse order to make sure sort is stable. · f688fff6
      Søren Sandmann authored
      Mon Nov 29 17:28:53 2004  Søren Sandmann  <sandmann@redhat.com>
      
      	* gtk/gtksequence.c (_gtk_sequence_sort): Take nodes in reverse
      	order to make sure sort is stable.
      f688fff6
    • Matthias Clasen's avatar
      Don't call gtk_cell_view_set_cell_data() from here. · ec6454bf
      Matthias Clasen authored
      2004-11-29  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcombobox.c (cell_view_is_sensitive): Don't call
      	gtk_cell_view_set_cell_data() from here.
      
      	* gtk/gtk.symbols: Remove gtk_cell_view_set_cell_data()
      
      	* gtk/gtkcellview.c (gtk_cell_view_get_cell_renderers): Call
      	gtk_cell_view_set_cell_data() from here.
      	(gtk_cell_view_set_cell_data): Make static.
      
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_popup): Make menu mode
      	work better when resizing the combo box.
      ec6454bf