Commit fb08a26a authored by Matthias Clasen's avatar Matthias Clasen

GtkWindow: use a weak ref to keep track of attach_widget

Taking a full reference of the attach widget creates a reference
cycle, and keeps the attach_widget alive longer than it should.
parent f326c0ea
......@@ -2510,7 +2510,7 @@ remove_attach_widget (GtkWindow *window)
{
_gtk_widget_remove_attached_window (priv->attach_widget, window);
g_object_unref (priv->attach_widget);
g_object_remove_weak_pointer (priv->attach_widget, &priv->attach_widget);
priv->attach_widget = NULL;
}
}
......@@ -2760,7 +2760,7 @@ gtk_window_set_attached_to (GtkWindow *window,
{
_gtk_widget_add_attached_window (priv->attach_widget, window);
g_object_ref (priv->attach_widget);
g_object_add_weak_pointer (priv->attach_widget, &priv->attach_widget);
}
/* Update the style, as the widget path might change. */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment